ext/soap: Minor refactoring to wsdl_message()

ext/soap: Reduce scope and use proper names for XML attribute variables

ext/soap: Indentation fix

ext/soap: Check services are not empty via an if guard

ext/soap: Eliminate some variable shadowing

ext/soap: Use bool instead of int

ext/soap: Replace memset with 0 initialization

ext/soap: Reduce scope of variable

Avoid copying the local name in SOAP's parse_namespace() (#15862)

The local name is either the entire input or is the last part, so we
never need to make a copy.

Fix bug #73182: PHP SOAPClient does not support stream context HTTP headers in array form

This code is modelled after how `http_fopen_wrapper.c` does things,
which apparently is just loo

Fix bug #73182: PHP SOAPClient does not support stream context HTTP headers in array form

This code is modelled after how `http_fopen_wrapper.c` does things,
which apparently is just looping over the array and handling each string
the same way as if we passed a header string directly.

Also fixes a potential crash in `php_sdl.c` but without adding support
for header arrays there (yet) because the code is untested.

Closes GH-15817.

show more ...

Deduplicate URI building code in soap schema code (#15799)

ext/soap: Initialize a HashTable of size j

The i seems to be a mistake as everything else uses j

ext/soap: Add const qualifiers for serialize functions

As serializing something should not affect the value of it

ext/soap: mark string param of sdl_serialize_key() as const

Add const qualifiers to the variables at the call size
Rename variables when they were shadowing a variable from the outer sco

ext/soap: mark string param of sdl_serialize_key() as const

Add const qualifiers to the variables at the call size
Rename variables when they were shadowing a variable from the outer scope

show more ...

ext/soap: Remove cast from macro

Move it to the one call site that requires it

ext/soap: convert int type to size_t where appropriate

ext/soap: Rename MD5 context variable to not shadow the stream context variable

ext/soap: Refactor SDL delete functions

Use a common implementation for persistent and non-persistent functions

Clean-up some more headers (#14416)

Remove unused headers (such as php_ini.h for extensions that don't define INI settings)
Use more specific headers when possible

Remove unused internal functions in soap

Fix signedness issues in soap.c

Migrate SOAP SDL resource to object

Related to https://wiki.php.net/rfc/resource_to_object_conversion and https://github.com/php/php-tasks/issues/6
Closes GH-14121

Fix libxml2 2.12 build due to API breaks

See https://github.com/php/php-src/actions/runs/7062192818/job/19225478601

Fix GH-12838: [SOAP] Temporary WSDL cache files not being deleted

If there are two users that can execute the script that caches a WSDL,
but the script is owned by a single user, then th

Fix GH-12838: [SOAP] Temporary WSDL cache files not being deleted

If there are two users that can execute the script that caches a WSDL,
but the script is owned by a single user, then the caching code will
name the cached file with the file owner username and a hash of the uri.
When one of the two tries to rename the file created by the other
process, this does not work because it has no permission to do so.
This then leaves temporary files floating in the temp directory.

To fix the immediate problem, unlink the file after rename has failed.
On the long term, this has to be fixed by taking the username of the
process instead of the username of the file owner.

Closes GH-12841.

show more ...

Fix bug #75306: Memleak in SoapClient

Setting the stream context via php_stream_context_to_zval() will
increase the reference count. So if the new context is created, then it
will en

Fix bug #75306: Memleak in SoapClient

Setting the stream context via php_stream_context_to_zval() will
increase the reference count. So if the new context is created, then it
will end up with a reference count of 2 while it should be 1.

Credits to cmb for the analysis. I arrived at the same patch as he did.

Closes GH-12523.

show more ...