Enhancement: Enable `blank_line_after_opening_tag` fixer (#875)

Enhancement: Enable `trailing_comma_in_multiline` fixer (#647)

* Enhancement: Enable and configure trailing_comma_in_multiline fixer

* Fix: Run 'make coding-standards'

Enhancement: Enable and configure `concat_space` fixer

Closes GH-657.

Enhancement: Enable `array_syntax` fixer

Co-authored-by: MathiasReker <mathias@reker.dk>

Closes GH-659.

Enhancement: Enable `strict_param` fixer

We set strict param to false to ensure current behavior,
except for two cases where it is safe to go with true.

Closes GH-658.

Fix: Replace weird comment with DocBlock

Closes GH-649.

Enhancement: Enable `no_extra_blank_lines` fixer

Closes GH-646.

Enhancement: Enable `single_space_after_construct` fixer

Closes GH-640.

Enhancement: Enable `indentation_type` fixer

Closes GH-622.

Multiple micro-optimizations

* Replace `ob_get_contents();ob_clean()` with `ob_get_clean()`

`ob_get_clean()` is equivalent to `ob_get_contents()` followed by `ob_clean()`.

Multiple micro-optimizations

* Replace `ob_get_contents();ob_clean()` with `ob_get_clean()`

`ob_get_clean()` is equivalent to `ob_get_contents()` followed by `ob_clean()`.

* Replace `intval()` calls with `(int)` type cast

This is a micro-optimization because `intval()` is a function call, and the type cast is about 6 times fast.

* Replace `preg_replace` call that could be done with an `rtrim()` call

In `./error.php`, there is a `preg_replace('!/+$!', '', $URI);` call that essentially is equivalent to `rtrim()`, that both calls removing trailing slash characters in `$URI`.
The `rtim()` call is more legible and faster.

* Combine consecutive `str_replace` calls to a single `str_replace` call

* Use short ternary operator where possible

Improves code readability.

* Cascade various `else` statements where possible

Cleans up the code by removing unnecessary `else` blocks and moving the code to the parent context if the previous `if` block exits the function by either terminating the script, or with a `return` statement.

* Combine multiple `isset()` calls to a single `isset()`

`isset()` accepts multiple parameters and returns `true` only if all of the parameters are `isset`. It makes sense to combine multiple individual `isset` calls to a single call for better readability.

* Replace `for` loop with a `foreach` loop

* Remove unnecessary character escapes in regular expressions

Regular expression special characters are context-sensitive. For example, special characters such as `.` are not considered special within square braces (`[]`).
This removes several of such instances that certain characters are escaped, but it is not strictly necessary within the context. This improves the readability of the expression.

See more information at [PHP.Watch: Writing better Regular Expressions in PHP](https://php.watch/articles/php-regex-readability#reduce-escape)

* Remove unnecessary break statement

* Remove unnecessary PHP close tags

* Remove redundant JSON_ERROR_NONE check

Remove unnecessary `json_last_error() == JSON_ERROR_NONE` where the decoded object is inspected already.

Closes GH-603.

show more ...

Fix: Remove unused parameter

* Fix: Remove unused parameter
* Fix: Remove unused local variable

Closes GH-574.

Add void return types

Add void return type to functions with missing or empty return statements.

Closes GH-535.

Single blank line at eof

A PHP file without end tag should always end with a single empty line feed.

Closes GH-541.

Add supported versions in json payload (#514)

Refactor releases/index.php

Swap uses of _SERVER[DOCUMENT_ROOT] for __DIR__

4/4 - Update releases directory.

Bye bye PHP 5

Consider all releases with the same EOL date

The algorithm to find the two most recently EOL'd versions built an
array where the EOL date is the key. This can't work for multiple
re

Consider all releases with the same EOL date

The algorithm to find the two most recently EOL'd versions built an
array where the EOL date is the key. This can't work for multiple
releases with the same EOL date. We **hack** around this by increasing
the timestamp to avoid duplicates being overwritten.

show more ...

Remove out-dated info regarding Windows builds

Refactor each() function to foreach()

The each() function has been deprecated since PHP 7.2 and shouldn't be
used anymore:
- http://php.net/manual/en/function.each.php

Fix #72707: Filter releases by minor version

- Rewrite version-specific part of releases API to loop over releases
only once
- Releases API: filter by minor or patch version, if pr

Fix #72707: Filter releases by minor version

- Rewrite version-specific part of releases API to loop over releases
only once
- Releases API: filter by minor or patch version, if provided
- Remove unused variable
- Rewrite version_array() to use array_pad(). Intended behavior:
- If count($versionArray) is less than $length, version_array()
should pad it with 0s to $length.
- If count($versionArray) is greater than $length, version_array()
should slice it to $length.
- If $length is not set, leave $versionArray as-is after exploding it.
- Remove unused variable
- Still print "Unknown version" if the major version is found but the
minor or patch version is not.
- Remove excess white space
- Bind array_replace_recursive() result to new variable instead of
mutating $RELEASES global
- Only set $machineReadable to its first element if $machineReadable is
not empty.

show more ...

Sync final and leading newlines

This patch adds some missing newlines, trims some multiple redundant
final newlines into a single one, and trims few redundant leading
newlines.

Sync final and leading newlines

This patch adds some missing newlines, trims some multiple redundant
final newlines into a single one, and trims few redundant leading
newlines.

According to POSIX, a line is a sequence of zero or more non-'<newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2

show more ...

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
use

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.

show more ...

Fix formatting when both md5/sha256 are available

This should probably be done more cleanly with CSS,
but this is a quick and dirty good-enough fix.

Include sha256 checksums on /releases page