Enhancement: Enable `void_return` fixer (#661)

* Enhancement: Enable void_return fixer

* Fix: Run 'make coding-standards'

Enhancement: Enable `array_syntax` fixer

Co-authored-by: MathiasReker <mathias@reker.dk>

Closes GH-659.

Fix CS violations (case of null, false and true)

Fix: Remove unused references to a global variable (#563)

Sync final and leading newlines

This patch adds some missing newlines, trims some multiple redundant
final newlines into a single one, and trims few redundant leading
newlines.

Sync final and leading newlines

This patch adds some missing newlines, trims some multiple redundant
final newlines into a single one, and trims few redundant leading
newlines.

According to POSIX, a line is a sequence of zero or more non-'<newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2

show more ...

Trim trailing whitespace

This patch cleans all redundant trailing whitespace across the
repository except for the icalendar files.

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
use

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.

show more ...

This hasn't been used in a looong time. Fixes bug #54377

Fix downloads by using the right variable.

Fixes bug #66142 (Impossible to download PHP from website).

Download system tweaks

Remove reduntant/duplicate code between do-download and get-download

Also make this page more interesting when the download is missing from
this specific

Download system tweaks

Remove reduntant/duplicate code between do-download and get-download

Also make this page more interesting when the download is missing from
this specific mirror by give the choise of going to other mirrors to check.
Rather then blindly go to the download file though we go to the same page
on the other mirror so we can check if the file exists there before giving
the link to the actual real file.

This also makes it a lot easier to work with on developers checkouts

show more ...

Remove transitional master2 hostname

use master2

Fix xss on bogus filenames (reported by Rasmus)

Fix xss problems

Fixed bug#44916 (wong status code)

Force correct status code (bug#36440)

link to the mirror list, and not the download mirror selector, since if the file is not available, the download mirror selector will also emit an error. so fit this download mirror selector too, to i

link to the mirror list, and not the download mirror selector, since if the file is not available, the download mirror selector will also emit an error. so fit this download mirror selector too, to inform the user

show more ...

intercept executable downloads, and inform users on a solution

downloads are not working, since the master server is down. PLEASE remove the comment if the master server is up again

Include filename and server name in the error message, so we would
know this instantly in case one copy-paster submits this as an error
report to us.

Support the download of manual files via short URLs, and with
mirror selection, as discussed on the last docmeeting

No need to make $_SERVER global anymore, we have 4.1.x+
as a requirement currently...

Fix text in comment

Move do-download code to the include dir, as we
have no official direct interface for direct downloads,
and it would be painfull to maintain one

Also make the download code much more

Move do-download code to the include dir, as we
have no official direct interface for direct downloads,
and it would be painfull to maintain one

Also make the download code much more modern using
$_SERVER and $_REQUEST vars, instead of globals,
also use i2c_realip() for more accurate() IP detection

show more ...