#
dd8d8bf8 |
| 17-Oct-2018 |
Peter Kokot |
Sync final and leading newlines This patch adds some missing newlines, trims some multiple redundant final newlines into a single one, and trims few redundant leading newlines.
Sync final and leading newlines This patch adds some missing newlines, trims some multiple redundant final newlines into a single one, and trims few redundant leading newlines. According to POSIX, a line is a sequence of zero or more non-'<newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
show more ...
|
#
5335474a |
| 02-Jul-2014 |
Adam Harvey |
Add Twitter icon to the home page, linking to @official_php. I've deliberately implemented this in such a way as to allow for further social media buttons down the track if we want. I've
Add Twitter icon to the home page, linking to @official_php. I've deliberately implemented this in such a way as to allow for further social media buttons down the track if we want. I've also kept it intentionally unobtrusive: it's there (previously, we only mentioned the Twitter account on the mailing lists page, which was weird), but pretty subtle in the sidebar. There's one additional dependency: a one glyph subset of Font Awesome (created using Fontello) containing the Twitter icon. (Should we later want to include other icons from Font Awesome, fonts/Font-Awesome/config.json can be fed back into Fontello as a starting point.) The additional style sheet and font file are cached correctly, and once loaded by the user, shouldn't need to be loaded again, as with Fira Sans. On a cold page load, this adds two requests and just under 3 kB to the page load. I consider all of this reasonable, both technically and in terms of promoting @official_php a little more, but I won't be terribly offended if someone wants to revert this.
show more ...
|