List syntax (#529)

List (array destructuring) assignment should be declared using the configured syntax.

Enhancement: Enable `binary_operator_spaces` fixer

Closes GH-667.

Enhancement: Enable and configure `concat_space` fixer

Closes GH-657.

Enhancement: Enable `array_syntax` fixer

Co-authored-by: MathiasReker <mathias@reker.dk>

Closes GH-659.

Enhancement: Enable `strict_param` fixer

We set strict param to false to ensure current behavior,
except for two cases where it is safe to go with true.

Closes GH-658.

Enhancement: Enable `constant_case` fixer

Co-authored-by: MathiasReker <mathias@reker.dk>

Closes GH-660.

Enhancement: Enable `single_space_after_construct` fixer

Closes GH-640.

Combine consecutive unsets (#543)

Multiple micro-optimizations

* Replace `ob_get_contents();ob_clean()` with `ob_get_clean()`

`ob_get_clean()` is equivalent to `ob_get_contents()` followed by `ob_clean()`.

Multiple micro-optimizations

* Replace `ob_get_contents();ob_clean()` with `ob_get_clean()`

`ob_get_clean()` is equivalent to `ob_get_contents()` followed by `ob_clean()`.

* Replace `intval()` calls with `(int)` type cast

This is a micro-optimization because `intval()` is a function call, and the type cast is about 6 times fast.

* Replace `preg_replace` call that could be done with an `rtrim()` call

In `./error.php`, there is a `preg_replace('!/+$!', '', $URI);` call that essentially is equivalent to `rtrim()`, that both calls removing trailing slash characters in `$URI`.
The `rtim()` call is more legible and faster.

* Combine consecutive `str_replace` calls to a single `str_replace` call

* Use short ternary operator where possible

Improves code readability.

* Cascade various `else` statements where possible

Cleans up the code by removing unnecessary `else` blocks and moving the code to the parent context if the previous `if` block exits the function by either terminating the script, or with a `return` statement.

* Combine multiple `isset()` calls to a single `isset()`

`isset()` accepts multiple parameters and returns `true` only if all of the parameters are `isset`. It makes sense to combine multiple individual `isset` calls to a single call for better readability.

* Replace `for` loop with a `foreach` loop

* Remove unnecessary character escapes in regular expressions

Regular expression special characters are context-sensitive. For example, special characters such as `.` are not considered special within square braces (`[]`).
This removes several of such instances that certain characters are escaped, but it is not strictly necessary within the context. This improves the readability of the expression.

See more information at [PHP.Watch: Writing better Regular Expressions in PHP](https://php.watch/articles/php-regex-readability#reduce-escape)

* Remove unnecessary break statement

* Remove unnecessary PHP close tags

* Remove redundant JSON_ERROR_NONE check

Remove unnecessary `json_last_error() == JSON_ERROR_NONE` where the decoded object is inspected already.

Closes GH-603.

show more ...

Remove duplicated !isset($var) (#570)

Add void return types

Add void return type to functions with missing or empty return statements.

Closes GH-535.

Migrate away from strftime

Swap uses of _SERVER[DOCUMENT_ROOT] for __DIR__

1/n - Update / and /include/ only.

Trim trailing whitespace

This patch cleans all redundant trailing whitespace across the
repository except for the icalendar files.

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
use

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.

show more ...

Kill off XHTML

Long live HTML5! =)

Added option to site_header to allow a custom span(for twitter bootstrap). Calendar page needed this. Other minor updates.

Stop abusing the current element of the page configuration, and instead add a
proper option to set body classes if appropriate.

Add calendar styling: this isn't perfect, but it's a tonne better than what we
had, which was nothing.

Add current config option (ignored in old-web), and FIXME placeholders for pages
not in any menu yet

Fix bug #52204 (htmlentities E_WARNINGs). Patch by Kalle.

entitify quotes and use utf8 (patch by Johannes)

allow a year ahead to be displayed

The CSS validator don't seem to like _ in a classname, so avoid
that, and also use a more appropriate cat# naming, as we refer
to categories here

Add category class to event links, so we will be able to color them
differently, and also drop the BC code for 12 data elements, as we
always have 13 now for all events