History log of /web-bugs/www/vote.php (Results 1 – 13 of 13)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
# c73a67a6 20-Jul-2024 Christoph M. Becker

Disable voting (fixes #112)


# 9d47b05f 22-May-2019 Peter Kokot

Convert all tabs to spaces


# 5cd2630a 24-Dec-2018 Peter Kokot

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classe

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classes and additionally provides retrieving of configuration parameters.
Service classes are used everywhere in the app - from accessing database
to uploading files. Configuration parameters include infrastructure
configuration (database credentials...) and application level
configuration (directories locations...).

Container is compatible with the PSR-11 container interface defined
so it is simple to quickly understand its usage. Advanced features
such as autowiring are not included in this phase.

show more ...


# 9a8dbe29 19-Dec-2018 Peter Kokot

Add Vote repository class


# ad8bc2d5 19-Dec-2018 Peter Kokot

Move bugdb queries to repository


# 14f8c07a 14-Dec-2018 Peter Kokot

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed in favor of the vanilla PDOStatement::fetch()
- ::fetchAll() override removed in favor of the vanilla
PDOStatement::fetchAll()
- ::fetchCol() removed since it is not used and is only a wrapper for
the PDOStatement::fetchColumn()
- PDO fetch_style synced accross the app. When no fetch style is passed
the default PDO::FETCH_ASSOC is used as set when connecting to db.
- Remove Database::escape() method
The custom ::escape() method is a wrapper around PDO::quote() which
additionally trims leading and trailing quotes from the string. All
this should ideally be done via prepared statements only, except where
we can and need to use PDO::quote() this step can be done on the given
string or variable at hand directly.
- Remove escapeSQL() function
The escapeSQL function is a wrapper around the PDO::quote() and is
using $dbh from the global scope which is not testable nor good practice
further on. Removed and refactored into only PDO::quote() usages on
required places.
- Remove ::fetchOne() method
The fetchOne() method is a simple wrapper around the PDOStatement::fetch()
method with very minor tweaks so the usage can be simplified even more.
The PDOStatement::fetch(\PDO::FETCH_NUM)[0] will always return either a
result from the database column or when row is empty a null.
- Probably this should be refactored to the database tables respected
repositories further on.
- Remove PDO wrapper
The app's current goal is to lean on a vanilla PDO wrapper only.
Current set of features also don't require additional functionality
and extending PDO to a wrapper or create a database abstraction layer
yet.

show more ...


# a06f85b0 24-Oct-2018 Peter Kokot

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
s

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
syntax on some places.

show more ...


# 3b0b87e2 23-Oct-2018 Peter Kokot

Fix #76961: bugs.php.net/vote.php throws a Server Error


# d04d379e 24-Jul-2017 Kalle Sommer Nielsen

Authenticate before each call to the header, this should probably be done in the header function anyway.

Fixes some navigational links only showing on certain pages


# 218cb889 03-Jan-2015 Jacob Bednarz

Make duplicate votes update previous votes

Instead of ignoring duplicate votes this allows the votes to be updated which
will allow users to update if they vote incorrectly initially.


# 90b07aee 30-Dec-2014 Jacob Bednarz

Prevent users from adding multiple votes on a single bug


# 1de55b7a 06-Aug-2014 Sobak

Exit script execution directly in redirect()


Revision tags: BEFORE_NEW_BUG_TRACKER
# e8ef23cd 03-Mar-2010 Jani Taskinen

- Rename to avoid unnecessary symlink