Convert all tabs to spaces

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classe

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classes and additionally provides retrieving of configuration parameters.
Service classes are used everywhere in the app - from accessing database
to uploading files. Configuration parameters include infrastructure
configuration (database credentials...) and application level
configuration (directories locations...).

Container is compatible with the PSR-11 container interface defined
so it is simple to quickly understand its usage. Advanced features
such as autowiring are not included in this phase.

show more ...

Remove display_bug_success() function

The display_bug_success() is a simple wrapper around the echo and has
HTML embedded in it.

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed

Refactor PDO wrapper

Some considerations were raised on the mailing list that this PHP
application doesn't need a PDO wrapper at all.

Changes:
- ::fetchRow() method removed in favor of the vanilla PDOStatement::fetch()
- ::fetchAll() override removed in favor of the vanilla
PDOStatement::fetchAll()
- ::fetchCol() removed since it is not used and is only a wrapper for
the PDOStatement::fetchColumn()
- PDO fetch_style synced accross the app. When no fetch style is passed
the default PDO::FETCH_ASSOC is used as set when connecting to db.
- Remove Database::escape() method
The custom ::escape() method is a wrapper around PDO::quote() which
additionally trims leading and trailing quotes from the string. All
this should ideally be done via prepared statements only, except where
we can and need to use PDO::quote() this step can be done on the given
string or variable at hand directly.
- Remove escapeSQL() function
The escapeSQL function is a wrapper around the PDO::quote() and is
using $dbh from the global scope which is not testable nor good practice
further on. Removed and refactored into only PDO::quote() usages on
required places.
- Remove ::fetchOne() method
The fetchOne() method is a simple wrapper around the PDOStatement::fetch()
method with very minor tweaks so the usage can be simplified even more.
The PDOStatement::fetch(\PDO::FETCH_NUM)[0] will always return either a
result from the database column or when row is empty a null.
- Probably this should be refactored to the database tables respected
repositories further on.
- Remove PDO wrapper
The app's current goal is to lean on a vanilla PDO wrapper only.
Current set of features also don't require additional functionality
and extending PDO to a wrapper or create a database abstraction layer
yet.

show more ...

Add dual PSR-4 compatible classes autoloader

This patch is a workaround until Composer installation step can be used
in production bugs.php.net. Once Composer can be added to the deploym

Add dual PSR-4 compatible classes autoloader

This patch is a workaround until Composer installation step can be used
in production bugs.php.net. Once Composer can be added to the deployment
step together with rsync this can be simplified and only Composer's
autoload.php will be used.

show more ...

Refactor numerical Captcha package into class

The Text_CAPTCHA_Numeral can be integrated in the project source code
instead of using a separate unmaintained dependency.

This pat

Refactor numerical Captcha package into class

The Text_CAPTCHA_Numeral can be integrated in the project source code
instead of using a separate unmaintained dependency.

This patch also adds a simple unit test.

show more ...

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
s

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
syntax on some places.

show more ...

Replace PEAR MDB2 constants with PDO constants

The changed constants are more understandable using PDO constants
nor are the dedicated definition needed anymore.

Trim trailing whitespace

Do not include bug report email address in password recovery.

Authenticate before each call to the header, this should probably be done in the header function anyway.

Fixes some navigational links only showing on certain pages

Remove XHTML

- Rename function that generates random passwd

- Change the hashing algo

- Changed password reminder
- The password now is stored as SHA-1
- New password is generated when requesting a password

Removed exit() usage that does not seem to make sense. Probably fixes PHP bug #52119

captcha answer can be 0, so changing empty to isset (thanks Yawk)

- Use bugs_mail() to avoid accidental emails in dev mode

Fixed captcha logic to fail without sessions; logged in users need not apply

- Prevent accidental and robots from sending people their passwords

- Rename to avoid unnecessary symlink