Autotools: Sync indentation style in build system files (#14725)

Wrap FPM checks in AC_CACHE_CHECK and fix CS (#14681)

- This simplifies over-quoted arguments to AC_COMPILE_IFELSE
- Indentation and other CS fixes
- php_cv_* cache variables
- A

Wrap FPM checks in AC_CACHE_CHECK and fix CS (#14681)

- This simplifies over-quoted arguments to AC_COMPILE_IFELSE
- Indentation and other CS fixes
- php_cv_* cache variables
- AC_DEFINE help texts syncs to make it more clear
- Fix -Wunused-but-set-variable warnings

show more ...

Rename AC_FPM_* M4 macros to PHP_FPM_* (#14670)

This syncs the FPM SAPI M4 macro names with the current naming
conventions prefixed with PHP_.

Wrap clock_get_time check in AC_CACHE_CHECK (#14434)

The php_cv_func_clock_get_time cache variable enables cross-compiling
edge cases to manually override the AC_RUN_IFELSE check.

Reduce unused variable warnings in config.log (#14264)

This reduces -Wunused-variable and -Wunused-but-set-variable warnings
generated in the Autoconf's config.log to comply with possibl

Reduce unused variable warnings in config.log (#14264)

This reduces -Wunused-variable and -Wunused-but-set-variable warnings
generated in the Autoconf's config.log to comply with possible stricter
default compiler configuration on the system to avoid having false
results.

show more ...

Use AC_SUBST instead of PHP_SUBST_OLD where possible (#13993)

The PHP_SUBST_OLD adds variables to generated Makefile and creates
output shell variables to replace the @variable_name@ pla

Use AC_SUBST instead of PHP_SUBST_OLD where possible (#13993)

The PHP_SUBST_OLD adds variables to generated Makefile and creates
output shell variables to replace the @variable_name@ placeholders in
templates. These changed variables are not used in the generated
Makefile so the AC_SUBST is sufficient.

- ext/odbc
- sapi/embed
- sapi/fpm
- only substituted in scripts/php-config.in:
- PHP_INSTALLED_SAPIS
- SAPI_LIBNAME_SHARED
- SAPI_LIBNAME_STATIC

show more ...

Fix GH-13727: macro generating invalid call test prototypes fixes.

autoconf/libtool generating code to test features missed `void` for
C calls prototypes w/o arguments.
Note that spe

Fix GH-13727: macro generating invalid call test prototypes fixes.

autoconf/libtool generating code to test features missed `void` for
C calls prototypes w/o arguments.
Note that specific changes related to libtool have to be upstreamed.

Co-authored-by: Peter Kokot <petk@php.net>

close GH-13732

show more ...

Find SELinux library with pkgconf (#13645)

The SELinux library has had pkg-config/pkgconf integration since ~2009.
To ease this change, the check without pkgconf is executed in case the

Find SELinux library with pkgconf (#13645)

The SELinux library has had pkg-config/pkgconf integration since ~2009.
To ease this change, the check without pkgconf is executed in case the
libselinux.pc file is not found on the system.

A sanity check also covers cases where the library path is overriden:
/configure --enable-fpm --with-fpm-selinux \
SELINUX_CFLAGS=-I/path/to/libselinux \
SELINUX_LIBS="-L/path/to/libselinux -lselinux"

This also removes the redundant symbol HAVE_SELINUX_SELINUX_H since the
selinux/selinux.h header is considered a required part of the SELinux
library package.

show more ...

Find AppArmor library with pkgconf (#13644)

The AppArmor library has had pkg-config/pkgconf integration since its
early versions (2012), when it was integrated from the libaalogparse

Find AppArmor library with pkgconf (#13644)

The AppArmor library has had pkg-config/pkgconf integration since its
early versions (2012), when it was integrated from the libaalogparse
into the AppArmor project. To ease this change, the check without
pkgconf is executed in case the libapparmor.pc file is not found on the
system.

A sanity check also covers cases where the library path is overriden:
/configure --enable-fpm --with-fpm-apparmor \
APPARMOR_CFLAGS=-I/path/to/libapparmor \
APPARMOR_LIBS="-L/path/to/libapparmor -lapparmor"

This also removes the redundant symbol HAVE_SYS_APPARMOR_H since the
sys/apparmor.h header is considered a required part of the AppArmor
library package.

show more ...

Simplify FPM ACL check (#13604)

Instead of running the user/group permissions check (unknown when
cross-compiling), check with linking (AC_LINK_IFELSE) can be sufficient
to test if A

Simplify FPM ACL check (#13604)

Instead of running the user/group permissions check (unknown when
cross-compiling), check with linking (AC_LINK_IFELSE) can be sufficient
to test if ACL_USER and ACL_GROUP are available (missing on macOS). The
AC_SEARCH_LIBS is used to test the ACL availability in c or acl library.

show more ...

Refactor systemd library check for FPM (#13595)

This removes the unused HAVE_SYSTEMD_SD_DAEMON_H symbol defined by the
Autoconf AC_CHECK_HEADERS macro.

The systemd/sd-daemon.h s

Refactor systemd library check for FPM (#13595)

This removes the unused HAVE_SYSTEMD_SD_DAEMON_H symbol defined by the
Autoconf AC_CHECK_HEADERS macro.

The systemd/sd-daemon.h sanity check now also works when systemd library
is overriden by pkgconf variables for custom or development places:

./configure --enable-fpm --with-fpm-systemd \
SYSTEMD_CFLAGS=-I/path/to/systemd/src \
SYSTEMD_LIBS="-L/path/to/systemd/build -lsystemd"

show more ...

Simplify port_create Autoconf check (#13529)

Similar simplification as e72f0c887bad4070a55529bf6e5cd1930b7ee8cb.

Sync logical operators in shell scripting code (#13560)

This updates the obsolescent `-a` and `-o` binary primaries to `&&` and
`||`.

https://pubs.opengroup.org/onlinepubs/96999

Sync logical operators in shell scripting code (#13560)

This updates the obsolescent `-a` and `-o` binary primaries to `&&` and
`||`.

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html

show more ...

Simplify clock_gettime Autoconf check (#13537)

The clock_gettime() is found in libc on modern systems, except on
Solaris <= 10 and possible similar systems, it is in the rt library.

Simplify clock_gettime Autoconf check (#13537)

The clock_gettime() is found in libc on modern systems, except on
Solaris <= 10 and possible similar systems, it is in the rt library.

This checks if clock_gettime() exists in the libc, then it checks if rt
library has clock_gettime, prepends it to LIBS and defines the
HAVE_CLOCK_GETTIME symbol with the template from the AC_CHECK_FUNCS.

The ac_cv_func_clock_gettime is a cache variable set by AC_CHECK_FUNCS.

show more ...

Simplify times Autoconf check (#13464)

Similar simplification as e72f0c887bad4070a55529bf6e5cd1930b7ee8cb.

Remove nsl library check in sapi/fpm (#13478)

In sapi/fpm the inet_ntop is used instead of the deprecated inet_addr
and the required library, if needed, is linked from the configure.ac.

Remove HAVE_SYSCONF check (#13474)

The sysconf can be assumed to be present on current systems, when
checking for the _SC_CLK_TCK symbol.

Simplify setpflags Autoconf check (#13458)

Similar simplification as e72f0c887bad4070a55529bf6e5cd1930b7ee8cb.

Fix the SO_LISTENQLEN check in FPM (#13089)

This now defines the HAVE_LQ_SO_LISTENQ as the fallback check when all
previous have failed in case of FPM LQ. This seemed to be a typo in the

Fix the SO_LISTENQLEN check in FPM (#13089)

This now defines the HAVE_LQ_SO_LISTENQ as the fallback check when all
previous have failed in case of FPM LQ. This seemed to be a typo in the
build system.

show more ...

Align configure check message results together

Set libtool tag per command instead of global one

Global --tag=CC defined in configure.ac is not correct in all cases. For example
linking objects that were compiled from C++ sources nee

Set libtool tag per command instead of global one

Global --tag=CC defined in configure.ac is not correct in all cases. For example
linking objects that were compiled from C++ sources needs to be done with C++
compiler, however for link mode libtool will prefer compiler indicated with
--tag.

Fixes GH-12349

show more ...

Fix _GNU_SOURCE redefined warnings in config.log

_GNU_SOURCE is already defined when doing these checks and warnings are
emitted otherwise in the configuration step.

Remove duplicated socket check (#12839)

Check is already done in configure.ac.

Fix too many arguments in FPM ACL compile check (#12242)

The AC_COMPILE_IFELSE takes 3 arguments unlike AC_RUN_IFELSE which needs
the 4th argument for cross-compilation.

*/*.m4: update main() signatures.

The next generation of C compilers is going to enforce the C standard
more strictly:

https://wiki.gentoo.org/wiki/Modern_C_porting

O

*/*.m4: update main() signatures.

The next generation of C compilers is going to enforce the C standard
more strictly:

https://wiki.gentoo.org/wiki/Modern_C_porting

One warning that will soon become an error is -Wstrict-prototypes.
This is relatively easy to catch in most code (it will fail to
compile), but inside of autoconf tests it can go unnoticed because
many feature-test compilations fail by design. For example,

$ export CFLAGS="$CFLAGS -Werror=strict-prototypes"
$ ./configure
...
checking if iconv supports errno... no
configure: error: iconv does not support errno

(this is on a system where iconv *does* support errno). If errno
support were optional, that test would have "silently" disabled
it. The underlying issue here, from config.log, is

conftest.c:211:5: error: function declaration isn't a prototype
[-Werror=strict-prototypes]
211 | int main() {

This commit goes through all of our autoconf tests, replacing main()
with main(void). Up to equivalent types and variable renamings, that's
one of the two valid signatures, and satisfies the compiler (gcc-12 in
this case).

Fixes GH-10751

show more ...