History log of /php-src/ext/standard/tests/strings/wordwrap_memory_limit_32bit.phpt (Results 1 – 2 of 2)
Revision Date Author Comments
# 27dd393b 04-Jul-2024 Michael Orlitzky

ext/standard/tests: strings/wordwrap_memory_limit_32bit.phpt has two outputs

It turns out that on a 32-bit system, this test can produce either the
"usual" expected output from the 64-bi

ext/standard/tests: strings/wordwrap_memory_limit_32bit.phpt has two outputs

It turns out that on a 32-bit system, this test can produce either the
"usual" expected output from the 64-bit test, OR the 32-bit-only
integer overflow message. We copy the dual expected outputs from
chunk_split_variation1_32bit.phpt to handle both cases.

This fixes an earlier commit that split the two tests based only on
the size of an int (32-bit versus 64-bit). The CI reveals that, at
least on a debug/zts build, the "64-bit" memory limit error (and not
the integer overflow error) is still produced.

show more ...


# 68a0efed 03-Jul-2024 Michael Orlitzky

ext/standard/tests: 32bit wordwrap tests aren't just for Windows

The test in strings/wordwrap_memory_limit.phpt has a counterpart in
strings/wordwrap_memory_limit_win32.phpt. The two are

ext/standard/tests: 32bit wordwrap tests aren't just for Windows

The test in strings/wordwrap_memory_limit.phpt has a counterpart in
strings/wordwrap_memory_limit_win32.phpt. The two are conditional on
both the OS name and the size of an int (32- versus 64-bits).

A Gentoo Linux user has however reported that the 64-bit test fails on
a 32-bit system, with precisely the error message that the "win32"
test is expecting. I don't have any 32-bit hardware to test myself,
but I think it's reasonable to conclude that the OS name is not an
essential part of the test: it's simply 32- versus 64-bit.

This commit drops the conditionals for the OS name. Now one test will
be run on 32-bit systems, and the other on 64-bit systems, regardless
of the OS name.

Bug: https://bugs.gentoo.org/935382

show more ...