History log of /php-src/ext/spl/spl_iterators.c (Results 1 – 25 of 511)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
# 54047c10 09-Jun-2024 Gina Peter Banyard

ext/spl: Remove some useless header includes and clarify usages


# a5cacba6 08-Jun-2024 Gina Peter Banyard

ext/spl: Remove spl_engine.h header (#14418)

And convert calls to spl_instantiate_arg_* to the new object_init_with_constructor() API


# fd2d8696 08-Jun-2024 Gina Peter Banyard

Clean-up some more headers (#14416)

Remove unused headers (such as php_ini.h for extensions that don't define INI settings)
Use more specific headers when possible


# 07a1921a 02-Jun-2024 Levi Morrison

refactor: use ZEND_PARSE_PARAMETERS_NONE() (#14442)

Prefer:

ZEND_PARSE_PARAMETERS_NONE();

Over:

if (zend_parse_parameters_none() == FAILURE) {

refactor: use ZEND_PARSE_PARAMETERS_NONE() (#14442)

Prefer:

ZEND_PARSE_PARAMETERS_NONE();

Over:

if (zend_parse_parameters_none() == FAILURE) {
RETURN_THROWS();
}

It's shorter, more modern, and they do the same thing. Technically,
ZEND_PARSE_PARAMETERS_NONE doesn't check that there's an exception,
but it generates one, so it's still cohesive.

show more ...


# c461b600 24-May-2024 Levi Morrison

refactor: change `zend_is_true` to return `bool` (#14301)

Previously this returned `int`. Many functions actually take advantage
of the fact this returns exactly 0 or 1. For instance,

refactor: change `zend_is_true` to return `bool` (#14301)

Previously this returned `int`. Many functions actually take advantage
of the fact this returns exactly 0 or 1. For instance,
`main/streams/xp_socket.c` does:

sockopts |= STREAM_SOCKOP_IPV6_V6ONLY_ENABLED * zend_is_true(tmpzval);

And `Zend/zend_compile.c` does:

child = &ast->child[2 - zend_is_true(zend_ast_get_zval(ast->child[0]))];

I changed a few places trivially from `int` to `bool`, but there are
still many places such as the object handlers which return `int` that
should eventually be `bool`.

show more ...


# 8e62e2b8 22-May-2024 Cristian Rodríguez

Mark multple functions as static (#13864)

* Mark many functions as static

Multiple functions are missing the static qualifier.

* remove unused struct sigactions

st

Mark multple functions as static (#13864)

* Mark many functions as static

Multiple functions are missing the static qualifier.

* remove unused struct sigactions

struct sigaction act, old_term, old_quit, old_int;
all unused.

* optimizer: minXOR and maxXOR are unused

show more ...


# b3a56bd5 21-May-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-14290: Member access within null pointer in extension spl

php_pcre_replace_impl() can fail and return NULL. We should take that
error condition into account. Because other failure

Fix GH-14290: Member access within null pointer in extension spl

php_pcre_replace_impl() can fail and return NULL. We should take that
error condition into account. Because other failures return false, we
return false here as well.

At first, I also thought there was a potential memory leak in the error
check of replacement_str, but found that the error condition can never
trigger, so replace that with an assertion.

Closes GH-14292.

show more ...


# 97267215 10-Jan-2024 David CARLIER

general signatures discrepencies fixes (#13122)


# 642e1114 11-Dec-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Minor pcre optimizations (#12923)

* Update signature of pcre API

This changes the variables that are bools to actually be bools instead
of ints, which allows some additional opt

Minor pcre optimizations (#12923)

* Update signature of pcre API

This changes the variables that are bools to actually be bools instead
of ints, which allows some additional optimization by the compiler (e.g.
removing some ternaries and move extensions).

It also gets rid of the use_flags argument because that's just the same
as flags == 0. This reduces the call frame.

* Use zend_string_release_ex where possible

* Remove duplicate symbols from strchr

* Avoid useless value conversions

* Use a raw HashTable* instead of a zval

* Move condition

* Make for loop cheaper by reusing a recently used value as start iteration index

* Remove useless condition

This can't be true if the second condition is true because it would
require the string to occupy the entire address space.

* Upgrading + remark

show more ...


# 4cfc8f6d 29-Oct-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Remove dead stores from ext/spl (#12550)


# e41598c7 06-Oct-2023 George Peter Banyard

ext/spl: Use new F ZPP modifier


# 5855bdcd 20-Apr-2023 Ilija Tovilo

Fix reference returned from CallbackFilterIterator::accept()

Fixes oss-fuzz #58181


# 9d5f2f13 20-Mar-2023 Ilija Tovilo

Use new ZSTR_INIT_LITERAL macro (#10879)


# 2b15061f 01-Mar-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Use zend_result in ext/spl where appropriate (#10734)

* Convert functions in spl_heap to return zend_result

* Convert functions in spl_iterators to return zend_result


# 90047253 26-Feb-2023 Marcos Marcolin <48370677+marcosmarcolin@users.noreply.github.com>

chore: standardize the visibility of functions. (#10708)

Co-authored-by: Marcos Marcolin <marcos@ixcsoft.com.br>


# 32d3cae1 22-Nov-2022 George Peter Banyard

Handle trampolines correctly in new FCC API + usages (#9877)


# 8d5d3fd0 27-Oct-2022 George Peter Banyard

Refactor SPL Callback filter to only use FCC


# 66661ae6 11-Oct-2022 George Peter Banyard

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zen

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zend_fcall_info_args(_ex) remains in PDO.

show more ...


# 1ea1b631 21-Oct-2022 George Peter Banyard

Use zend_call_function_with_return_value() in SPL iterators


# a01dd9fe 14-Sep-2022 Bob Weinand

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included i

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included in PHP 8.2 RC1. Given it's a massive ABI break, we decide to postpone the change to PHP 8.3.

show more ...


Revision tags: php-8.2.0RC1, php-8.1.10, php-8.0.23
# 94ee4f98 24-Aug-2022 Bob Weinand

Port all internally used classes to use default_object_handlers

Signed-off-by: Bob Weinand <bobwei9@hotmail.com>


Revision tags: php-8.0.23RC1, php-8.1.10RC1, php-8.2.0beta3
# b73f139c 02-Aug-2022 Máté Kocsis

Declare ext/spl constants in stubs (#9226)

Revision tags: php-8.2.0beta2, php-8.1.9, php-8.0.22, php-8.1.9RC1, php-8.2.0beta1
# 7ae7df5b 19-Jul-2022 Tim Düsterhus

RFC: Make the `iterator_*()` family accept all `iterable`s (#8819)

https://wiki.php.net/rfc/iterator_xyz_accept_array

Revision tags: php-8.0.22RC1, php-8.0.21, php-8.1.8, php-8.2.0alpha3, php-8.1.8RC1, php-8.2.0alpha2, php-8.0.21RC1, php-8.0.20, php-8.1.7, php-8.2.0alpha1, php-7.4.30, php-8.1.7RC1, php-8.0.20RC1, php-8.1.6, php-8.0.19
# e5d9859b 03-May-2022 Christoph M. Becker

Merge branch 'PHP-8.1'

* PHP-8.1:
Fix GH-8235: iterator_count() may run indefinitely


# e004e1a9 03-May-2022 Christoph M. Becker

Merge branch 'PHP-8.0' into PHP-8.1

* PHP-8.0:
Fix GH-8235: iterator_count() may run indefinitely


12345678910>>...21