History log of /php-src/ext/phar/tests/gh13833.phpt (Results 1 – 3 of 3)
Revision Date Author Comments
# 5ed5d37f 31-Mar-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Skip test on Windows because of different error output


# 47bb6c1b 31-Mar-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-13833: Applying zero offset to null pointer in zend_hash.c

MAPPHAR_FAIL will call the destructor of the manifest, mounted_dirs, and
virtual_dirs tables. When a new phar object is

Fix GH-13833: Applying zero offset to null pointer in zend_hash.c

MAPPHAR_FAIL will call the destructor of the manifest, mounted_dirs, and
virtual_dirs tables. When a new phar object is allocated using (p)ecalloc,
the bytes are zeroed, but the flag for an uninitialized table is
non-zero. So we have to manually set the flag in case that we have a
code path that can destroy the tables without first initializing them at
least once.

Closes GH-13847.

show more ...


# ed8ed714 30-Mar-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-13836: Renaming a file in a Phar to an already existing filename causes a NULL pointer dereference

If the destination already exists, then the `add` function on the
manifest will

Fix GH-13836: Renaming a file in a Phar to an already existing filename causes a NULL pointer dereference

If the destination already exists, then the `add` function on the
manifest will return NULL, resulting in a NULL entry and therefore a
NULL deref. As `copy()` (not `Phar::copy`) chooses to succeed and
overwrite the destination if it already exists, we should do the same.
Therefore the fix is as simple as changing `add` to `update`.

Closes GH-13840.

show more ...