Cater to raised requirement of fbclient 3.0+ for pdo_firebird (GH-15498)

We

* Document the fbclient 3.0+ version requirement

* Windows: check existence of Interface.h

Cater to raised requirement of fbclient 3.0+ for pdo_firebird (GH-15498)

We

* Document the fbclient 3.0+ version requirement

* Windows: check existence of Interface.h
Since we now require fbclient (3.0), we can drop support for the
Interbase gds32_ms.lib right away.

* POSIX: check for minimum required libfbclient version with fb_config

* POSIX: check for `fb_get_master_interface()`
The existence of `isc_detach_database` is implied by this.

* POSIX: remove detection of unsupported or even wrong libraries
libgds is for old Interbase which is incompatible with pdo_firebird for
may years, and libib_util is a utitity library, not a replacement for
libfbclient.

Co-authored-by: Peter Kokot <peterkokot@gmail.com>

show more ...

Autotools: Fix pdo_firebird shared build (#15371)

Follow-up of GH-15230:

- Redundant variables removed
- Redundant duplicate middle newlines removed
- PHP_CXX_COMPILE_STDCXX

Autotools: Fix pdo_firebird shared build (#15371)

Follow-up of GH-15230:

- Redundant variables removed
- Redundant duplicate middle newlines removed
- PHP_CXX_COMPILE_STDCXX macro arguments quoted
- When extension is built as shared the PHP_ADD_SOURCES works
differently, and PHP_ADD_SOURCES_X needs to be used so this can be
used:

./configure --with-pdo-firebird=shared

show more ...

Autotools: Sync CS in ext/pdo_firebird (#15372)

- Obsolete backticks replaced with the recommended $(...)
- AS_VAR_IF used

pdo_firebird: Formatting time zone types

As a follow-up to the commit which introduced support for Firebird 4.0+
data types[1], we add support for formats for types with time zones.

pdo_firebird: Formatting time zone types

As a follow-up to the commit which introduced support for Firebird 4.0+
data types[1], we add support for formats for types with time zones.

Since this uses the newer Firebird C++ API, pdo_firebird now requires a
C++ compiler to be built.

[1] <https://github.com/php/php-src/pull/14897>

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>

Closes GH-15230.

show more ...

Autotools: Remove PDO dependency related errors (#15347)

Follow-up of GH-15344 (687eb9125abf39b32512f2b001e3163f5fb5f45e)

This removes the customized error messages in PDO extension

Autotools: Remove PDO dependency related errors (#15347)

Follow-up of GH-15344 (687eb9125abf39b32512f2b001e3163f5fb5f45e)

This removes the customized error messages in PDO extensions when PDO is
not enabled (--disable-all or --disable-pdo) in favor of the default
error done by PHP_ADD_EXTENSION_DEP.

show more ...

Autotools: Sync CS in extensions (#15343)

- Redundant double quotes removed
- AS_* macros used
- Few nits adjusted here and there

Autotools: Quote AC_PATH_PROG arguments in ext/pdo_firebird

[skip ci]

Autotools: Replace AC_MSG_ERROR with AC_MSG_FAILURE (#15209)

This replaces the AC_MSG_ERROR with AC_MSG_FAILURE, where appropriate.

The AC_MSG_ERROR outputs given message and exits

Autotools: Replace AC_MSG_ERROR with AC_MSG_FAILURE (#15209)

This replaces the AC_MSG_ERROR with AC_MSG_FAILURE, where appropriate.

The AC_MSG_ERROR outputs given message and exits the configure step. The
AC_MSG_FAILURE does the same but also automatically outputs additional
message "See 'config.log' for more details." which might help directing
the user where to look further.

The AC_MSG_ERROR is used for errors where current test step isn't logged
in the config.log and wouldn't make sense, and AC_MSG_FAILURE is mostly
used in cases of library checks, compilation tests, headers checked with
AC_CHECK_HEADER* and similar tests that are also logged in the
config.log.

AC_MSG_ERROR([Sanity check failed.]) output:

```
configure: error: Sanity check failed.
```

AC_MSG_FAILURE([Sanity check failed.]) output:

```
configure: error: in '/path/to/php-src':
configure: error: Sanity check failed.
See 'config.log' for more details
```

show more ...

Autotools: Normalize and quote all PHP_NEW_EXTENSION arguments (#15144)

This adds Autoconf quote characters to all PHP_NEW_EXTENSION arguments
and syncs the CS across the php-src Autotoo

Autotools: Normalize and quote all PHP_NEW_EXTENSION arguments (#15144)

This adds Autoconf quote characters to all PHP_NEW_EXTENSION arguments
and syncs the CS across the php-src Autotools build system.

show more ...

Autotools: Quote PHP_CHECK_LIBRARY arguments (#15136)

This syncs the quotes across the PHP_CHECK_LIBRARY macro arguments.

Autotools: Quote PHP_ADD_LIB* arguments (#15112)

Following previous CS syncs, this quotes arguments in PHP_ADD_LIB* M4
macros:
- PHP_ADD_LIBRARY
- PHP_ADD_LIBRARY_WITH_PATH
-

Autotools: Quote PHP_ADD_LIB* arguments (#15112)

Following previous CS syncs, this quotes arguments in PHP_ADD_LIB* M4
macros:
- PHP_ADD_LIBRARY
- PHP_ADD_LIBRARY_WITH_PATH
- PHP_ADD_LIBPATH

show more ...

Autotools: Quote M4 arguments (#15045)

- AC_MSG_CHECKING
- AC_MSG_RESULT
- AC_MSG_WARN
- AC_MSG_ERROR
- AC_MSG_NOTICE

Autotools: Quote M4 arguments (#15033)

- PHP_ADD_INCLUDE
- PHP_EVAL_INCLINE
- PHP_EVAL_LIBLINE

Autotools: Quote PHP_SUBST arguments in extensions (#14748)

Simplify PDO include paths (#14444)

PDO include paths can be simplified and synced as done in other
extensions: either the project root directory or the phpincludedir (for
the system

Simplify PDO include paths (#14444)

PDO include paths can be simplified and synced as done in other
extensions: either the project root directory or the phpincludedir (for
the system installation). The 'ext' include is automatically appended
when doing phpize build. In php-src it is only present on Windows build.
The PHP_CHECK_PDO_INCLUDES is left intact working as before and checks
if PDO headers are found.

show more ...

Remove unsynced and unused HAVE_<extension> defines (#14233)

This syncs build system gaps of some extensions' definitions being
defined on Windows and some on *nix. These are not used an

Remove unsynced and unused HAVE_<extension> defines (#14233)

This syncs build system gaps of some extensions' definitions being
defined on Windows and some on *nix. These are not used anywhere and are
only defined in some build system and not the other:

* HAVE_INTL (was present only on Windows)
* HAVE_PDO_DBLIB (was present only on Autotools)
* HAVE_PDO_FIREBIRD (was present only on Autotools)
* HAVE_TOKENIZER (was present only on Windows)

show more ...

Add AS_HELP_STRING to *nix build configure options

The Autoconf's default AS_HELP_STRING macro can properly format help
strings [1] so watching out if columns are aligned manually is not

Add AS_HELP_STRING to *nix build configure options

The Autoconf's default AS_HELP_STRING macro can properly format help
strings [1] so watching out if columns are aligned manually is not
anymore.

[1] https://www.gnu.org/software/autoconf/manual/autoconf.html#Pretty-Help-Strings

show more ...

Trim trailing whitespaces in build files

Some editors utilizing .editorconfig automatically trim whitespaces. For
convenience this patch removes whitespaces in certain build files:
-

Trim trailing whitespaces in build files

Some editors utilizing .editorconfig automatically trim whitespaces. For
convenience this patch removes whitespaces in certain build files:
- ext/*/config*.m4
- configure.ac
- acinclude.m4

show more ...

Fixed bug #73512 Fails to find firebird headers

- use fb_config output instead of relying on hardoded path

Merge branch 'PHP-5.4' into PHP-5.5

* PHP-5.4:
Cleanup $ is not needed for git

Cleanup $ is not needed for git

Fix long-standing visual pain point: the misalignment of './configure help' text.
Whitespace changes and a couple of grammar fixes.

Cache the PDO include path

Cache the pdo include path

Revert attempt at supporting both autoconf 2.13 and
modern versions in the same build chain. There are
simply too many broken things in 2.13 to make it work.
Cache handling is broken as

Revert attempt at supporting both autoconf 2.13 and
modern versions in the same build chain. There are
simply too many broken things in 2.13 to make it work.
Cache handling is broken as well which is why I need
to revert the pdo_inc_path cache fix as well.

trunk is now 2.60+ only and I'll work on cleaning out
all the legacy cruft from there.

show more ...