Added scale to bc_compare argument (#14802)

In the original specification, the scale of bc_num was directly changed
and compared.

This becomes a problem when objects are support

Added scale to bc_compare argument (#14802)

In the original specification, the scale of bc_num was directly changed
and compared.

This becomes a problem when objects are supported, so we will modify it
to compare without changing bc_num.

show more ...

ext/bcmath: Use an enum for comparison result (#14374)

Improve logic of callers of bc_compare

ext/bcmath: Fixed bug (bcpowmod() with mod = -1 returns 1 when it must be 0)

Avoid unnecessary destruction in bc_mul()

Remove rscale in bc_raisemod

power is a copy of base and returns early if base->n_scale is non-zero. Since
scale is size_t, it is always greater than or equal to 0, so rscale is always

Remove rscale in bc_raisemod

power is a copy of base and returns early if base->n_scale is non-zero. Since
scale is size_t, it is always greater than or equal to 0, so rscale is always
the value of scale.

show more ...

BCmath extension code reformatting (#11896)

Re-formats the BCmath extension to have consistent formatting.

Mostly, it adds the spaces in calculations to have them more readable.

BCmath extension code reformatting (#11896)

Re-formats the BCmath extension to have consistent formatting.

Mostly, it adds the spaces in calculations to have them more readable.

Also:

- removes unused headers
- removes few variables which are used only once in the code

Co-authored-by: George Peter Banyard <girgias@php.net>

show more ...

Refactor BCMath bundledlib and extension (#10774)

* ext/bcmath: coding style: use indentation

And add braces to block statements, as the current code was pretty much unreadable with

Refactor BCMath bundledlib and extension (#10774)

* ext/bcmath: coding style: use indentation

And add braces to block statements, as the current code was pretty much unreadable with how inconsistent it was.

* ext/bcmath: Remove some useless header inclusions

* ext/bcmath: Use standard C99 bool type instead of char

* ext/bcmath: Include specific headers instead of config.h

* Restructure definitions to reduce header inclusions

* Use size_t as a more appropriate type

* Remove unused variable full_scale

* Refactor bc_raisemod() to get rid of Zend dependencies

This separates the concerns of throwing exceptions back into the PHP_FUNCTION instead of being the responsibility of the library

* Refactor bc_raise() to get rid of Zend dependencies

This separates the concerns of throwing exceptions back into the PHP_FUNCTION instead of being the responsibility of the library

* Refactor bc_divmod() and bc_modulo() to return bool

Return false on division by 0 attempt instead of -1 and true on success instead of 0

* Refactor bc_divide() to return bool

Return false on division by 0 attempt instead of -1 and true on success instead of 0

show more ...

Promote some warnings in BCMath to Errors

Also do a bit of refactoring at the same time.

Closes GH-6105

make bcpowmod stricter by not returning false, instead throw exception

Closes GH-5747

Make error messages more consistent by fixing capitalization

Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.

Fix leak in bcpowmod

[ci skip] Rename libbcmath license file to LICENSE

- More common filename accross the PHP repository
- Additionally, this patch replaces some legacy form feed (FF or ^L)
characters

[ci skip] Rename libbcmath license file to LICENSE

- More common filename accross the PHP repository
- Additionally, this patch replaces some legacy form feed (FF or ^L)
characters (for printers) to LF (\n) newline character.

show more ...

Remove HAVE_ASSERT_H

The `<assert.h>` header file is part of the standard C89 headers [1] and
on older systems there needed to be also a manual check if header is
present.

S

Remove HAVE_ASSERT_H

The `<assert.h>` header file is part of the standard C89 headers [1] and
on older systems there needed to be also a manual check if header is
present.

Since PHP requires at least C89 manual check and the `HAVE_ASSERT_H`
symbol defined by Autoconf in configure.ac can be both removed [2].

This patch also removes unused <assert.h> includes where c files don't
use the `assert()` macro.

Refs:
[1] https://port70.net/~nsz/c/c89/c89-draft.html#4.2
[2] https://git.savannah.gnu.org/cgit/autoconf.git/tree/lib/autoconf/headers.m4

show more ...

Fixed bug #75169 (BCMath errors/warnings bypass error handling)

Instead of writing warning messages to `stderr`, we employ PHP's error
handling to raise `E_WARNING` even for the single c

Fixed bug #75169 (BCMath errors/warnings bypass error handling)

Instead of writing warning messages to `stderr`, we employ PHP's error
handling to raise `E_WARNING` even for the single case where
`bc_rt_error()` has been called, since that did not actually error out.
We choose to call `php_error_docref()` directly in libbcmath, since
there is no upstream, and since other PHP core functionality is already
used in our bundled libbcmath. Accordingly, we remove `rt.c` so it will
not be accidentally used in the future.

Besides adapting a few existing tests, we add new tests so that the
warnings are tested at least once. We also get rid of the Windows
specific tests, since the warning behavior is now supposed to be
platform-agnostic.

show more ...

Optimize truncation to zero scale in bc_raisemod()

There's no need to use a division by one to truncate to zero scale;
instead we introduce and use `_bc_truncate()`, what is more efficie

Optimize truncation to zero scale in bc_raisemod()

There's no need to use a division by one to truncate to zero scale;
instead we introduce and use `_bc_truncate()`, what is more efficient.

show more ...

Fixed bug #75178 (bcpowmod() misbehaves for non-integer base or modulus)

Since `bcpowmod()` does not support non-integral operands, we have to
truncate these in addition to emitting a re

Fixed bug #75178 (bcpowmod() misbehaves for non-integer base or modulus)

Since `bcpowmod()` does not support non-integral operands, we have to
truncate these in addition to emitting a respective warning. We also
have to work with the truncated values in the following.

We recognize that the division by one to enforce the truncation is
actually overkill, but we stick with it for now, and shall tackle the
issue for PHP 7.3.

show more ...

Fixed bug #54598 (bcpowmod() may return 1 if modulus is 1)

`x mod 1` is always zero; we have to take the scale into account,
though.

trailing whitespace removal

first shot remove TSRMLS_* things

fix leak

Made bcmath extension thread safe.
@Made bcmath extension thread safe. (Sander)

- Revert previous patch

- Intermediate commit which works on making bcmath thread-safe.

At long last, import the bcmath library, by Phil Nelson