Do not remove -O0 in the middle of a flag

Fixes GH-15826
Closes GH-15828

Co-authored-by: Peter Kokot <petk@php.net>

Autotools: Obsolete PHP_TEST_BUILD, PHP_BUILD_THREAD_SAFE, and PHP_DEF_HAVE (#15802)

The PHP_BUILD_THREAD_SAFE macro is a simple wrapper around setting the
enable_zts variable and can't

Autotools: Obsolete PHP_TEST_BUILD, PHP_BUILD_THREAD_SAFE, and PHP_DEF_HAVE (#15802)

The PHP_BUILD_THREAD_SAFE macro is a simple wrapper around setting the
enable_zts variable and can't be used in PHP extensions realistically.

The PHP_TEST_BUILD macro might produce warnings on certain compiler
configurations and default AC_* macros like AC_LINK_IFELSE,
AC_CHECK_LIB, or AC_CHECK_FUNC are better suited for such checks. Also,
a quick browse through the open-source PHP extensions doesn't find
usages of this macro except in imap extension where patch is was already
sent:
https://github.com/php/pecl-mail-imap/pull/11

PHP_DEF_HAVE is a wrapper around AC_DEFINE and using AC_DEFINE_UNQUOTED
and AS_TR_CPP are better suited for this task where also help text can
be passed. Usages in the open source PHP extensions have been checked and
patches sent where found.

show more ...

Autotools: Check Apache version with apxs and HTTPD_VERSION variable (#15476)

The apxs -q HTTPD_VERSION variable is available since Apache 2.4.17.
This change obsoletes the PHP_AP_EXTRAC

Autotools: Check Apache version with apxs and HTTPD_VERSION variable (#15476)

The apxs -q HTTPD_VERSION variable is available since Apache 2.4.17.
This change obsoletes the PHP_AP_EXTRACT_VERSION macro and checks the
version in the config.m4 file directly. Version is checked against the
dotted format instead of the version number.

show more ...

Autotools: Enable adding a list of paths in PHP_ADD_INCLUDE (#15777)

This enables adding multiple include paths. For example:

PHP_ADD_INCLUDE([
$abs_srcdir
$

Autotools: Enable adding a list of paths in PHP_ADD_INCLUDE (#15777)

This enables adding multiple include paths. For example:

PHP_ADD_INCLUDE([
$abs_srcdir
$abs_builddir
$abs_srcdir/main
$abs_builddir/main
], [1])

The 2nd argument "prepend" is now validated at Autoconf compile time
instead of the configure time.

show more ...

Autotools: Sync CS for PHP_PWRITE_TEST and PHP_PREAD_TEST (#15774)

- AS_* macros used
- Arguments quoted
- Cache variable ac_cv_pread renamed to php_cv_func_pread
- Cache variabl

Autotools: Sync CS for PHP_PWRITE_TEST and PHP_PREAD_TEST (#15774)

- AS_* macros used
- Arguments quoted
- Cache variable ac_cv_pread renamed to php_cv_func_pread
- Cache variables ac_cv_pwrite renamed to php_cv_func_pwrite

show more ...

Autotools: Sync CS in PHP_PROG_AWK (#15772)

- AS_* macros used

Autotools: Sync CS in php.m4 (#15771)

- AS_* macros used

Autotools: Replace uname with host_alias for finding Solaris (#15770)

This wraps checks in AC_CACHE_CHECK and replaces the "uname -sr" command
with simpler $host_alias as it is already s

Autotools: Replace uname with host_alias for finding Solaris (#15770)

This wraps checks in AC_CACHE_CHECK and replaces the "uname -sr" command
with simpler $host_alias as it is already set by the config.guess script
properly.

show more ...

Autotools: Sync CS for PHP_RUNPATH_SWITCH (#15768)

- AS_VAR_IF macros used
- AC_CACHE_VAL and AC_MSG_CHECKING replaced with AC_CACHE_CHECK
- arguments quoted

Autotools: Sync CS in PHP_EVAL_LIBLINE (#15737)

- AS_* macros used
- arguments quoted
- redundant quotation of variable-variable simplified from [$]$2 to $$2
(see Autoconf docu

Autotools: Sync CS in PHP_EVAL_LIBLINE (#15737)

- AS_* macros used
- arguments quoted
- redundant quotation of variable-variable simplified from [$]$2 to $$2
(see Autoconf documentation)

show more ...

Autotools: Normalize flags arguments (#15671)

This is a follow up of 7edb9a07d750a92ceea9371588f10ff2f05df40f that
provides passing compilation options to PHP_NEW_EXTENSION,
PHP_ADD_

Autotools: Normalize flags arguments (#15671)

This is a follow up of 7edb9a07d750a92ceea9371588f10ff2f05df40f that
provides passing compilation options to PHP_NEW_EXTENSION,
PHP_ADD_SOURCES, PHP_ADD_SOURCES_X, and PHP_SELECT_SAPI as a
blank-or-newline-separated argument.

show more ...

Autotools: Replace backticks with $(...) in php.m4 (#15642)

This is a follow-up of GH-15639

Autotools: Use SED variable for sed command (#15641)

This syncs sed usages across the build system as SED variable is set to
a suitable sed program on the system.

Autotools: Remove redundant double quotes (#15634)

Autotools: Normalize 2nd arg in PHP_ADD_SOURCES_X (#15088)

By using `m4_normalize(m4_expand([...]))`, the arguments can be split
into newlines without using backslashes and it makes work

Autotools: Normalize 2nd arg in PHP_ADD_SOURCES_X (#15088)

By using `m4_normalize(m4_expand([...]))`, the arguments can be split
into newlines without using backslashes and it makes working with lists
of files a bit easier.

Tested:
- variables inside the argument
- M4 macro expansions
- dnl comments
- any sequence of newlines, backslash-then-newline, multiple spaces,
tabs...
- quoted/unquoted arguments

This now works for PHP_NEW_EXTENSION, PHP_ADD_SOURCES, PHP_ADD_SOURCES_X,
and PHP_SELECT_SAPI. The m4_normalize() usage is left in the php-src
config.m4 files following the 0a0d2d063176d2fd8948be91c74c854ce630b91c
for PECL extensions until phpize will be available on all supported
versions (minimum PHP 8.4).

show more ...

Autotools: Normalize PHP_ADD_BUILD_DIR 1st argument (#15612)

The m4_normalize(m4_expand([$1])) expands the given argument if it
contains M4 macros, and then trims the items together into

Autotools: Normalize PHP_ADD_BUILD_DIR 1st argument (#15612)

The m4_normalize(m4_expand([$1])) expands the given argument if it
contains M4 macros, and then trims the items together into a space
separated string in an intuitive way.

show more ...

Autotools: Normalize PHP_INSTALL_HEADERS arguments (#15620)

The m4_normalize(m4_expand([...])) simplifies working with a list of
header files. The m4_normalize() is at this point still u

Autotools: Normalize PHP_INSTALL_HEADERS arguments (#15620)

The m4_normalize(m4_expand([...])) simplifies working with a list of
header files. The m4_normalize() is at this point still used in the
php-src config.m4 files because of copy/paste probability to community
extensions where the arguments still need to be done in the old style to
support phpize in PHP-8.3 and earlier. For example:

PHP_INSTALL_HEADERS([ext/dom], m4_normalize([
dom_ce.h
namespace_compat.h
xml_common.h
xpath_callbacks.h
]))

When PHP 8.4 will be the minimum supported PHP version, the headers can
be installed without using m4_normalize() in PECL extensions. For
example:

PHP_INSTALL_HEADERS([ext/dom], [
dom_ce.h
namespace_compat.h
xml_common.h
xpath_callbacks.h
])

show more ...

Fix GH-15534: Bump minimum libxml2 version to 2.9.4 (#15536)

The xmlDictPtr was moved before the includes in libxml2 2.9.4 so the
<libxml/dict.h> can be included directly but for earlier

Fix GH-15534: Bump minimum libxml2 version to 2.9.4 (#15536)

The xmlDictPtr was moved before the includes in libxml2 2.9.4 so the
<libxml/dict.h> can be included directly but for earlier versions the
<libxml/tree.h> needs to be included before. Since PHP requires libxml2
2.9.0 or later and this also fixes builds on Solaris 10.

As earlier 2.9.0-2.9.3 libxml2 versions also include several security
issues, this change bumps the required minimum libxml2 version to 2.9.4

On Windows, a check for minimum libxml2 version is also added.

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>

show more ...

Autotools: Check re2c version with AS_VERSION_COMPARE (#15465)

This simplifies the version check a bit.

Autotools: Add min-version argument to PHP_PROG_PHP macro (#15477)

This makes a bit simpler to use this macro by optionally passing the
required minimum PHP version. If version is not pa

Autotools: Add min-version argument to PHP_PROG_PHP macro (#15477)

This makes a bit simpler to use this macro by optionally passing the
required minimum PHP version. If version is not passed it falls back
to 7.4 as before. Minimum version also added to configure.ac.

show more ...

Autotools: Move abs_srcdir and abs_builddir to init macro (#15537)

This syncs the abs_srcdir and abs_builddir variables assignments between
the php-src build and phpize. The `&&` was pic

Autotools: Move abs_srcdir and abs_builddir to init macro (#15537)

This syncs the abs_srcdir and abs_builddir variables assignments between
the php-src build and phpize. The `&&` was picked over `;` as it is more
rigorous - the pwd command would fail if cd fails for some reason.

show more ...

Autotools: Move auto_cflags marker to PHP_INIT_BUILD_SYSTEM (#15487)

The "hacky" auto_cflags variable is otherwise set only for the Oracle
Developer Studio compiler (which is at this poi

Autotools: Move auto_cflags marker to PHP_INIT_BUILD_SYSTEM (#15487)

The "hacky" auto_cflags variable is otherwise set only for the Oracle
Developer Studio compiler (which is at this point also non-usable) and
perhaps might be removed in the future but this is for now moved to the
PHP_INIT_BUILD_SYSTEM for consistent settings between the php-src build
and phpize.

The PHP_INIT_BUILD_SYSTEM is now also called sooner in phpize to match
the php-src build.

show more ...

Autotools: Move AWK finder to PHP_INIT_BUILD_SYSTEM (#15478)

This calls the PHP_PROG_AWK from a single place for php-src build and
phpize.

Autotools: Add note about PHP_ADD_EXTENSION_DEP usage

Until the AWK regex is implemented better, this macro must be called on
its own line with unquoted arguments.

[skip ci]

Autotools: Wrap long texts with m4_text_wrap (#15368)

The m4_text_wrap macro wraps the text into a single space separated
string which is wrapped to not exceed the line lenght of 79 char

Autotools: Wrap long texts with m4_text_wrap (#15368)

The m4_text_wrap macro wraps the text into a single space separated
string which is wrapped to not exceed the line lenght of 79 characters
by default.

show more ...