History log of /PHP-8.4/ext/xml/xml.c (Results 1 – 25 of 367)
Revision (<<< Hide revision tags) (Show revision tags >>>) Date Author Comments
# 6c82ca21 13-Sep-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-15868: Assertion failure in xml_parse_into_struct after exception

Upon unwinding from an exception, the parser state is not stable, we
should not continue updating the values if a

Fix GH-15868: Assertion failure in xml_parse_into_struct after exception

Upon unwinding from an exception, the parser state is not stable, we
should not continue updating the values if an exception was thrown.

Closes GH-15879.

show more ...


# ac8db365 13-Sep-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-15868: Assertion failure in xml_parse_into_struct after exception

Upon unwinding from an exception, the parser state is not stable, we
should not continue updating the values if a

Fix GH-15868: Assertion failure in xml_parse_into_struct after exception

Upon unwinding from an exception, the parser state is not stable, we
should not continue updating the values if an exception was thrown.

Closes GH-15879.

show more ...


# 25b46965 08-Aug-2024 Gina Peter Banyard

ext/xml: Deprecate xml_set_object() and passing non-callable strings as handlers (#15293)


# 776939c3 06-Jul-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Avoid function pointer cast to preserve ability to do CFI


# ff3e7679 06-Jul-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Avoid pointless cast to prevent implementation-defined conversion warning


# 292e936c 06-Jul-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Handle invalid values better in PHP_XML_OPTION_SKIP_TAGSTART


# 19358d63 06-Jul-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Stop using reserved names


# 335d6f02 06-Jul-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix grammar mistake in comment in xml.c


# be2d9fd8 06-Jul-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Remove unused include from xml.c


# 8c8322f6 06-Jul-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

ext/xml: Use zend_hash_find_ptr_lc() to avoid allocation in some cases (#14840)


# 85705eda 03-Jul-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix compilation on libxml2 2.13


# 11accb5c 25-Jun-2024 Arnaud Le Blanc

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Before, out of tree builds would preferably include files from the src dir, as
the include path was defined as follows (ignoring includes from ext/ and sapi/) :

-I$(top_builddir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/main
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM
-I$(top_builddir)/

As a result, an out of tree build would include configure artifacts such as
`main/php_config.h` from the src dir.

After this change, the include path is defined as follows:

-I$(top_builddir)/main
-I$(top_builddir)
-I$(top_srcdir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM

* Fix extension include path for out of tree builds

* Include config.h with the brackets form

`#include "config.h"` searches in the directory containing the including-file
before any other include path. This can include the wrong config.h when building
out of tree and a config.h exists in the source tree.

Using `#include <config.h>` uses exclusively the include path, and gives
priority to the build dir.

show more ...


# fd2d8696 08-Jun-2024 Gina Peter Banyard

Clean-up some more headers (#14416)

Remove unused headers (such as php_ini.h for extensions that don't define INI settings)
Use more specific headers when possible


# 5b357400 02-Jun-2024 Peter Kokot

Sync #if/ifdef/defined for LIBXML_EXPAT_COMPAT (#14435)

This one can be undefined or defined to value 1.


# 8e62e2b8 22-May-2024 Cristian Rodríguez

Mark multple functions as static (#13864)

* Mark many functions as static

Multiple functions are missing the static qualifier.

* remove unused struct sigactions

st

Mark multple functions as static (#13864)

* Mark many functions as static

Multiple functions are missing the static qualifier.

* remove unused struct sigactions

struct sigaction act, old_term, old_quit, old_int;
all unused.

* optimizer: minXOR and maxXOR are unused

show more ...


# 427c2441 04-May-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-14124: Segmentation fault on unknown address 0x0001ffff8041 with XML extension under certain memory limit (#14126)

The ltags were not initialized, so when an OOM happens before the ne

Fix GH-14124: Segmentation fault on unknown address 0x0001ffff8041 with XML extension under certain memory limit (#14126)

The ltags were not initialized, so when an OOM happens before the new value is written, uninitialized data is used.

show more ...


# 234b3cb2 04-May-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-14124: Segmentation fault on unknown address 0x0001ffff8041 with XML extension under certain memory limit (#14126)

The ltags were not initialized, so when an OOM happens before the ne

Fix GH-14124: Segmentation fault on unknown address 0x0001ffff8041 with XML extension under certain memory limit (#14126)

The ltags were not initialized, so when an OOM happens before the new value is written, uninitialized data is used.

show more ...


# 6b73fcc2 22-Oct-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Convert ext/xml fields from int to bool (#12497)


# 98b08c52 22-Oct-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Implement request #68325: parse huge option for xml_parser_create (#12256)


# 0e5d6544 20-Oct-2023 George Peter Banyard

ext/xml: Refactor extension to use FCC instead of zvals for handlers (#12340)

To get proper errors and sensible behaviour, as the current behaviour is somewhat insane and part of it should b

ext/xml: Refactor extension to use FCC instead of zvals for handlers (#12340)

To get proper errors and sensible behaviour, as the current behaviour is somewhat insane and part of it should be axed ASAP.

The behaviour is mostly intact with some minor BC breaks which are mentioned in UPGRADING.

Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>

show more ...


# 30f26b58 20-Sep-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix memory leak when calling xml_parse_into_struct() twice

Closes GH-12254.


# 6d3433e6 10-Jul-2023 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Remove always-true condition from xml_utf8_decode()

decoder is already checked above


# d5ad7510 08-Jun-2023 George Peter Banyard

More usage of known zend_str instead of C string (#11381)


# 81e59c64 23-Feb-2023 George Peter Banyard

Improve handling of XML options

Mark boolean options as such
Warn on invalid types
Stubs info

Closes GH-10675


# 6a5b3f0f 23-Feb-2023 George Peter Banyard

The userland constants do not start with PHP_


12345678910>>...15