Autotools: Remove redundant double quotes (#15634)

Autotools: Sync CS in ext/standard (#15560)

- Overquoted arguments reduced
- Added missing quotes in algorithms checks
- Synced indentations for algorithms checks

Autotools: Sync CS in extensions (#15343)

- Redundant double quotes removed
- AS_* macros used
- Few nits adjusted here and there

ext/standard: enabling feature detection auxiliary vector on OpenBSD.

close gh-15175

Autotools: Check for cross_compiling=yes (#15238)

The cross_compiling variable can initially be "yes", "no", or
"maybe" (when only --host option is added). Autoconf otherwise after
A

Autotools: Check for cross_compiling=yes (#15238)

The cross_compiling variable can initially be "yes", "no", or
"maybe" (when only --host option is added). Autoconf otherwise after
AC_PROG_CC resets it to "no" in such case but to be sure, this
checks for value "yes" instead. The HAVE_FNMATCH template can be also
set after the AC_DEFINE as autoheader scans the templates overall the
source code.

show more ...

Autotools: Replace AC_MSG_ERROR with AC_MSG_FAILURE (#15209)

This replaces the AC_MSG_ERROR with AC_MSG_FAILURE, where appropriate.

The AC_MSG_ERROR outputs given message and exits

Autotools: Replace AC_MSG_ERROR with AC_MSG_FAILURE (#15209)

This replaces the AC_MSG_ERROR with AC_MSG_FAILURE, where appropriate.

The AC_MSG_ERROR outputs given message and exits the configure step. The
AC_MSG_FAILURE does the same but also automatically outputs additional
message "See 'config.log' for more details." which might help directing
the user where to look further.

The AC_MSG_ERROR is used for errors where current test step isn't logged
in the config.log and wouldn't make sense, and AC_MSG_FAILURE is mostly
used in cases of library checks, compilation tests, headers checked with
AC_CHECK_HEADER* and similar tests that are also logged in the
config.log.

AC_MSG_ERROR([Sanity check failed.]) output:

```
configure: error: Sanity check failed.
```

AC_MSG_FAILURE([Sanity check failed.]) output:

```
configure: error: in '/path/to/php-src':
configure: error: Sanity check failed.
See 'config.log' for more details
```

show more ...

Sync AC_DEFINE help texts (#15207)

Autotools: Sync shared argument CS (#15141)

The 3rd argument of the PHP_NEW_EXTENSION can be "shared" or "yes" to
mark the extension as shared, or anything else to mark that extension as

Autotools: Sync shared argument CS (#15141)

The 3rd argument of the PHP_NEW_EXTENSION can be "shared" or "yes" to
mark the extension as shared, or anything else to mark that extension as
not shared. This syncs the argument values across the build system to be
"no" as in other always-enabled extensions.

show more ...

Autotools: Normalize and quote all PHP_NEW_EXTENSION arguments (#15144)

This adds Autoconf quote characters to all PHP_NEW_EXTENSION arguments
and syncs the CS across the php-src Autotoo

Autotools: Normalize and quote all PHP_NEW_EXTENSION arguments (#15144)

This adds Autoconf quote characters to all PHP_NEW_EXTENSION arguments
and syncs the CS across the php-src Autotools build system.

show more ...

Autotools: Fix ext/standard sources (#15131)

This appends source files to the PHP_NEW_EXTENSION call and adds the
possible compilation flag -DZEND_ENABLE_STATIC_TSRMLS_CACHE when
bui

Autotools: Fix ext/standard sources (#15131)

This appends source files to the PHP_NEW_EXTENSION call and adds the
possible compilation flag -DZEND_ENABLE_STATIC_TSRMLS_CACHE when
building objects as done on all ext/standard sources already. Also, the
PHP_EXT_DIR Autoconf macro doesn't accept any argument.

show more ...

Autotools: Check for crypt and crypt_r with AC_* macros (#15060)

This checks if crypt and crypt_r functions are available on the system
in default libraries or in the crypt library with

Autotools: Check for crypt and crypt_r with AC_* macros (#15060)

This checks if crypt and crypt_r functions are available on the system
in default libraries or in the crypt library with the AC_SEARCH_LIBS.
The redundant HAVE_LIBCRYPT symbol is removed.

show more ...

Autotools: Fix unused result and variables warnings in flush IO check (#15056)

- exit() replaced with regular return since these two behave the same in
main()
- main(void) used as

Autotools: Fix unused result and variables warnings in flush IO check (#15056)

- exit() replaced with regular return since these two behave the same in
main()
- main(void) used as argc and argv aren't used
- if sentences wrapped in curly brackets for readability
- fgets wrapped in if to check for the return result and omit the
"ignoring return value of 'fgets' declared with attribute
'warn_unused_result'..." warnings in the config.log
- fclose(fp) added before returning

show more ...

Autotools: Sync CS in ext/standard process check (#15049)

- AC_* macros simplified and arguments quoted

Autotools: Quote M4 arguments (#15033)

- PHP_ADD_INCLUDE
- PHP_EVAL_INCLINE
- PHP_EVAL_LIBLINE

Autotools: Expand m4_normalize sooner (#15018)

Quoted m4_normalize will expand and change its argument later in the
macro call when M4 is processing the *.m4 sources. Without quotes the

Autotools: Expand m4_normalize sooner (#15018)

Quoted m4_normalize will expand and change its argument later in the
macro call when M4 is processing the *.m4 sources. Without quotes the
already normalized string is passed to the macro directly. In these
specific cases generated configure script is the same. This is more for
consistency to have this synced and not repeat the pattern too much
in the future when copy/pasting. Note, that many AC_* macros require
similar behavior already (for example, AC_CHECK_FUNCS.)

show more ...

Autotools: Quote all PHP_ADD_BUILD_DIR arguments (#14947)

- All arguments quoted for consistency
- m4_normalize used where list of directories becomes a bit simpler to
read and see

Autotools: Quote all PHP_ADD_BUILD_DIR arguments (#14947)

- All arguments quoted for consistency
- m4_normalize used where list of directories becomes a bit simpler to
read and see the diff

show more ...

Autotools: Refactor crypt check in ext/standard (#14856)

- AH_TEMPLATE sets the CPP macro help text on a single place
- AC_DEFINE can be used instead of AC_DEFINE_UNQUOTED
- AS_VAR_I

Autotools: Refactor crypt check in ext/standard (#14856)

- AH_TEMPLATE sets the CPP macro help text on a single place
- AC_DEFINE can be used instead of AC_DEFINE_UNQUOTED
- AS_VAR_IF used and CS synced
- crypt() function is at this point required as all required algorithm
checks are depending on it and error is thrown if not found when using
external crypt library

show more ...

Autotools: Move crypt_r check (#14832)

The crypt_r() function is required and check can error out separately.

Remove HAVE_STRPTIME_DECL_FAILS (#14821)

The strptime, where available, needs the _GNU_SOURCE defined or compiler
flag -std=gnuXX appended to be declared in time.h. PHP's strptime is

Remove HAVE_STRPTIME_DECL_FAILS (#14821)

The strptime, where available, needs the _GNU_SOURCE defined or compiler
flag -std=gnuXX appended to be declared in time.h. PHP's strptime is
also deprecated as of PHP 8.1.

This removes the HAVE_STRPTIME_DECL_FAILS in favor of a simpler
AC_CHECK_DECL check and HAVE_DECL_STRPTIME CPP macro.

show more ...

Autotools: Refactor ext/standard strptime check (#14800)

- Cache variable renamed from ac_cv_strptime_decl_fails to
php_cv_have_decl_strptime
- CS synced

Autotools: Refactor ext/standard cache variables (#14799)

- Cache variable renamed from ac_cv_flush_io to php_cv_have_flush_io
- CS synced

Refactor HAVE_GETIFADDRS checks (#14787)

- AC_CACHE used with php_cv_func_getifaddrs cache variable
- Synced #if/ifdef/defined checks for HAVE_GETIFADDRS as it is either
defined to

Refactor HAVE_GETIFADDRS checks (#14787)

- AC_CACHE used with php_cv_func_getifaddrs cache variable
- Synced #if/ifdef/defined checks for HAVE_GETIFADDRS as it is either
defined to 1 or undefined

show more ...

Autotools: Sync indentation style in build system files (#14725)

Normalize AC_CHECK_HEADER* arguments (#14723)

The m4_normalize is for Autoconf < 2.70 (on 2.70 and later versions a
blank-or-newline separated items can be expanded without using
bac

Normalize AC_CHECK_HEADER* arguments (#14723)

The m4_normalize is for Autoconf < 2.70 (on 2.70 and later versions a
blank-or-newline separated items can be expanded without using
backslash-newline). The order of headers in configure.ac is left as is
because the first few headers depend on checking other headers (for
those includes the 4th argument).

show more ...

Normalize AC_CHECK_FUNC* first argument (#14700)

The m4_normalize is for Autoconf < 2.70 (on 2.70 and later versions a
blank-or-newline separated items can be expanded without using

Normalize AC_CHECK_FUNC* first argument (#14700)

The m4_normalize is for Autoconf < 2.70 (on 2.70 and later versions a
blank-or-newline separated items can be expanded without using
backslash-newline).

This also syncs the 1st argument quotes.

show more ...