Use "must not" instead of "cannot" wording

Use new helper function for "cannot be empty" ValueErrors

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Before, out of tree builds would preferably include files from the src dir, as
the include path was defined as follows (ignoring includes from ext/ and sapi/) :

-I$(top_builddir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/main
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM
-I$(top_builddir)/

As a result, an out of tree build would include configure artifacts such as
`main/php_config.h` from the src dir.

After this change, the include path is defined as follows:

-I$(top_builddir)/main
-I$(top_builddir)
-I$(top_srcdir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM

* Fix extension include path for out of tree builds

* Include config.h with the brackets form

`#include "config.h"` searches in the directory containing the including-file
before any other include path. This can include the wrong config.h when building
out of tree and a config.h exists in the source tree.

Using `#include <config.h>` uses exclusively the include path, and gives
priority to the build dir.

show more ...

Clean-up some more headers (#14416)

Remove unused headers (such as php_ini.h for extensions that don't define INI settings)
Use more specific headers when possible

ext/sqlite: Sqlite3Stmt::bindParam/bindValue named parameters change. (#14393)

memmove seems unnecessary on `:` autoprepend.

Mark multple functions as static (#13864)

* Mark many functions as static

Multiple functions are missing the static qualifier.

* remove unused struct sigactions

st

Mark multple functions as static (#13864)

* Mark many functions as static

Multiple functions are missing the static qualifier.

* remove unused struct sigactions

struct sigaction act, old_term, old_quit, old_int;
all unused.

* optimizer: minXOR and maxXOR are unused

show more ...

ext/sqlite3: Use new F ZPP modifier (#14040)

Change getThis() into ZEND_THIS where possible (#13641)

Minor sqlite3 cleanups (#13141)

* Remove always-true stmt_obj->db_obj condition

This is always true because SQLITE3_CHECK_INITIALIZED checks this.

* Remove always-true para

Minor sqlite3 cleanups (#13141)

* Remove always-true stmt_obj->db_obj condition

This is always true because SQLITE3_CHECK_INITIALIZED checks this.

* Remove always-true param_number check

This is always true because we return early when the value < 1.

show more ...

Retain a RETURN_THROWS() in ext/sqlite3

Use zend_get_gc_buffer_add_fcc()

Fix build with sqlite3 gc and fci/fcc api

Fix GH-11878: SQLite3 callback functions cause a memory leak with a callable array

In this test file, the free_obj handler is called with a refcount of 2,
caused by the fact we do a GC_A

Fix GH-11878: SQLite3 callback functions cause a memory leak with a callable array

In this test file, the free_obj handler is called with a refcount of 2,
caused by the fact we do a GC_ADDREF() to increase its refcount while
its refcount is still 1 because the Foo object hasn't been destroyed yet
(due to the cycle caused by the sqlite function callback).
Solve this by introducing a get_gc handler.

Closes GH-11881.

show more ...

Revert "Skip profiling of sqlite3_step"

This reverts commit bb31a75321c1b6cc060568fe0b3f123d1a72d67d.

It doesn't seem like this actually fixed the problem.

Skip profiling of sqlite3_step

It looks like sqlite3_step can vary quite drastically from one request to the
next. This seems to be caused by more or fewer calls to sqlite3VdbeSorterWrit

Skip profiling of sqlite3_step

It looks like sqlite3_step can vary quite drastically from one request to the
next. This seems to be caused by more or fewer calls to sqlite3VdbeSorterWrite.
It would be great if we could find a way to make execution of this function more
consistent, but at this point I don't know how.

Closes GH-12130

show more ...

Fix replaced error handling in SQLite3Stmt::__construct

The error handling is replaced using zend_replace_error_handling(), but
when SQLITE3_CHECK_INITIALIZED() returns early, the old er

Fix replaced error handling in SQLite3Stmt::__construct

The error handling is replaced using zend_replace_error_handling(), but
when SQLITE3_CHECK_INITIALIZED() returns early, the old error handling
isn't restored.

In the past, SQLITE3_CHECK_INITIALIZED() threw a warning when the check
failed. This was replaced a few years ago with an error exception. So we
can fix the bug by just removing the replacing error handling as it
accomplishes nothing anymore.

Closes GH-11607.

show more ...

[RFC] Transition SQLite3 to exceptions (#11058)

* Deprecate warnings in SQLite3, change returned exception class to SQLite3Exception

RFC: https://wiki.php.net/rfc/sqlite3_exceptions

[RFC] Transition SQLite3 to exceptions (#11058)

* Deprecate warnings in SQLite3, change returned exception class to SQLite3Exception

RFC: https://wiki.php.net/rfc/sqlite3_exceptions

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>

show more ...

Fix GH-11451: Invalid associative array containing duplicate keys

It used the "add_new" variant which assumes the key doesn't already
exist. But in case of duplicate keys we have to take

Fix GH-11451: Invalid associative array containing duplicate keys

It used the "add_new" variant which assumes the key doesn't already
exist. But in case of duplicate keys we have to take the last result.

Closes GH-11453.

show more ...

ext: make various internal functions static (#10650)

Namely in:
* ext/date
* ext/libxml
* ext/dba
* ext/curl

Make lots of string pointers `const` (#10646)

This allows using string literals without implicitly casting away the
`const`.

Fix #81742: open_basedir bypass in SQLite3 by using file URI

A previous fix[1] was not sufficient to catch all potential file URIs,
because the patch did not cater to URL encoding. Prop

Fix #81742: open_basedir bypass in SQLite3 by using file URI

A previous fix[1] was not sufficient to catch all potential file URIs,
because the patch did not cater to URL encoding. Properly parsing and
decoding the URI may yield a different result than the handling of
SQLite3, so we play it safe, and reject any file URIs if open_basedir
is configured.

[1] <https://bugs.php.net/bug.php?id=77967>

Closes GH-10018.

show more ...

Handle trampolines correctly in new FCC API + usages (#9877)

Only use FCC for SQLite3 user defined authorizer

Only use FCC for SQLite3 user defined collations

Only use FCC for SQLite3 user defined functions