Fix GH-16256: Assertion failure in ext/soap/php_encoding.c:460

The class map must be an associative array, not a packed array.

Closes GH-16269.

Fix GH-16237: Segmentation fault when cloning SoapServer

Bisect points to 94ee4f9, however this only reveals the problem.
Cloning an object on a lower branch and trying to call its metho

Fix GH-16237: Segmentation fault when cloning SoapServer

Bisect points to 94ee4f9, however this only reveals the problem.
Cloning an object on a lower branch and trying to call its methods
crashes as well. Cloning the object shouldn't be possible in the first
place because there's an engine constraint that when we have a new
object handler we should also have a clone handler. This constraint is
not fulfilled here.

Closes GH-16245.

show more ...

Avoid allocating memory in soap get_function() (#15843)

Implement request #47317: SoapServer::__getLastResponse()

Convenient for debugging.

Closes GH-15792.

Use "must not" instead of "cannot" wording

Use new helper function for "cannot be empty" ValueErrors

ext/soap: Deprecate passing an int to SoapServer::addFunction() (#15310)

Also deprecate SOAP_FUNCTIONS_ALL constant.

RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_soa

ext/soap: Deprecate passing an int to SoapServer::addFunction() (#15310)

Also deprecate SOAP_FUNCTIONS_ALL constant.

RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_soap_functions_all_constant_and_passing_it_to_soapserveraddfunction

show more ...

Revert "Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)"

This reverts commit 476706165a227ea6b1d73299b9b6486a6ca073a9.

Although the fix is co

Revert "Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)"

This reverts commit 476706165a227ea6b1d73299b9b6486a6ca073a9.

Although the fix is correct, people are relying on the bug and their
code stopped working, see GH-15252.

show more ...

Fix SoapFault property destruction

Two issues:
1) We should not modify the object when we pass invalid values
2) We should reset the properties to their default value otherwise we

Fix SoapFault property destruction

Two issues:
1) We should not modify the object when we pass invalid values
2) We should reset the properties to their default value otherwise we
get a UAF.

Regressed in df219ccf9d6be8302eef3ab6e26fd00fbd2fef71

Closes GH-15248.

show more ...

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Before, out of tree builds would preferably include files from the src dir, as
the include path was defined as follows (ignoring includes from ext/ and sapi/) :

-I$(top_builddir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/main
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM
-I$(top_builddir)/

As a result, an out of tree build would include configure artifacts such as
`main/php_config.h` from the src dir.

After this change, the include path is defined as follows:

-I$(top_builddir)/main
-I$(top_builddir)
-I$(top_srcdir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM

* Fix extension include path for out of tree builds

* Include config.h with the brackets form

`#include "config.h"` searches in the directory containing the including-file
before any other include path. This can include the wrong config.h when building
out of tree and a config.h exists in the source tree.

Using `#include <config.h>` uses exclusively the include path, and gives
priority to the build dir.

show more ...

ext/soap: Use zend_string for name parameter of set_soap_fault()

ext/soap: Refactor verify_soap_headers_array()

Make its duty only to check if the provided HashTable is valid

ext/soap: prevent needless computation of strlen()

ext/soap: Refactor SOAP call methods implementation

ext/soap: SoapServer::addSoapHeader() does not need bailout handler wrapper

As this methods never uses the bailout mechanism

ext/soap: SoapServer::addFunction() does not need bailout handler wrapper

As this methods never uses the bailout mechanism

ext/soap: SoapServer::getFunctions() does not need bailout handler wrapper

As this methods never uses the bailout mechanism

ext/soap: SoapServer::setObject() does not need bailout handler wrapper

As this methods never uses the bailout mechanism

ext/soap: SoapServer::setClass() does not need bailout handler wrapper

As this methods never uses the bailout mechanism

ext/soap: SoapServer::setPersistence() does not need bailout handler wrapper

As this methods never uses the bailout mechanism

ext/soap: Use bool type for _bailout variable

ext/soap: Use bool as return type instead of int for do_request()

ext/soap: Fix memory leaks when calling SoapFault::__construct() twice

Fix ZEND_DEBUG condition (#14408)

ZEND_DEBUG is always defined by the build system automatically, either
to value 0 or value 1.

Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)

There's a hash table that maps type names to class name, but names with
a leading backslash are no

Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)

There's a hash table that maps type names to class name, but names with
a leading backslash are not supported. The engine has logic to strip
away the leading backslash that we should replicate here.

It works by checking if we need to make an actual copy in case an
unexpected (e.g. invalid data or leading backslash) situations are
detected. Upon making a copy we normalize the data in the table.

Furthermore, previously the code assumed that the key was always valid
and that the structure was a non-packed hash table. This isn't
necessarily the case. The new code fixes this as well.

Closes GH-14398.

show more ...