Fix GH-16695: phar:// tar parser and zero-length file header blocks

There are two issues:
1) There's an off-by-one in the check for the minimum file size for a
tar (i.e. `>` inste

Fix GH-16695: phar:// tar parser and zero-length file header blocks

There are two issues:
1) There's an off-by-one in the check for the minimum file size for a
tar (i.e. `>` instead of `>=`).
2) The loop in the tar parsing parses a header, and then unconditionally
reads the next one. However, that doesn't necessarily exist.
Instead, we remove the loop condition and check for the end of the
file before reading the next header. Note that we can't use
php_stream_eof as the flag may not be set yet when we're already at
the end.

Closes GH-16700.

show more ...

Cast big endian byte shuffling to uint

This works, but UBSan running on a big endian platform (in this, ppc64)
will complain that the ((uchar*)buffer)[n] is int, and shifting that
co

Cast big endian byte shuffling to uint

This works, but UBSan running on a big endian platform (in this, ppc64)
will complain that the ((uchar*)buffer)[n] is int, and shifting that
could be weird. Since the value of PHAR_GET_32 et al are almost always
unsigned, it makes sense to cast these as unsigned.

Fixes phar tests on a big endian system with UBSan enabled.

show more ...

ext/phar: Voidify flush function as it always returns EOL

ext/phar: Move variable to inner scope

ext/phar: Mark constant string as static const

ext/phar: Use bool instead of int

ext/phar: Refactor flushing of archive to only take string stub file

Fix short-lived phar regression

Regressed in 1facbc385a5ada2496bf617daed1b3e53e136a25
The macro caused the value to be read over and over, but the change to
a variable makes the cond

Fix short-lived phar regression

Regressed in 1facbc385a5ada2496bf617daed1b3e53e136a25
The macro caused the value to be read over and over, but the change to
a variable makes the condition not work like before. Just inline the
read.

show more ...

ext/phar: Use normal variable instead of macro

ext/phar: Add comment about include

ext/phar: Reduce scope of some variables

ext/phar: Use zend_result as return value

Also simplify some calls to functions returning zend_result

ext/phar: Reorganise some headers

ext/phar: Use more specialized types instead of int

ext/phar: Refactor part of tar.c

ext/phar: Use size_t for string lenghts

And remove useless casts

Update http links to https and sync www.php.net URLs (#14854)

Remove unused return value from phar_entry_delref()

Remove unused typedefs in phar.c

Remove unused field from _phar_archive_data (#14146)

This field is only ever written to, but never read.

Fix GH-13833: Applying zero offset to null pointer in zend_hash.c

MAPPHAR_FAIL will call the destructor of the manifest, mounted_dirs, and
virtual_dirs tables. When a new phar object is

Fix GH-13833: Applying zero offset to null pointer in zend_hash.c

MAPPHAR_FAIL will call the destructor of the manifest, mounted_dirs, and
virtual_dirs tables. When a new phar object is allocated using (p)ecalloc,
the bytes are zeroed, but the flag for an uninitialized table is
non-zero. So we have to manually set the flag in case that we have a
code path that can destroy the tables without first initializing them at
least once.

Closes GH-13847.

show more ...

Minor conditions simplify (#10397)

ext/phar: Fix recently introduced potential NULL dereferencement segfaults (#11065)

ext/phar: Prevent unnecessary known string length computation

Closes GH-11033

Convert char* + size_t parameters to zend_string* in phar_find_in_include_path()