#
c316382a |
| 19-Aug-2024 |
Kamil Tekiela |
Remove MYSQLI_STMT_ATTR_PREFETCH_ROWS constant (#15485) This feature was never implemented, and since the beginning, using this constant with mysqlnd would result in an error. Th
Remove MYSQLI_STMT_ATTR_PREFETCH_ROWS constant (#15485) This feature was never implemented, and since the beginning, using this constant with mysqlnd would result in an error. This feature was only available with libmysqlclient which can no longer be used with mysqli. There are no plans to implement it in the future.
show more ...
|
#
a8c92700 |
| 06-Mar-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Skip validity and length calls when the byte cannot be part of a multibyte sequence Almost every character set can be given a number N such that a multibyte sequence starts with a byte h
Skip validity and length calls when the byte cannot be part of a multibyte sequence Almost every character set can be given a number N such that a multibyte sequence starts with a byte higher than that number N. This allows us to skip a lot of work. To ensure the correctness of this, a sanity check is implemented that exhaustively tries every 4-byte sequence for every character set and checks for consistency issues. This finally gives: Time (mean ± σ): 120.2 ms ± 1.2 ms [User: 116.9 ms, System: 2.8 ms] Range (min … max): 118.0 ms … 122.9 ms 24 runs
show more ...
|
#
1571eed0 |
| 21-Feb-2024 |
Niels Dossche <7771979+nielsdos@users.noreply.github.com> |
Replace dead overflow checks with assertions and avoid indirect call overhead We allocate twice the input length, and every input character results in either 1 or 2 output bytes, so we c
Replace dead overflow checks with assertions and avoid indirect call overhead We allocate twice the input length, and every input character results in either 1 or 2 output bytes, so we cannot overflow. By using an enum, and a switch table (which will be efficiently compiled into a jump table), we can avoid the pessimistic code generation of the indirect calls. With this I get the following runtime for the test script in GH-13466 on my i7-4790, which is around 1.25x faster. Time (mean ± σ): 250.9 ms ± 1.6 ms [User: 248.4 ms, System: 2.0 ms] Range (min … max): 248.9 ms … 254.4 ms 11 runs
show more ...
|
#
0e5128c2 |
| 17-Jan-2023 |
Kamil Tekiela |
Remove mysqlnd_shutdown() (#10355)
|
Revision tags: php-8.2.0RC1, php-8.1.10, php-8.0.23, php-8.0.23RC1, php-8.1.10RC1, php-8.2.0beta3, php-8.2.0beta2, php-8.1.9, php-8.0.22, php-8.1.9RC1, php-8.2.0beta1, php-8.0.22RC1, php-8.0.21, php-8.1.8, php-8.2.0alpha3, php-8.1.8RC1, php-8.2.0alpha2, php-8.0.21RC1, php-8.0.20, php-8.1.7, php-8.2.0alpha1, php-7.4.30, php-8.1.7RC1, php-8.0.20RC1, php-8.1.6, php-8.0.19, php-8.1.6RC1, php-8.0.19RC1, php-8.0.18, php-8.1.5, php-7.4.29, php-8.1.5RC1, php-8.0.18RC1, php-8.1.4, php-8.0.17, php-8.1.4RC1, php-8.0.17RC1, php-8.1.3, php-8.0.16, php-7.4.28, php-8.1.3RC1, php-8.0.16RC1, php-8.1.2, php-8.0.15, php-8.1.2RC1, php-8.0.15RC1, php-8.0.14, php-8.1.1, php-7.4.27, php-8.1.1RC1, php-8.0.14RC1, php-7.4.27RC1, php-8.1.0, php-8.0.13, php-7.4.26, php-7.3.33, php-8.1.0RC6, php-7.4.26RC1, php-8.0.13RC1, php-8.1.0RC5, php-7.3.32 |
|
#
885dca37 |
| 21-Oct-2021 |
Kamil Tekiela |
Remove mysqlnd_unbuffered_skip_result and voidify skip_result
|
#
ad5f4715 |
| 21-Oct-2021 |
Kamil Tekiela |
(mysqlnd_conn_data, restart_psession) never fails
|
#
6be17906 |
| 21-Oct-2021 |
Kamil Tekiela |
Reset cannot fail. It was used in a condition, but it doesn't have to be.
|
#
e7a815d1 |
| 21-Oct-2021 |
Kamil Tekiela |
(mysqlnd_conn_data, end_psession) never fails
|
#
45607225 |
| 21-Oct-2021 |
Kamil Tekiela |
pfc & vio init methods cannot fail These methods cannot fail the way they are currently designed. They only call set_client_option which could fail only with wrong arguments. Since t
pfc & vio init methods cannot fail These methods cannot fail the way they are currently designed. They only call set_client_option which could fail only with wrong arguments. Since this is an internal call, the arguments should never change. Either way set_client_option should not cause init to fail.
show more ...
|
Revision tags: php-7.4.25, php-8.0.12, php-8.1.0RC4, php-8.0.12RC1, php-7.4.25RC1, php-8.1.0RC3, php-8.0.11, php-7.4.24, php-7.3.31, php-8.1.0RC2, php-7.4.24RC1, php-8.0.11RC1, php-8.1.0RC1, php-7.4.23, php-8.0.10, php-7.3.30, php-8.1.0beta3 |
|
#
277e169e |
| 12-Aug-2021 |
Nikita Popov |
Remove mysqlnd local_tx functionality These are not used in-tree and cause unnecessary complexity and untestable failure modes.
|
Revision tags: php-8.0.10RC1, php-7.4.23RC1, php-8.1.0beta2, php-8.0.9 |
|
#
132d4994 |
| 29-Jul-2021 |
Kamil Tekiela |
Drop mysqlnd statistics triggers This functionality is not used productively in PHP and it's not used in any of the extensions to my knowledge. Since it looks like this functionality
Drop mysqlnd statistics triggers This functionality is not used productively in PHP and it's not used in any of the extensions to my knowledge. Since it looks like this functionality isn't required by anyone, let's clean up mysqlnd and drop it.
show more ...
|
#
fb85731c |
| 28-Jul-2021 |
Kamil Tekiela |
Remove get_parameter_metadata
|
Revision tags: php-7.4.22, php-8.1.0beta1, php-7.4.22RC1, php-8.0.9RC1, php-8.1.0alpha3, php-7.4.21, php-7.3.29, php-8.0.8, php-8.1.0alpha2, php-7.4.21RC1, php-8.0.8RC1, php-8.1.0alpha1, php-8.0.7, php-7.4.20, php-8.0.7RC1, php-7.4.20RC1 |
|
#
01b3fc03 |
| 06-May-2021 |
KsaR |
Update http->https in license (#6945) 1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https. 2. Update few license 3.0 to 3.01 as
Update http->https in license (#6945) 1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https. 2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier". 3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted. 4. fixed indentation in some files before |
show more ...
|
Revision tags: php-8.0.6, php-7.4.19, php-7.4.18, php-7.3.28, php-8.0.5, php-8.0.5RC1, php-7.4.18RC1, php-8.0.4RC1, php-7.4.17RC1, php-8.0.3, php-7.4.16 |
|
#
771b0bd1 |
| 23-Feb-2021 |
Nikita Popov |
Remove free_chunk API This API only works in very limited circumstances -- relying on it will invariably lead to leaks. The correct way to "free" something from the pool is to use th
Remove free_chunk API This API only works in very limited circumstances -- relying on it will invariably lead to leaks. The correct way to "free" something from the pool is to use the checkpoint API.
show more ...
|
#
6e6d6bb4 |
| 23-Feb-2021 |
Nikita Popov |
Remove resize_chunk API The last user has been dropped in the previous commit. This has never worked meaningfully in the first place.
|
#
da011a31 |
| 22-Feb-2021 |
Darek Slusarczyk |
Fix #80329: Add option to specify LOAD DATA LOCAL white list folder * allow the user to specify a folder where files that can be sent via LOAD DATA LOCAL can exist * add mysqli.
Fix #80329: Add option to specify LOAD DATA LOCAL white list folder * allow the user to specify a folder where files that can be sent via LOAD DATA LOCAL can exist * add mysqli.local_infile_directory for mysqli (ignored if mysqli.allow_local_infile is enabled) * add PDO::MYSQL_ATTR_LOCAL_INFILE_DIRECTORY for pdo_mysql (ignored if PDO::MYSQL_ATTR_LOCAL_INFILE is enabled) * add related tests * fixes for building with libmysql 8.x * small improvement in existing tests * update php.ini-[development|production] files Closes GH-6448. Co-authored-by: Nikita Popov <nikic@php.net>
show more ...
|
Revision tags: php-8.0.3RC1, php-7.4.16RC1, php-8.0.2, php-7.4.15, php-7.3.27, php-8.0.2RC1, php-7.4.15RC2, php-7.4.15RC1 |
|
#
3e01f5af |
| 15-Jan-2021 |
Nikita Popov |
Replace zend_bool uses with bool We're starting to see a mix between uses of zend_bool and bool. Replace all usages with the standard bool type everywhere. Of course, zend_bool
Replace zend_bool uses with bool We're starting to see a mix between uses of zend_bool and bool. Replace all usages with the standard bool type everywhere. Of course, zend_bool is retained as an alias.
show more ...
|
Revision tags: php-8.0.1, php-7.4.14, php-7.3.26 |
|
#
037512cf |
| 18-Dec-2020 |
Nikita Popov |
Move fetch_all implementation out of mysqlnd There doesn't seem to be any compelling reason to implement this in mysqlnd rather than mysqli. It's just a loop over fetch_into. Th
Move fetch_all implementation out of mysqlnd There doesn't seem to be any compelling reason to implement this in mysqlnd rather than mysqli. It's just a loop over fetch_into. This makes the function available under libmysqlclient as well, and thus fixes bug #79372.
show more ...
|
Revision tags: php-7.4.14RC1, php-8.0.1RC1, php-7.3.26RC1 |
|
#
33e90491 |
| 14-Dec-2020 |
Nikita Popov |
MySQLnd: Clean up and optimize mysqlnd result set handling This is a larger overhaul of the mysqlnd result set infrastructure: * Drop support for two different types of buffered re
MySQLnd: Clean up and optimize mysqlnd result set handling This is a larger overhaul of the mysqlnd result set infrastructure: * Drop support for two different types of buffered results sets ("c" and "zval"). Possibly these made sense at some earlier time, but now (with minor adjustments) one option is strictly worse than the other. Buffered result sets already buffer the full row packets, from which zvals can be decoded. The "zval" style additionally also buffered the decoded zvals. As result sets, even buffered ones, are generally only traversed once, this just ends up wasting memory. Now, a potentially useful variation here would be to buffer the decoded zvals instead of the row packets, but that's not what the code was doing. * To make it really strictly better, pre-allocate the zval row buffer and reuse it for all rows. Previously the "c" style always allocated a new buffer for each row. * The fetch_row API now provides a populated zval[]. The task of populating an array is deferred to fetch_row_into, which also avoids duplicating this code in multiple places. The fetch_row_c API is also implemented on top of fetch_row now, rather than duplicating large parts of the code. * The row fetching code for prepared statements and normal result sets has been mostly merged. These already used the same infrastructure, but prepared statements used separate row fetching functions that were nearly the same as the normal ones. This requires passing the stmt into the result set, rather than just a flag. The only part that remains separate is reading of unbuffered results in the presence of PS cursors.
show more ...
|
#
890e4caf |
| 14-Dec-2020 |
Nikita Popov |
Drop support for max_length in mysqli_fetch_fields() Retain the field, but always populate it with zero. This was already the case for PS without length updating. max_length has
Drop support for max_length in mysqli_fetch_fields() Retain the field, but always populate it with zero. This was already the case for PS without length updating. max_length has nothing lost in the field metadata -- it is a property of the specific result set, and requires scanning the whole result set to compute. PHP itself never uses max_length with mysqlnd, it is only exposed in the raw mysqli API. Keeping it for just that purpose is not worthwhile given the costs involved. People who actually need this for some reason can easily calculate it themselves, while making it obvious that the calculation requires a full result set scan.
show more ...
|
#
80646589 |
| 15-Dec-2020 |
Nikita Popov |
MySQLnd: Drop free_result_internal Merge it into free_result. There is a large number of different free_* functions for result sets, let's avoid having one more. Only difference is t
MySQLnd: Drop free_result_internal Merge it into free_result. There is a large number of different free_* functions for result sets, let's avoid having one more. Only difference is that it does not increment stats, and that seems like a bug as free_stmt_result is still freeing a result.
show more ...
|
#
362c2924 |
| 15-Dec-2020 |
Nikita Popov |
Remove mysqlnd_extension enum ext/mysql is no longer supported, drop handling for it from mysqlnd.
|
#
be4f73f3 |
| 15-Dec-2020 |
Nikita Popov |
MySQLnd: Remove unused fetch_field_data method This method is not used, and is implemented in a very dubious way.
|
#
141eb346 |
| 14-Dec-2020 |
Nikita Popov |
Remove MYSQLND_STRING_TO_INT_CONVERSION define This has been unconditionally enabled for a long time already (the actual conversion is behind an additional runtime flag).
|
Revision tags: php-8.0.0, php-7.3.25, php-7.4.13, php-8.0.0RC5, php-7.4.13RC1, php-8.0.0RC4, php-7.3.25RC1, php-7.4.12, php-8.0.0RC3, php-7.3.24, php-8.0.0RC2, php-7.4.12RC1, php-7.3.24RC1, php-7.2.34, php-8.0.0rc1, php-7.4.11, php-7.3.23, php-8.0.0beta4, php-7.4.11RC1, php-7.3.23RC1, php-8.0.0beta3, php-7.4.10, php-7.3.22, php-8.0.0beta2, php-7.3.22RC1, php-7.4.10RC1, php-8.0.0beta1, php-7.4.9, php-7.2.33, php-7.3.21, php-8.0.0alpha3, php-7.4.9RC1, php-7.3.21RC1, php-7.4.8, php-7.2.32, php-8.0.0alpha2, php-7.3.20, php-8.0.0alpha1, php-7.4.8RC1, php-7.3.20RC1, php-7.4.7, php-7.3.19, php-7.4.7RC1, php-7.3.19RC1, php-7.4.6, php-7.2.31, php-7.4.6RC1, php-7.3.18RC1, php-7.2.30, php-7.4.5, php-7.3.17, php-7.4.5RC1, php-7.3.17RC1, php-7.3.18, php-7.4.4, php-7.2.29, php-7.3.16, php-7.4.4RC1, php-7.3.16RC1, php-7.4.3, php-7.2.28, php-7.3.15RC1, php-7.4.3RC1, php-7.3.15, php-7.2.27, php-7.4.2, php-7.3.14, php-7.3.14RC1, php-7.4.2RC1 |
|
#
6225137b |
| 27-Dec-2019 |
Nikita Popov |
Support auth switch request during caching sha2 auth
|