Fix GH-13815: mb_trim() inaccurate $characters default value (#13820)

Because the default characters are defined in the stub file, and the
stub file is UTF-8 (typically), the characters

Fix GH-13815: mb_trim() inaccurate $characters default value (#13820)

Because the default characters are defined in the stub file, and the
stub file is UTF-8 (typically), the characters are encoded in the string
as UTF-8. When using a different character encoding, there is a mismatch
between what mb_trim expects and the UTF-8 encoded string it gets.

One way of solving this is by making the characters argument nullable,
which would mean that it always uses the internal code path that has the
unicode codepoints that are defaulted actually stored as codepoint
numbers instead of in a string.

Co-authored-by: @ranvis

show more ...

[RFC] Add mb_ucfirst and mb_lcfirst functions (#13161)

Return value of mb_get_info can be NULL

This has been the case at least since PHP 5.4. Thanks to Girgias for
pointing it out.

It appears that there are several global variables

Return value of mb_get_info can be NULL

This has been the case at least since PHP 5.4. Thanks to Girgias for
pointing it out.

It appears that there are several global variables internal to mbstring
which can be queried via mb_get_info() and which could be NULL, but
at the very least, we know that "mbstring.http_input" is one of them.

show more ...

Add mb_trim function

Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Co-authored-by: Gina Peter Banyard <girgias@php.net>

[RFC] Implement mb_str_pad() (#11284)

Closes GH-10203.

Use shared, immutable array for return value of mb_list_encodings

This will allow us to easily check in other mbstring functions if the
list of all supported encodings, returned by mb_li

Use shared, immutable array for return value of mb_list_encodings

This will allow us to easily check in other mbstring functions if the
list of all supported encodings, returned by mb_list_encodings, is
passed in as input to another function.

Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>

show more ...

Fix mb_strimwidth RC info

Closes GH-9254

Rename @cname to @cvalue in stubs (#9043)

@cname currently refers to the constant name in C. However, it is not always a (constant) name, but sometimes a function invocation, so naming it as

Rename @cname to @cvalue in stubs (#9043)

@cname currently refers to the constant name in C. However, it is not always a (constant) name, but sometimes a function invocation, so naming it as @cvalue would be more appropriate.

show more ...

Declare ext/mbstring constants in stubs (#8798)

Add support for generating MAY_BE_ARRAY_OF_REF func info flag (#7416)

Generate optimizer func info from stubs for various extensions (#7409)

ext/hash, ext/iconv, ext/mbstring, ext/xml, ext/zlib

Generate class entries from stubs for ldap, libxml, mbstring and mysqli

Closes GH-6684

Normalize mb_ereg() return value

mb_ereg()/mb_eregi() currently have an inconsistent return value
based on whether the $matches parameter is passed or not:

> Returns the byte le

Normalize mb_ereg() return value

mb_ereg()/mb_eregi() currently have an inconsistent return value
based on whether the $matches parameter is passed or not:

> Returns the byte length of the matched string if a match for
> pattern was found in string, or FALSE if no matches were found
> or an error occurred.
>
> If the optional parameter regs was not passed or the length of
> the matched string is 0, this function returns 1.

Coupling this behavior to the $matches parameter doesn't make sense
-- we know the match length either way, there is no technical
reason to distinguish them. However, returning the match length
is not particularly useful either, especially due to the need to
convert 0-length into 1-length to satisfy "truthy" checks. We
could always return 1, which would kind of match the behavior of
preg_match() -- however, preg_match() actually returns the number
of matches, which is 0 or 1 for preg_match(), while false signals
an error. However, mb_ereg() returns false both for no match and
for an error. This would result in an odd 1|false return value.

The patch canonicalizes mb_ereg() to always return a boolean,
where true indicates a match and false indicates no match or error.
This also matches the behavior of the mb_ereg_match() and
mb_ereg_search() functions.

This fixes the default value integrity violation in PHP 8.

Closes GH-6331.

show more ...

Update mbstring parameter names

Closes GH-6207.

Standardize mbstring and string on using 'string' as a parameter name.

Closes GH-6171.

Promote a few remaining errors in ext/standard

Closes GH-6110

Make mb_send_mail() consistent with mail()

The $additional_headers parameter shouldn't accept null.

Move custom type checks to ZPP

Closes GH-6034

Add a few missing parameter types in stubs

Related to GH-5627

Fix UNKNOWN default values in ext/mbstring and ext/gd

Closes GH-5598

Fix mb_ereg_search* arg and func info

Fix [-Wundef] warning in MBString extension

Refactor mb_substitute_character()

Using the new Fast ZPP API for string|int|null

This also fixes Bug #79448 which was too disruptive to fix in PHP 7.x

Convert if blocks to assertions and adapt stubs accordingly

Update mb_strrpos() stub

We no longer accept the encoding as 3rd param, so we can make this
a proper int argument.