intl extension couple of micro optimisations for error edge cases. (#10044)

making c++ compile time few enums ranges.

Fix GH-8364: msgfmt_format $values may not support references

We need to deref any references passed in the `$values` array. While
we could handle this in the type switch, doing it righ

Fix GH-8364: msgfmt_format $values may not support references

We need to deref any references passed in the `$values` array. While
we could handle this in the type switch, doing it right away in the
foreach loop makes that more explicit, and also circumvents the missing
range checks for integers which are not passed as int or double.

Closes GH-8407.

show more ...

Disable workaround for ICU bug on newer versions

This is issue https://unicode-org.atlassian.net/browse/ICU-12584,
which has been fixed in ICU 64.1 by
https://github.com/unicode-org/

Disable workaround for ICU bug on newer versions

This is issue https://unicode-org.atlassian.net/browse/ICU-12584,
which has been fixed in ICU 64.1 by
https://github.com/unicode-org/icu/commit/a9d219691398f0168150ad5a3e5f381f84ca95df.

I'm disabling the workaround for ICU >= 65, as we don't seem to be
doing minor version checks in intl.

show more ...

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Fixed bug #80425

Rename the methods in MessageFormatAdapter to make sure they don't
clash with anything defined by icu itself, which may be a problem
if icu is linked statically.

Generate method entries for ext/intl

Closes GH-5370

Remove mention of PHP major version in Copyright headers

Closes GH-4732.

Fix hash key length in umsg_parse_format()

Fix array length passed to zend_hash_str_find_ptr() casting from
UChar array to char array requires mul by sizeof(UChar).

Fix TimeZone leak in intl MessageFormat

I'm just giving each format a distinct owned object here ... sharing
it looks complicated.

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...

Fixed Bug #76942 U_ARGUMENT_TYPE_MISMATCH

ref bug #74484

Require ICU ≥ 50.1

Given that ICU is a set of lively developed libraries, that ICU 50.1
has been released on 2012-11-05, and PHP 7.4 is scheduled to be
released seven years after it,

Require ICU ≥ 50.1

Given that ICU is a set of lively developed libraries, that ICU 50.1
has been released on 2012-11-05, and PHP 7.4 is scheduled to be
released seven years after it, we consider it appropriate to ditch
these legacy versions.

Particularly, that would be a reasonable groundwork to implement part
two of the “Deprecate and remove INTL_IDNA_VARIANT_2003” RFC[1], namely
to default idn_to_ascii()'s and idn_to_utf8()'s $variant parameter to
INTL_IDNA_VARIANT_UTS46, which is not defined in ICU < 4.6.

See also the related discussion on internals@[2].

[1] <https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003>
[2] <http://news.php.net/php.internals/101626>ff

show more ...

Fixed bug #74484 MessageFormatter::formatMessage memory corruption

with 11+ named placeholder

Removed "dead" code (zend_hash_update() never fails)

Use zend_string_release_ex() instread of zend_string_release() in places, where we sure about string persistence.

Use recommended options for explicit UnicodeString constructors

Simplify namespace access

The icu namespace is an alias which resolves to the real namespace.

Utilize the recommended way to handle the icu namespace

Avoid array duplication and in-place modification

Cleanup type conversion

Fixed bug #70484 selectordinal doesn't work with named parameters

Fixed bug #70484 selectordinal doesn't work with named parameters

Cleanup (avoid string reallocations)

Use ZSTR_ API to access zend_string elements (this is just renaming without semantick changes).

trailing whitespace removal