Minor cleanup in dom_character_data_append_data (#15173)

Resolve TODOs in ext/dom around nullable content (#14999)

It's indeed possible this is NULL. When you create a new text-like node
in libxml and pass NULL as content, you do get NULL in t

Resolve TODOs in ext/dom around nullable content (#14999)

It's indeed possible this is NULL. When you create a new text-like node
in libxml and pass NULL as content, you do get NULL in the content field
instead of the empty string. You can hit this by creating DOMText or
DOMComment directly and not passing any argument. This could also be
created internally.
We refactor the code such that this detail is hidden and we add a test
to check that it correctly throws an exception.

show more ...

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Preferably include from build dir (#13516)

* Include from build dir first

This fixes out of tree builds by ensuring that configure artifacts are included
from the build dir.

Before, out of tree builds would preferably include files from the src dir, as
the include path was defined as follows (ignoring includes from ext/ and sapi/) :

-I$(top_builddir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/main
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM
-I$(top_builddir)/

As a result, an out of tree build would include configure artifacts such as
`main/php_config.h` from the src dir.

After this change, the include path is defined as follows:

-I$(top_builddir)/main
-I$(top_builddir)
-I$(top_srcdir)/main
-I$(top_srcdir)
-I$(top_builddir)/TSRM
-I$(top_builddir)/Zend
-I$(top_srcdir)/Zend
-I$(top_srcdir)/TSRM

* Fix extension include path for out of tree builds

* Include config.h with the brackets form

`#include "config.h"` searches in the directory containing the including-file
before any other include path. This can include the wrong config.h when building
out of tree and a config.h exists in the source tree.

Using `#include <config.h>` uses exclusively the include path, and gives
priority to the build dir.

show more ...

ext/dom: Fix [-Wsign-compare] warnings

Update ext/dom names after policy change (#14171)

Fix 32-bit DOM characterdata failures (#13663)

Use common helper macro for getting the node in property handlers

Use BAD_CAST consistently

Use true instead of 1 with php_dom_throw_error

[RFC] Add a way to opt-in ext/dom spec compliance (#13031)

RFC: https://wiki.php.net/rfc/opt_in_dom_spec_compliance

Deduplicate ParentNode and ChildNode interface implementations using @implementation-alias

The entry points are duplicated: they add bloat and make it easier to forget
to change somethin

Deduplicate ParentNode and ChildNode interface implementations using @implementation-alias

The entry points are duplicated: they add bloat and make it easier to forget
to change something. Make maintenance easier by using @implementation-alias.
Also, this has the nice side-effect of slightly reducing the amount of
code and binary size.

Closes GH-12158.

show more ...

Use zend_result as return for properties in ext/dom (#12113)

Fix empty argument cases for DOMParentNode methods

Closes GH-11768.

Fix DOMCharacterData::replaceWith() with itself

Previously, when replacing the node with itself (or contained within
itself), the node disappeared.

Closes GH-11770.

Get rid of some unnecessary string conversion (#11733)

For typed properties that are of type "string", we don't need to do any
conversion as the zval will already be a string. Removing t

Get rid of some unnecessary string conversion (#11733)

For typed properties that are of type "string", we don't need to do any
conversion as the zval will already be a string. Removing this
simplifies code and avoids unnecessary refcounting.

show more ...

Cleanup macro usage in ext/dom and ext/libxml

With the new lifetime system in place, we can simplify some macros.

Avoid allocation when getting the node content, if possible

Closes GH-11543.

Don't add 1 when calling xmlNodeSetContent()

The length is passed to xmlStrndup(), which also adds 1, and adds a null
terminator past the end. It worked because the length is not actuall

Don't add 1 when calling xmlNodeSetContent()

The length is passed to xmlStrndup(), which also adds 1, and adds a null
terminator past the end. It worked because the length is not actually
stored. Strings in libxml2 are null terminated. Passing the length just
avoids a call to strlen().

show more ...

Use uint32_t for the number of nodes (#11371)

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Promote DOM invalid state errors during property access

Closes GH-6780

Fix bug #80600 DOMChildNode::remove does not work on DOMCharacterData.

Closes GH-6660

Remove proto comments from C files

Closes GH-5758

Fix [-Wundef] warning in DOM extension

Generate method entries for ext/dom

Closes GH-5374