Fix GH-10489: run-tests.php does not escape path when building cmd (#10560)

Multiple tests had to be changed to escape the arguments in shell
commands. Some tests are skipped because th

Fix GH-10489: run-tests.php does not escape path when building cmd (#10560)

Multiple tests had to be changed to escape the arguments in shell
commands. Some tests are skipped because they behave differently with
spaces in the path versus without. One notable example of this is the
hashbang test which does not work because spaces in hashbangs paths are
not supported in Linux.

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

show more ...

Implement Stringable automatically for internal classes

Requiring all internal classes (including those from 3rd-party
extensions) to implement Stringable if they provide __toString()

Implement Stringable automatically for internal classes

Requiring all internal classes (including those from 3rd-party
extensions) to implement Stringable if they provide __toString()
is too error prone. Case in point, our _ZendTestClass test class
was not doing so, resulting in preloading test failures after
recent changes.

Instead we automatically implement Stringable, the same as we do
for userland classes. We still allow explicit implementations,
but ignore them (normally they would result in an error due to
duplicate interface implementation). Finally, we need to be
careful about not trying to implement Stringable on Stringable
itself.

In some cases this changes the interface order, in particular the
automatic Stringable implementation will now come first.

show more ...

Print array defaults in reflection

As a followup to f34114b1fb68302ad51929890d3fb2d9cbba024b print
the contents of arrays rather than just a generic "Array" marker.
Also drop the tru

Print array defaults in reflection

As a followup to f34114b1fb68302ad51929890d3fb2d9cbba024b print
the contents of arrays rather than just a generic "Array" marker.
Also drop the truncation on strings. As we no longer resolve
constants, there should be less concerns about printing very
large strings here. If someone thought it was a good idea to use
a 10k character strings as a default value in code, then it should
be fine for us to print it in reflection as well.

show more ...

Declare tentative return types for Zend (#7251)

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

Make some exception properties typed

Closes GH-6891

Get rid of private final methods (#6892)

Require stubs to declare return types for magic methods when possible

Closes GH-6376

Improve default value handling of Exception constructors

Closes GH-6166

Review the usage of apostrophes in error messages

Closes GH-5590

Make Exception::$previous a typed property

Exception::$previous is a private property, so we can add a type:

private ?Throwable $previous = null;

Make Exception::$trace typed array property

This is a private property, so we are allowed to add a type.
The new declaration of the property is:

private array $trace = [];

Make Exception::$trace typed array property

This is a private property, so we are allowed to add a type.
The new declaration of the property is:

private array $trace = [];

This ensures that Exception::getTrace() does indeed return an array.

Userland code that was modifying the property through refleciton
may have to be adjusted to assign an array (instead of null,
for example).

Closes GH-5636.

show more ...

Generate method entries from stubs for Zend classes

Closes GH-5459

Store default parameter values of internal functions in arg info

Closes GH-5353. From now on, PHP will have reflection information
about default values of parameters of internal function

Store default parameter values of internal functions in arg info

Closes GH-5353. From now on, PHP will have reflection information
about default values of parameters of internal functions.

Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

show more ...

Remove <default> prefix from reflection dump

This really doesn't add anything, and only makes for confusing
terminology. Only marking properties as dynamic is sufficient.

Define Stringable with __toString():string method

Add Zend class/interface arginfo stubs

We also change `Generator::throw()` to expect a `Throwable` in the
first place, and we now throw a TypeError instead of returning `false`
from

Add Zend class/interface arginfo stubs

We also change `Generator::throw()` to expect a `Throwable` in the
first place, and we now throw a TypeError instead of returning `false`
from `Exception::getTraceAsString()`.

show more ...

Revert removal of private __clone() methods

I thought these were redundant, because we already NULL out the
clone_obj object handler. However, it turns out that reflection is
using p

Revert removal of private __clone() methods

I thought these were redundant, because we already NULL out the
clone_obj object handler. However, it turns out that reflection is
using private __clone() to determine clonability (isCloneable) for
the case where we only have a class, rather than an object.

As such, removing these methods would be a BC break.

This reverts commit e7131a4e9fa0acf8fc1e486b49851e71859ef5b8.
This reverts commit 55bd88ce0d1bf461546d5d0b40920491d566ed48.

show more ...

Remove redundant Exception::__clone() method

Exceptions already prohibit cloning by setting clone_obj to NULL
(which is integrated with reflection). No need to additionally
define a

Remove redundant Exception::__clone() method

Exceptions already prohibit cloning by setting clone_obj to NULL
(which is integrated with reflection). No need to additionally
define a dummy __clone() method.

show more ...

Trim trailing whitespace in *.phpt

Trim trailing whitespace in *.phpt

Trim trailing whitespace in *.phpt

Trim trailing whitespace in tests

Use EXPECT instead of EXPECTF when possible

EXPECTF logic in run-tests.php is considerable, so let's avoid it.

Remove superfluous SKIPIF sections in more tests

fix test