Prevent possible incorrect optimization caused by ZEND_ASSUME()

Restore error message incorrectly removed by commit 10d43c4 (related to GH-15497)

Merge branch 'PHP-8.2' into PHP-8.3

* PHP-8.2:
Fixed GH-12494: Zend/tests/arginfo_zpp_mismatch.phpt causes a segfault withJIT + --repeat 2

Merge branch 'PHP-8.1' into PHP-8.2

* PHP-8.1:
Fixed GH-12494: Zend/tests/arginfo_zpp_mismatch.phpt causes a segfault withJIT + --repeat 2

Fixed GH-12494: Zend/tests/arginfo_zpp_mismatch.phpt causes a segfault withJIT + --repeat 2

Merge branch 'PHP-8.2'

* PHP-8.2:
Fix DOMElement::append() and DOMElement::prepend() hierarchy checks
Fix spec compliance error for DOMDocument::getElementsByTagNameNS
Fix

Merge branch 'PHP-8.2'

* PHP-8.2:
Fix DOMElement::append() and DOMElement::prepend() hierarchy checks
Fix spec compliance error for DOMDocument::getElementsByTagNameNS
Fix GH-11336: php still tries to unlock the shared memory ZendSem with opcache.file_cache_only=1 but it was never locked
Fix GH-11338: SplFileInfo empty getBasename with more than one slash

show more ...

Merge branch 'PHP-8.1' into PHP-8.2

* PHP-8.1:
Fix DOMElement::append() and DOMElement::prepend() hierarchy checks
Fix spec compliance error for DOMDocument::getElementsByTagName

Merge branch 'PHP-8.1' into PHP-8.2

* PHP-8.1:
Fix DOMElement::append() and DOMElement::prepend() hierarchy checks
Fix spec compliance error for DOMDocument::getElementsByTagNameNS
Fix GH-11336: php still tries to unlock the shared memory ZendSem with opcache.file_cache_only=1 but it was never locked
Fix GH-11338: SplFileInfo empty getBasename with more than one slash

show more ...

Fix GH-11336: php still tries to unlock the shared memory ZendSem with opcache.file_cache_only=1 but it was never locked

I chose to check for the value of lock_file instead of checking the

Fix GH-11336: php still tries to unlock the shared memory ZendSem with opcache.file_cache_only=1 but it was never locked

I chose to check for the value of lock_file instead of checking the
file_cache_only, because it is probably a little bit faster and we're
going to access the lock_file variable anyway. It's also more generic.

Closes GH-11341.

show more ...

Merge branch 'PHP-8.2'

* PHP-8.2:
Access violation when ALLOC_FALLBACK fixed

Merge branch 'PHP-8.1' into PHP-8.2

* PHP-8.1:
Access violation when ALLOC_FALLBACK fixed

Access violation when ALLOC_FALLBACK fixed

Close GH-11312

Merge branch 'PHP-8.2'

* PHP-8.2:
Fix allocation loop in zend_shared_alloc_startup()

Merge branch 'PHP-8.1' into PHP-8.2

* PHP-8.1:
Fix allocation loop in zend_shared_alloc_startup()

Fix allocation loop in zend_shared_alloc_startup()

The break is outside the if, so if it succeeds or not this will always
stop after the first loop iteration instead of trying more alloc

Fix allocation loop in zend_shared_alloc_startup()

The break is outside the if, so if it succeeds or not this will always
stop after the first loop iteration instead of trying more allocators if
the first one fails.

Closes GH-11306.

show more ...

ext/opcache/zend_shared_alloc: use memfd for locking if available

A memfd is a virtual file that has no reachable path, therefore does
not clobber any filesystem. It is deleted automati

ext/opcache/zend_shared_alloc: use memfd for locking if available

A memfd is a virtual file that has no reachable path, therefore does
not clobber any filesystem. It is deleted automatically as soon as
the last handle gets closed. The feature is available since Linux
kernel 3.17.

Closes GH-10589.

show more ...

Make lots of string pointers `const` (#10646)

This allows using string literals without implicitly casting away the
`const`.

ext/opcache/zend_shared_alloc: convert more `int` to `bool`

ext/opcache/zend_shared_alloc: `bool` fixups

Zend/zend_types.h: deprecate zend_bool, zend_intptr_t, zend_uintptr_t (#10597)

These types are standard C99.

For compatibility with out-of-tree extensions, keep the typedefs
in

Zend/zend_types.h: deprecate zend_bool, zend_intptr_t, zend_uintptr_t (#10597)

These types are standard C99.

For compatibility with out-of-tree extensions, keep the typedefs
in main/php.h.

show more ...

ext/opcache/zend_shared_alloc: rename _register_xlat_entry() params

The name "new" happens to be a C++ keyword, which was the my reason to
rethink those names.

The "xlat_table"

ext/opcache/zend_shared_alloc: rename _register_xlat_entry() params

The name "new" happens to be a C++ keyword, which was the my reason to
rethink those names.

The "xlat_table" is not only used to translate pointers for persisting
scripts to shared memory, but is also used to annoate pointers
(e.g. by the JIT to associate an op_array with its jit_extension).

The names "old" and "new" aren't good for that; often, there's nothing
"old" or "new" about them. It's actually a generic lookup table, and
"old" shall be named "key" (which it is called internally already),
and "new" is renamed to simply "value".

show more ...

ext/opcache/zend_shared_alloc: change "locked" check to assertion

Calling zend_shared_alloc() without holding the lock is always a bug,
not a fatal runtime error.

ext/opcache/zend_shared_alloc: add assertions on "locked" flag

Let the PHP process crash if a bug causes incorrect locking calls.

Fix high opcache.interned_strings_buffer causing shm corruption (#9260)

Get rid of duplicated rotr3 implementation (#8853)

ext/opcache: check mkstemp() return value right after the call (#8031)

Don't call fchmod(-1), which is not only wrong, but also clobbers
errno and sets it to EBADF, breaking the followin

ext/opcache: check mkstemp() return value right after the call (#8031)

Don't call fchmod(-1), which is not only wrong, but also clobbers
errno and sets it to EBADF, breaking the following errno access for
the log message.

show more ...