Make zend_call_function() failure handling consistent

This API had rather peculiar behavior in case the provided function
is not callable. For some types of failures, it would silently

Make zend_call_function() failure handling consistent

This API had rather peculiar behavior in case the provided function
is not callable. For some types of failures, it would silently
return FAILURE (e.g. a function does not exist), while for others
(e.g. a class does not exist) it would generate a warning. Depending
on what the calling code does, this can either result in silent
failure or duplicate errors.

This commit switches the contract such that zend_call_function()
always (*) succeeds, though that success might be in the form of
throwing an exception. Calling a non-callable will now consistently
throw an exception.

There are some rare callers that do want to ignore missing methods,
for legacy APIs that are specific with optional methods. For these
use cases a new zend_call_method_if_exists() API is provided.

Calling code generally does not need to explicitly check for and
report zend_call_function() failures -- it can rely on
zend_call_function() having already done so. However, existing
code that does check for failure should continue to work fine.

(*) The only exception to this is if EG(active) being false during
late engine shutdown. This is not relevant to most code, but code
running in destructors and similar may need to be aware of the
possibility.

show more ...

Remove assert_options() return value info

The ASSERT_CALLBACK value is not validated at all -- it's possible
to set it to an arbitrary value. As such, the function can also
return an

Remove assert_options() return value info

The ASSERT_CALLBACK value is not validated at all -- it's possible
to set it to an arbitrary value. As such, the function can also
return any value or type (even without outright abuse, the opcache
func info was wrong in that the return can be rcn, and the array
can be array_of_ref).

show more ...

Add many missing closing PHP tags to tests

Closes GH-5958

Default assert.exception to 1

Use EXPECT instead of EXPECTF when possible

echo "Done\n";
?>
?>
Fatal error: Uncaught ArgumentCountError: explode() expects at least 2 parameters, 0 given in [no active file]:0
$triggerNotice+

Use EXPECT instead of EXPECTF when possible

echo "Done\n";
?>
?>
Fatal error: Uncaught ArgumentCountError: explode() expects at least 2 parameters, 0 given in [no active file]:0
$triggerNotice++;
?>
throw new Exception();
?>
?>
?>
?>
-- Testing date_parse() function with unexpected characters in $date argument --
?>
?>
-- Testing mktime() function with Zero arguments --
?>
?>
?>
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done\n";
?>
?>
?>
?>
Arg value is: this is a string
?>
echo "Done";
?>
-- Testing posix_getgrgid() function with a negative group id --
echo "Done";
?>
-- Testing posix_getpgid() with negative pid --
echo "Done";
?>
-- Testing posix_getpwuid() function negative uid --
?>
echo "Done";
?>
-- Testing posix_kill() function with invalid signal --
echo "Done";
?>
-- Testing posix_strerror() function with invalid error number --
?>
-- Testing ReflectionMethod::getClosure() function with invalid object --
?>
?>
?>
-- Iteration 1 --
?>
?>
?>
echo "Done\n";
?>
echo"Done";
?>
echo "Done\n";
?>
echo "Done";
?>
-- Testing array_diff_assoc() function with zero arguments --
echo "Done";
?>
-- Testing array_diff() function with zero arguments --
-- Testing array_diff_key() function with less than expected no. of arguments --
?>
echo "Done"
?>
echo "Done";
?>
-- Iteration 1 --
echo "Done";
?>
-- Testing array_map() function with one less than expected no. of arguments --
echo "Done\n";
?>
--- Iteration 0 ---
echo"\nDone";
?>
?>
*** Variation with first two Arguments ***
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done";
?>
echo "Done\n";
?>
echo "Done";
?>
echo "Done"
?>
?>
-- Testing usort() with built-in 'cmp_function': strcasecmp() --
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done\n";
?>
--Iteration 1--
-- iteration 1 --
echo "Done\n";
echo "Done\n";
?>
*** Testing is_executable() on invalid files ***
echo "Done\n";
?>
echo "Done\n";
?>
*** Testing is_readable() on miscellaneous filenames ***
?>
echo "Done\n";
?>
*** Testing is_writable() with invalid filenames ***
?>
?>
echo "Done\n";
?>
?>
echo "Done\n";
?>
echo "Done\n";
?>
?>
?>
?>
?>
?>
?>
?>
-- Testing php_uname() function with invalid mode --
echo "Done\n";
?>
-- Iteration 1 --
echo "Done\n";
?>
-- Iteration 1 --
echo "Done\n";
?>

?>
*** Output for integer values ***
?>
lcg_value tests...
echo "Done\n";
?>
echo "Done\n";
?>
?>
echo "Done";
?>
-- Testing stream_set_timeout() function with a closed socket --
?>
-- Testing chr() function with no arguments --
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done\n"
?>
?>
*** Using heredoc string ***
echo "Done\n";
?>
?>
Basic test WITH undefined var for result arg
?>
Test string with array values and results array
?>
-- Testing printf() function with Zero arguments --
echo "Done\n";
?>
echo "Done\n";
?>
echo "Done";
?>
-- Iteration 1 --
-- Testing sscanf() function with more than expected no. of arguments --
echo "Done\n";
?>
echo "*** Done ***";
?>
echo "*** Done ***";
?>
?>
-- Testing strval() function with object which has not toString() method --
?>
-- Variations for two arguments --
echo "\nDone";
?>
?>
?>
-- Testing strptime() function on failure --
echo "Done\n";
?>

show more ...

Reindent phpt files

Remove special treatment of strings in asserts

This was deprecated in PHP 7.2 as part of
https://wiki.php.net/rfc/deprecations_php_7_2.

Sync leading and final newlines in *.phpt sections

This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in al

Sync leading and final newlines in *.phpt sections

This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.

According to POSIX, a line is a sequence of zero or more non-' <newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2

show more ...

Trim trailing whitespace in *.phpt

Trim trailing whitespace in tests

Deprecate assert() with string argument

Always return boolean from assert

Matches docs prototype

Reclassify E_STRICT notices

Per RFC https://wiki.php.net/rfc/reclassify_e_strict

While reviewing this, found that there are still three E_STRICTs
left in libraries - need to dis

Reclassify E_STRICT notices

Per RFC https://wiki.php.net/rfc/reclassify_e_strict

While reviewing this, found that there are still three E_STRICTs
left in libraries - need to discuss those.

show more ...

- Fix tests

Assert test cases