| #
da777d49 |
| 22-Feb-2023 |
Max Kellermann |
CODING_STANDARDS.md: add rules for bool/zend_result return types (#10630)
This guideline was mentioned on php-internals
(https://news-web.php.net/php.internals/119573).
|
| #
5bfd3fa4 |
| 20-Feb-2023 |
Max Kellermann |
CODING_STANDARDS.md: establish C99 as the implementation language (#10631)
PHP 8 switched to C99, but did not documented that anywhere.
After @derickr rejected a pull request on tim
CODING_STANDARDS.md: establish C99 as the implementation language (#10631)
PHP 8 switched to C99, but did not documented that anywhere.
After @derickr rejected a pull request on timelib
(https://github.com/derickr/timelib/pull/141#issuecomment-1386773784)
because my suggested change removed compile-time checks for
fixed-width integer types, pointing out that they are optional in the
C99 standard, @nikic disagreed with using `uint_least8_t` instead
(which is guaranteed to be available), stating that "We already make
extensive use of uint8_t, you can assume it exists"
(https://github.com/php/php-src/pull/10621#pullrequestreview-1304760668).
In order to avoid such confusion in the future, let's document this
architecture requirement.
show more ...
|
| #
12abb1f5 |
| 21-Oct-2022 |
George Peter Banyard |
[skip ci] Amend coding style (#9797)
- Drop irrelevant rule about // comments since PHP is C99 + GNU extensions
- Add rule about strlen() usage for constant string length calculation
[skip ci] Amend coding style (#9797)
- Drop irrelevant rule about // comments since PHP is C99 + GNU extensions
- Add rule about strlen() usage for constant string length calculation
- Minor stylistic changes
Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
show more ...
|
| #
5d37cd97 |
| 30-May-2021 |
Alex Dowad |
Improve documentation for contributors
|
| #
462da6e0 |
| 31-Mar-2021 |
Josh Soref |
Fix spelling and grammar mistakes
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@b6ba3e2#commitcomment-48946465
Fix spelling and grammar mistakes
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@b6ba3e2#commitcomment-48946465
The action reports that the changes in this PR would make it happy: jsoref@602417c
Closes GH-6822.
show more ...
|
| #
47579986 |
| 28-Jun-2020 |
Max Semenik |
Remove requirements for proto comments from CODING_STANDARDS
They've been made obsolete by .stub.php files and are often
outdated as they're not the source of truth.
|
|
Revision tags: php-7.3.13RC1, php-7.2.26RC1, php-7.4.0, php-7.2.25, php-7.3.12, php-7.4.0RC6, php-7.3.12RC1, php-7.2.25RC1, php-7.4.0RC5, php-7.1.33, php-7.2.24, php-7.3.11, php-7.4.0RC4, php-7.3.11RC1, php-7.2.24RC1 |
|
| #
8069e152 |
| 04-Oct-2019 |
tpfast |
Fix typo in CODING_STANDARDS.md [ci skip]
|
|
Revision tags: php-7.4.0RC3, php-7.2.23, php-7.3.10, php-7.4.0RC2, php-7.2.23RC1, php-7.3.10RC1, php-7.4.0RC1, php-7.1.32, php-7.2.22, php-7.3.9, php-7.4.0beta4, php-7.2.22RC1, php-7.3.9RC1, php-7.4.0beta2, php-7.1.31, php-7.2.21, php-7.3.8, php-7.4.0beta1, php-7.2.21RC1, php-7.3.8RC1, php-7.4.0alpha3, php-7.3.7, php-7.2.20, php-7.4.0alpha2, php-7.3.7RC3, php-7.3.7RC2, php-7.2.20RC2, php-7.4.0alpha1, php-7.3.7RC1, php-7.2.20RC1, php-7.2.19, php-7.3.6, php-7.1.30 |
|
| #
f45b61b8 |
| 18-May-2019 |
Peter Kokot |
[ci skip] Migrate Coding standards docs to Markdown
|
| #
fafcdc4d |
| 18-May-2019 |
Peter Kokot |
Move CODING_STANDARDS to CODING_STANDARDS.md
|
