Fix param name order for Phar::copy()

Don't return bool from Phar::offsetUnset()

This violates the ArrayAccess interface. Use offsetExists() to
check if an entry exists.

Fix Phar::offsetGet() return type

It's possible to change the returned type using setFileClass(),
which unfortunately only enforces that it's a subtype of
SplFileInfo, not PharFileIn

Fix Phar::offsetGet() return type

It's possible to change the returned type using setFileClass(),
which unfortunately only enforces that it's a subtype of
SplFileInfo, not PharFileInfo.

show more ...

Declare tentative return types for ext/phar (#7052)

Fix a few ext/phar return types

Generate class entries from stubs for phar, posix, pspell, readline, reflection, session, shmop

Closes GH-6692

Make Phar $fileNotFoundScript nullable

While "" is already treated the same way as absence, null is the
logically correct default here. Making this one argument non-nullable
is parti

Make Phar $fileNotFoundScript nullable

While "" is already treated the same way as absence, null is the
logically correct default here. Making this one argument non-nullable
is particularly pecular when considering that the preceding $alias
and $index arguments are both nullable.

show more ...

gen_stub: Also verify implementation-alias

This makes --verify also check @implementation-alias. Failures are
ignored using @no-verify instead. Some mistakes have been made that
woul

gen_stub: Also verify implementation-alias

This makes --verify also check @implementation-alias. Failures are
ignored using @no-verify instead. Some mistakes have been made that
would have been caught by this...

Closes GH-6615.

show more ...

Fix parameter name of PharData::getMetadata()

The name should be the same as for Phar::getMetadata().

Fix stub for Phar::setStub()

This fixes multiple issues:
* The first parameter may be resource|string.
* It's an overloaded signature. The second parameter cannot be
passed

Fix stub for Phar::setStub()

This fixes multiple issues:
* The first parameter may be resource|string.
* It's an overloaded signature. The second parameter cannot be
passed if the first one is a string. Use UNKNOWN default
value for that reason.
* Make parameter names in PharData::setStub() match those in
Phar.

Closes GH-6596.

show more ...

Update ext/phar parameter names

Closes GH-6307.

Make compression_type nullable in a few more places

Missed that this was also used elsewhere...

Make Phar $format and $compression arguments nullable

Rather than using Greg's birthday, use null to indicate that the
existing format/compression should be retained. For the format

Make Phar $format and $compression arguments nullable

Rather than using Greg's birthday, use null to indicate that the
existing format/compression should be retained. For the format
simply using zero would be sufficient, but as the documentation
explicitly says that NULL is allowed here, we may as well make
that the truth.

show more ...

Add support for `@implementation-alias` in stubs

Closes GH-6170

Fix UNKNOWN default values in various extensions

Closes GH-6075

Add more precise type info for stubs

Closes GH-6005

Promote warnings to exceptions in ext/phar

Closes GH-6008

Add another round of missing parameter types to stubs

Closes GH-5950

[RFC] Only unserialize Phar metadata when getMetadata() is called

In other words, don't automatically unserialize when the magic
phar:// stream wrappers are used.
RFC: https://wiki.p

[RFC] Only unserialize Phar metadata when getMetadata() is called

In other words, don't automatically unserialize when the magic
phar:// stream wrappers are used.
RFC: https://wiki.php.net/rfc/phar_stop_autoloading_metadata

Also, change the signature from `getMetadata()`
to `getMetadata(array $unserialize_options = [])`.
Start throwing earlier if setMetadata() is called and serialization threw.

See https://externals.io/message/110856 and
https://bugs.php.net/bug.php?id=76774

This was refactored to add a phar_metadata_tracker for the following reasons:
- The way to properly copy a zval was previously implicit and undocumented
(e.g. is it a pointer to a raw string or an actual value)
- Avoid unnecessary serialization and unserialization in the most common case
- If a metadata value is serialized once while saving a new/modified phar file,
this allows reusing the same serialized string.
- Have as few ways to copy/clone/lazily parse metadata (etc.) as possible,
so that code changes can be limited to only a few places in the future.
- Performance is hopefully not a concern - copying a string should be faster
than unserializing a value, and metadata should be rare in most cases.

Remove unnecessary skip in a test(Compression's unused)

Add additional assertions about usage of persistent phars

Improve robustness of `Phar*->setMetadata()`

- Add sanity checks for edge cases freeing metadata, when destructors
or serializers modify the phar recursively.
- Typical use cases of php have phar.readonly=1 and would not be affected.

Closes GH-5855

show more ...

Generate method entries from stubs for curl, ffi, pdo, phar

Closes GH-5375

Fix nullable types in PHPDoc

Verify that all stubs have a return type

Add proper return types to final phar methods

As these are final, we can add return types to them.

Add ext/phar arginfo stubs