#
fafa34d9 |
| 18-Nov-2023 |
Muhammad Moinur Rahman |
Add host_cpu type for FreeBSD In FreeBSD world x86_64 host type is identified as amd64 so add proper checks for FreeBSD amd64 hosts. Close GH-12736
|
Revision tags: php-8.1.7RC1, php-8.1.4RC1, php-8.1.3, php-8.1.2RC1, php-8.1.0, php-7.3.33, php-7.3.32, php-7.3.31, php-7.3.30, php-7.3.29 |
|
#
0e932f7c |
| 28-Jun-2021 |
Nikita Popov |
Don't directly include zend_jit_gdb.c Compile the file separately and only include a header. There doesn't seem to be a good reason to directly include the C file here, and this ensu
Don't directly include zend_jit_gdb.c Compile the file separately and only include a header. There doesn't seem to be a good reason to directly include the C file here, and this ensures that there are no symbol clashes (see GH-7197).
show more ...
|
Revision tags: php-7.3.28 |
|
#
0de94944 |
| 01-Apr-2021 |
Hao Sun |
Initial support of JIT/arm64 SUMMARY We implemented a prototype of PHP JIT/arm64. Briefly speaking, 1. build system Changes to the build system are made so that PHP JIT
Initial support of JIT/arm64 SUMMARY We implemented a prototype of PHP JIT/arm64. Briefly speaking, 1. build system Changes to the build system are made so that PHP JIT can be successfully built and run on ARM-based machine. Major change lies in file zend_jit_arm64.dasc, where the handler for each opcode is generated into machine code. Note that this file is just copied from zend_jit_x86.dasc and the *unimplemented* parts are substitued with 'brk' instruction for future work. 2. registers AArch64 registers are defined in file zend_jit_arm64.h. From our perspectives, the register usage is quite different from the x86 implementation due to the different ABI, number of registers and addressing modes. We had many confusions on this part, and will discuss it in details in the final section. 3. opcodes Several opcodes are partially supported, including INIT_FCALL, DO_UCALL, DO_ICALL, RETURN, ADD, PRE_INC, JMP, QM_ASSIGN, etc. Hence, simple use scenarios such as user function call, loops, addition with integer and floating point numbers can be supported. 18 micro test cases are added under 'ext/opcache/tests/jit/arm64/'. Note that majority of these test cases are design for functional JIT, and cases 'hot_func_*.phpt' and 'loop_002.phpt' can trigger tracing JIT. 4. test Our local test environment is an ARM-based server with Ubuntu 20.04 and GCC-10. Note that both HYBRID and CALL VM modes are supported. We suggest running the JIT test cases using the following command. Out of all 130 test cases, 66 cases can be passed currently. ``` $ make test TESTS='-d opcache.jit=1203 ext/opcache/tests/jit/' ``` DETAILS 1. I-cache flush Instruction cache must be flushed for the JIT-ed code on AArch64. See macro JIT_CACHE_FLUSH in file 'zend_jit_internal.h'. 2. Disassembler Add initialization and jump target parse operations for AArch64 backed. See the updates in file 'zend_jit_disasm.c'. 3. redzone Enable redzone for AArch64. See the update in zend_vm_opcodes.h. Redzone is designated to prevent 'vm_stack_data' from being optimized out by compilers. It's worth noting that this 16-byte redzone might be reused as temporary use(treated as extra stack space) for HYBRID mode. 4. stack space reservation The definitions of HYBRID_SPAD, SPAD and NR_SPAD are a bit tricky for x86/64. In AArch64, HYBRID_SPAD and SPAD are both defined as 16. These 16 bytes are pre-allocated for tempoerary usage along the exuection of JIT-ed code. Take line 4185 in file zend_jit_arm64.dasc as an example. NR_SPAD is defined as 48, out of which 32 bytes to save FP/IP/LR registers. Note that we choose to always reserve HYBRID_SPAD bytes in HYBRID mode, no matter whether redzone is used or not, for the sake of safety. 5. stack alignment In AArch64 the stack pointer should be 16-byte aligned. Since shadow stack is used for JIT, it's easy to guarantee the stack alignment, via simply moving SP with an offset like 16 or a multiple of 16. That's why NR_SPAD is defined as 48 and we use 32 of them to save FP/IP/LR registers which only occupies 24 bytes. 6. global registers x27 and x28 are reserved as global registers. See the updates in file zend_jit_vm_helpers.c 7. function prologue for CALL mode Two callee-saved registers x27 and x28 should saved in function zend_jit_prologue() in file zend_jit_arm64.dasc. Besides the LR, i.e. x30, should also be saved since runtime C helper functions(such as zend_jit_find_func_helper) might be invoked along the execution of JIT-ed code. 8. regset Minor changes are done to regset operations particularly for AArch64. See the updates in file zend_jit_internal.h. REGISTER USAGE In this section, we will first talk about our understanding on register usage and then demonstrate our design. 1. Register usage for HYBRID/CALL modes Registers are used similarly between HYBRID mode and CALL mode. One difference is how FP and IP are saved. In HYBRID mode, they are assigned to global registers, while in CALL mode they are saved/restored on the VM stack explicitly in prologue/epilogue. The other difference is that LR register should also be saved/restored in CALL mode since JIT-ed code are invoked as normal functions. 2. Register usage for functional/tracing JIT The way registers are used differs a lot between functional JIT and tracing JIT. For functional JIT, runtime C code (e.g. helper functions) would be invoked along the execution of JIT-ed code. As the operands for *most* opcodes are accessed via the stack slot, i.e. FP + offset. Hence there is no need to save/restore local(caller-saved) registers before/after invoking runtime C code. Exception lies in Phi node and registers might be allocated for these nodes. Currently I don't fully understand the reason, why registers are allocated for Phi functions, because I suppose for different versions of SSA variables at the Phi function, their postions on the stack slot should be identical(in other words, access via the stack slot is enough and there is no need to allocate registers). For tracing JIT, runtime information are recorded for traces(before the JIT compilation), and the data types and control flows are concrete as well. Hence it's would be faster to conduct operations and computations via registers rather than stack slots(as functional JIT does) for these collected hot paths. Besides, runtime C code can be invoked for tracing JIT, however this only happends for deoptimization and all registers are saved to stack in advance. 3. Candidates for register allocator 1) opcode candidates Function zend_jit_opline_supports_reg() determines the candidate opcodes which can use CPU registers. 2) register candidates Registers in set "ZEND_REGSET_FP + ZEND_REGSET_GP - ZEND_REGSET_FIXED - ZEND_REGSET_PRESERVED" are available for register allocator. Note that registers from ZEND_REGSET_FIXED are reserved for special purpose, such as the stack pointer, and they are excluded from register allocation process. Note that registers from ZEND_REGSET_PRESERVED are callee-saved based on the ABI and it's safe to not use them either. 4. Temporary registers Temporary registers are needed by some opcodes to save intermediate computation results. 1) Functions zend_jit_get_def_scratch_regset() and zend_jit_get_scratch_regset() return which registers might be clobbered by some opcodes. Hence register allocator would spill these scratch registers if necessary when encountering these opcodes. 2) Macro ZEND_REGSET_LOW_PRIORITY denotes a set of registers which would be allocated with low priority, and these registers can be used as temporary usage to avoid conflicts to its best. 5. Compared to the x86 implementation, in JIT/arm64 1) Called-saved FP registers are included into ZEND_REGSET_PRESERVED for AArch64. 2) We follow the logic of function zend_jit_opline_supports_reg(). 3) We reserve 4 GPRs and 2 FPRs out from register allocator and use them as temporary registers in particular. Note that these 6 registers are included in set ZEND_REGSET_FIXED. Since they are reserved, may-clobbered registers can be removed for most opcodes except for function calls. Besides, low-priority registers are defined as empty since all candidate registers are of the same priority. See the updates in function zend_jit_get_scratch_regset() and macro ZEND_REGSET_LOW_PRIORITY. 6. Why we reserve registers for temporary usage? 1) Addressing mode in AArch64 needs more temporary registers. The addressing mode is different from x86 and tempory registers might be *always* needed for most opcodes. For instance, an immediate must be first moved into one register before storing into memory in AArch64, whereas in x86 this immediate can be stored directly. 2) There are more registers in AArch64. Compared to the solution in JIT/x86(that is, temporary registers are reserved on demand, i.e. different registers for different opcodes under different conditions), our solution seems a coarse-granularity and brute-force solution, and the execution performance might be downgraded to some extent since the number of candidate registers used for allocation becomes less. We suppose the performance loss might be acceptable since there are more registers in AArch64. 3) Based on my understanding, scratch registers defined in x86 are excluded from candidates for register allocator with *low possibility*, and it can still allocate these registers. Special handling should be conducted, such as checking 'reg != ZREG_R0'. Hence, as we see it, it's simpler to reserve some temporary registers exclusively. See the updates in function zend_jit_math_long_long() for instance. TMP1 can be used directly without checking. Co-Developed-by: Nick Gasson <Nick.Gasson@arm.com>
show more ...
|
#
bf9dc534 |
| 05-May-2021 |
Nikita Popov |
Fixed bug #81007 Backport a change from the master branch. We usually test 32-bit using -m32 from an x86-64 host, probably nobody tried using an actual 32-bit host.
|
#
721bd973 |
| 27-Apr-2021 |
Dmitry Stogov |
Fixed CPU detection
|
Revision tags: php-7.3.27, php-7.3.26, php-7.3.26RC1, php-7.3.25, php-7.3.25RC1, php-7.3.24, php-7.3.24RC1 |
|
#
dcdc5d90 |
| 29-Sep-2020 |
George Peter Banyard |
Drop -Wno-implicit-fallthrough compiler flag And add it back to ext/date, ext/hash, and ext/opcache
|
#
f1ad9199 |
| 16-Apr-2021 |
Dmitry Stogov |
Better support for cross-compilation
|
#
617276d8 |
| 23-Mar-2021 |
Dmitry Stogov |
Use capstone disassembler, if available.
|
#
eaf9421d |
| 07-Mar-2021 |
Michael Heimpold |
ext/opcache: fix configure output while checking mmap MAP_ANON support It seems that f3efb9e3fb introduced a "typo" which may result in the following confusing message: checking
ext/opcache: fix configure output while checking mmap MAP_ANON support It seems that f3efb9e3fb introduced a "typo" which may result in the following confusing message: checking for mmap() using MAP_ANON shared memory support... no=yes Let's fix this. Signed-off-by: Michael Heimpold <mhei@heimpold.de> Closes GH-6758.
show more ...
|
#
83be073a |
| 26-Jan-2021 |
Nikita Popov |
Move optimizer into core This only moves the files, adjusts the build system, exports APIs and does minor fixups to make sure the code builds. This does not yet try to make the
Move optimizer into core This only moves the files, adjusts the build system, exports APIs and does minor fixups to make sure the code builds. This does not yet try to make the optimizer usable independently of opcache. Closes GH-6642.
show more ...
|
#
4633e70a |
| 24-Nov-2020 |
Nikita Popov |
Fixed bug #80377 Make sure the $PHP_THREAD_SAFETY variable is always available when configuring extensions. It was previously available for phpized extensions, but for in-tree builds
Fixed bug #80377 Make sure the $PHP_THREAD_SAFETY variable is always available when configuring extensions. It was previously available for phpized extensions, but for in-tree builds it was being set too late. Then, use $PHP_THREAD_SAFETY instead of $enable_zts to check for ZTS in bundled extensions, which makes sure these checks also work for phpize builds.
show more ...
|
#
7fc2a3e1 |
| 24-Nov-2020 |
Dmitry Stogov |
Revert "Fixed bug #80377" This reverts commit fc26ad9b1220fdfd7db15ecaff5e7c38283c55b6.
|
#
fc26ad9b |
| 24-Nov-2020 |
Nikita Popov |
Fixed bug #80377 Use $PHP_THREAD_SAFETY instead of $enable_zts to check for ZTS. This variable is also available for phpize builds, while enable_zts is only present for in-tree build
Fixed bug #80377 Use $PHP_THREAD_SAFETY instead of $enable_zts to check for ZTS. This variable is also available for phpize builds, while enable_zts is only present for in-tree builds.
show more ...
|
Revision tags: php-7.3.23, php-7.3.23RC1, php-7.3.22, php-7.3.22RC1, php-7.3.21 |
|
#
118fa69e |
| 25-Jul-2020 |
David Carlier |
Check for shm_open() in libroot to support Haiku Resides on libroot (system runtime) on this platform. Closes GH-5892.
|
Revision tags: php-7.3.21RC1, php-7.3.20, php-7.3.20RC1, php-7.3.19, php-7.4.7RC1, php-7.3.19RC1 |
|
#
f3efb9e3 |
| 22-May-2020 |
Tyson Andre |
Fail in `./configure` when no opcache shm backends exist This can be seen when the `./configure` step fails to detect `HAVE_SHM_*`, e.g. due to missing a necessary dependency to compile
Fail in `./configure` when no opcache shm backends exist This can be seen when the `./configure` step fails to detect `HAVE_SHM_*`, e.g. due to missing a necessary dependency to compile the test scripts. (Run `./configure`, run `yum install libtool-ltdl-devel` for missing dependencies, then run `make`, and php can end up built with 0 shared memory opcache caches) Give a clearer error message than `unknown` Searching for `opcache "Fatal Error Unable to allocate shared memory segment of" "unknown: No such file or directory"` reveals issues such as https://github.com/termux/termux-packages/issues/2234 Closes GH-5615
show more ...
|
Revision tags: php-7.3.18RC1, php-7.2.30, php-7.3.17, php-7.3.17RC1, php-7.3.18, php-7.3.16, php-7.3.16RC1 |
|
#
cf8407a2 |
| 17-Feb-2020 |
Dmitry Stogov |
Fixed bug #79255 (PHP cannot be compiled with enable JIT)
|
#
7a8f180b |
| 17-Feb-2020 |
Nikita Popov |
Revert "Fixed bug #79255 (PHP cannot be compiled with enable JIT)" This reverts commit de6984edd5ce7fa2b2f365b5ae770507ef42022d. Reverting to unbreak 32-bit CI.
|
#
de6984ed |
| 17-Feb-2020 |
Xinchen Hui |
Fixed bug #79255 (PHP cannot be compiled with enable JIT)
|
Revision tags: php-7.3.15RC1, php-7.3.15, php-7.3.14, php-7.3.14RC1, php-7.3.13, php-7.3.13RC1, php-7.2.26RC1, php-7.4.0, php-7.2.25, php-7.3.12, php-7.4.0RC6, php-7.3.12RC1, php-7.2.25RC1, php-7.4.0RC5, php-7.1.33, php-7.2.24, php-7.3.11, php-7.4.0RC4, php-7.3.11RC1, php-7.2.24RC1 |
|
#
e1362b3c |
| 07-Oct-2019 |
Remi Collet |
add librt for opcache
|
#
6cac8d5b |
| 02-Oct-2019 |
Dmitry Stogov |
Optimizer cleanup - all rules from pass2 moved to pass1 - all JMP unrelated rules from pass3 moved to pass1 - pass3 keeps only JMP optimization rules - pass2.c is removed - p
Optimizer cleanup - all rules from pass2 moved to pass1 - all JMP unrelated rules from pass3 moved to pass1 - pass3 keeps only JMP optimization rules - pass2.c is removed - pass1_5.c remaned to pass1.c ("_5" was related to PHP 5)
show more ...
|
Revision tags: php-7.4.0RC3, php-7.2.23, php-7.3.10, php-7.4.0RC2, php-7.2.23RC1, php-7.3.10RC1, php-7.4.0RC1, php-7.1.32, php-7.2.22, php-7.3.9, php-7.4.0beta4, php-7.2.22RC1, php-7.3.9RC1, php-7.4.0beta2, php-7.1.31, php-7.2.21, php-7.3.8, php-7.4.0beta1 |
|
#
6afc3ced |
| 18-Jul-2019 |
Peter Kokot |
Remove unused HAVE_SHM_MMAP_ZERO and HAVE_SHM_MMAP_FILE Closes GH-4424
|
Revision tags: php-7.2.21RC1, php-7.3.8RC1, php-7.4.0alpha3, php-7.3.7, php-7.2.20 |
|
#
9a3c8e51 |
| 28-Jun-2019 |
Peter Kokot |
Sync functions checks Removed unused checks: - mbsinit check removed, HAVE_MBSINIT removed (not used in php-src) - mempcpy check removed, HAVE_MEMPCPY removed (not used in php-src an
Sync functions checks Removed unused checks: - mbsinit check removed, HAVE_MBSINIT removed (not used in php-src) - mempcpy check removed, HAVE_MEMPCPY removed (not used in php-src anymore since 560ed89bfbb56526251e9bd2fbcb27e5932641d8 which uses PHP's own implementation) - strpncpy check removed, added via a8c9e893b6911c785f698d724b2ff61e7aebb737 and not used. - setpgid check removed since HAVE_SETPGID is not used Moved to a central configure.ac: - fpclass - mbrlen moved to configure.ac (since the HAVE_MBRLEN is used accross the php-src) - sigprocmask - getcwd - getwd - glob - strfmon - nice Duplicated checks removed: - gethostname - getlogin - getpwuid_r - socketpair - mprotect check simplified
show more ...
|
Revision tags: php-7.4.0alpha2 |
|
#
2079b098 |
| 23-Jun-2019 |
Peter Kokot |
Clean headers checks Some headers were checked multiple times in the main configure.ac file and in the bundled extensions or SAPIs themselves. Also many of these checks are then used
Clean headers checks Some headers were checked multiple times in the main configure.ac file and in the bundled extensions or SAPIs themselves. Also many of these checks are then used accross other extensions or SAPIs so a central configure.ac makes most sense for these checks.
show more ...
|
Revision tags: php-7.3.7RC3, php-7.3.7RC2, php-7.2.20RC2 |
|
#
7a236b67 |
| 17-Jun-2019 |
Dmitry Stogov |
Attempt to fix JIT on Mac OSX ZTS build
|
Revision tags: php-7.4.0alpha1, php-7.3.7RC1, php-7.2.20RC1, php-7.2.19, php-7.3.6, php-7.1.30, php-7.2.19RC1, php-7.3.6RC1 |
|
#
75fb7486 |
| 12-May-2019 |
Peter Kokot |
Normalize comments in *nix build system m4 files Normalization include: - Use dnl for everything that can be ommitted when configure is built in favor of the shell comment characte
Normalize comments in *nix build system m4 files Normalization include: - Use dnl for everything that can be ommitted when configure is built in favor of the shell comment character # which is visible in the output. - Line length normalized to 80 columns - Dots for most of the one line sentences - Macro definitions include similar pattern header comments now
show more ...
|