Fix the signature of PDOStatement::fetchObject()

The ?array $ctorArgs = null parameter is changed to array $constructorArgs = [], and an additional memory leak revealed by the new test case

Fix the signature of PDOStatement::fetchObject()

The ?array $ctorArgs = null parameter is changed to array $constructorArgs = [], and an additional memory leak revealed by the new test case is fixed.

Closes GH-6937

Co-Authored-By: Nikita Popov <nikita.ppv@gmail.com>

show more ...

Fix the default value of $mode in PDOStatement::fetch*()

Closes GH-6933

Fix PDOStatement::bindColumn() parameter default value

Fix PDOStatement::fetchObject() stub

Closes GH-6449.

Update PDO parameter names

Followup to previous changes:
* Use camel case, as PDO uses a camel case OO API.
* Use &$var instead of &$bind_var or &$param.
* Use $column instead

Update PDO parameter names

Followup to previous changes:
* Use camel case, as PDO uses a camel case OO API.
* Use &$var instead of &$bind_var or &$param.
* Use $column instead of $index. We have cases (both inside PDO
and in other DB exts) where columns can also be represented as
strings, so $column is the safer generic name.

Closes GH-6272.

show more ...

Update PDO parameters for named arguments.

Closes GH-6220

Make various failure conditions in PDO unconditional errors

This includes TypeErrors, ValueErrors, Error for uninitialized objects
and invalid user classes/callable instanciation

Make various failure conditions in PDO unconditional errors

This includes TypeErrors, ValueErrors, Error for uninitialized objects
and invalid user classes/callable instanciation

Closes GH-6212

show more ...

Display types in stubs more uniformly

In preparation for generating method signatures for the manual.

This change gets rid of bogus false|null return types, a few unnecessary traili

Display types in stubs more uniformly

In preparation for generating method signatures for the manual.

This change gets rid of bogus false|null return types, a few unnecessary trailing backslashes, and settles on using ? when possible for nullable types.

show more ...

Add more precise type info for stubs

Closes GH-6005

Use variadic signature for PDOStatement::fetchAll()

The current signature is incorrect, because the $ctor_args parameter
is not required to be an array (it can at least also be null, and

Use variadic signature for PDOStatement::fetchAll()

The current signature is incorrect, because the $ctor_args parameter
is not required to be an array (it can at least also be null, and
isn't enforced by an exception anyway).

I'm going for the variadic signature here, because we already use
the same variadic signature in PDO::query() and
PDOStatement::setFetchMode(), all of them accepting essentially the
same arguments.

show more ...

Add all the missing parameter types to stubs

Closes GH-5955

Add another round of missing parameter types to stubs

Closes GH-5950

Use zpp for PDO fetch mode

Also changing the function signatures to accept variadic args
for the fetch params. If we're already breaking Doctrine anyway,
we may as well do it properl

Use zpp for PDO fetch mode

Also changing the function signatures to accept variadic args
for the fetch params. If we're already breaking Doctrine anyway,
we may as well do it properly.

show more ...

Introduce InternalIterator

Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal class

Introduce InternalIterator

Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal classes: They can implement the internal
get_iterator mechanism, without exposing either the Iterator or
IteratorAggregate APIs. This makes them usable in get_iterator(),
but incompatible with any Iterator based APIs.

A lot of internal classes do this, because exposing the userland
APIs is simply a lot of work. This patch alleviates this issue by
providing a generic InternalIterator class, which acts as an
adapater between get_iterator and Iterator, and can be easily
used by many internal classes. At the same time, we extend the
requirement that Traversable implies Iterator or IteratorAggregate
to internal classes as well.

Closes GH-5216.

show more ...

Generate method entries from stubs for curl, ffi, pdo, phar

Closes GH-5375

Do not include the same stub multiple times

Closes GH-5322