Fix GH-8685 mbstring requires pcre

Fix GH-7902: mb_send_mail may delimit headers with LF only

Email headers are supposed to be separated with CRLF. Period.

We introduce a `CRLF` macro for better comprehensibility rig

Fix GH-7902: mb_send_mail may delimit headers with LF only

Email headers are supposed to be separated with CRLF. Period.

We introduce a `CRLF` macro for better comprehensibility right away.

Closes GH-7907.

show more ...

Fix #76167: mbstring may use pointer from some previous request

We must not reuse per-request memory across multiple requests, so this
check triggered during RINIT makes no sense. As ex

Fix #76167: mbstring may use pointer from some previous request

We must not reuse per-request memory across multiple requests, so this
check triggered during RINIT makes no sense. As explained in the bug
report[1], it can be even harmful, if some request startup fails, and
the pointers refer to already freed memory in the next request.

[1] <https://bugs.php.net/76167>

Closes GH-7604.

show more ...

Fix #81011: mb_convert_encoding removes references from arrays

We need to dereference references.

Closes GH-6938.

Fix incorrect zpp parameter count in mb_substr() / mb_strcut()

These functions only accept 4 params.

Fix argument nullability in mbstring

These arguments were declared nullable in stubs (and should be
nullable), but didn't accept null in zpp.

Consolidate the usage of "either" and "one of" in error messages

Closes GH-6173

Promote a few remaining errors in ext/standard

Closes GH-6110

Make mb_send_mail() consistent with mail()

The $additional_headers parameter shouldn't accept null.

Consolidate new union type ZPP macro names

They will now follow the canonical order of types. Older macros are
left intact due to maintaining BC.

Closes GH-6112

Throw ValueError on null bytes in mb_send_mail()

Instead of silently replacing with spaces.

mb_str_split is already documented on php.net

So remove TODO comment which implies that it's not.

Always use PCRE for mbstring.http_output_conv_mimetypes

Instead of using either oniguruma or pcre depending on which is
available. We always have PCRE, so use it. This ensures consistent

Always use PCRE for mbstring.http_output_conv_mimetypes

Instead of using either oniguruma or pcre depending on which is
available. We always have PCRE, so use it. This ensures consistent
behavior.

show more ...

Throw on invalid mb_http_input() type

Handle null encoding in mb_http_input()

Refactor mbfl_convert.c

Move custom type checks to ZPP

Closes GH-6034

Code cleanup in mbstring.c

Don't guard mbstring code with #ifdef HAVE_MBSTRING

This is just a very silly feature of mbstring -- you can compile the source files with
HAVE_MBSTRING undefined, and it will all just c

Don't guard mbstring code with #ifdef HAVE_MBSTRING

This is just a very silly feature of mbstring -- you can compile the source files with
HAVE_MBSTRING undefined, and it will all just compile to (almost) nothing. What is the
use of this? Why compile the source files and link against them if you don't want the
mbstring extension? It doesn't make any kind of sense.

show more ...

Remove redundant includes from mbstring (and make sure correct config.h is used)

Very interesting... it turns out that when Valgrind support was enabled,
`#include "config.h"` from withi

Remove redundant includes from mbstring (and make sure correct config.h is used)

Very interesting... it turns out that when Valgrind support was enabled,
`#include "config.h"` from within mbstring was actually including the file "config.h"
from Valgrind, and not the one from mbstring!!

This is because -I/usr/include/valgrind was added to the compiler invocation _before_
-Iext/mbstring/libmbfl.

Make sure we actually include the file which was intended.

show more ...

Fix typos in comments in mb_send_mail

Remove unused functions from mbstring

- mbfl_buffer_converter_reset
- mbfl_buffer_converter_strncat
- mbfl_buffer_converter_getbuffer
- mbfl_oddlen
- mbfl_filter_output_pipe_

Remove unused functions from mbstring

- mbfl_buffer_converter_reset
- mbfl_buffer_converter_strncat
- mbfl_buffer_converter_getbuffer
- mbfl_oddlen
- mbfl_filter_output_pipe_flush
- mbfl_memory_device_output2
- mbfl_memory_device_output4
- mbfl_is_support_encoding
- mbfl_buffer_converter_feed2
- _php_mb_regex_globals_dtor
- mime_header_encoder_feed
- mime_header_decoder_feed
- mbfl_convert_filter_feed

show more ...

Separate implementation of mb_{en,de}code_numericentity

Rather than using a magic boolean parameter to choose different behavior of
the subfunction, inline it. The code size doesn't real

Separate implementation of mb_{en,de}code_numericentity

Rather than using a magic boolean parameter to choose different behavior of
the subfunction, inline it. The code size doesn't really grow anyways. And
soon these will be trimmed down more.

show more ...

Use new-style argument parsing macros in mbstring.c

Inline unneeded indirection for mbstring memory management

All memory allocation and deallocation for mbstring bounces through a table of
function pointers before going to emalloc/efree/

Inline unneeded indirection for mbstring memory management

All memory allocation and deallocation for mbstring bounces through a table of
function pointers before going to emalloc/efree/etc. But this is unnecessary.
The allocators are never swapped out. Better to just call them directly.

show more ...