Fix #81739: OOB read due to insufficient validation in imageloadfont()

If we swap the byte order of the relevant header bytes, we need to make
sure again that the following multiplicatio

Fix #81739: OOB read due to insufficient validation in imageloadfont()

If we swap the byte order of the relevant header bytes, we need to make
sure again that the following multiplication does not overflow.

show more ...

Fix GH-8848: imagecopyresized() error refers to the wrong argument

Closes GH-8849.

add missing cond.

fix gdImagePngCtxEx call with system libgd

Fix #81032: GD install is affected by external libgd installation

This PR replaces the bundled libgd includes from #include <foo.h> with
#include "foo.h" for gd-related headers to avoid

Fix #81032: GD install is affected by external libgd installation

This PR replaces the bundled libgd includes from #include <foo.h> with
#include "foo.h" for gd-related headers to avoid including headers that
may be available in system directories instead of the expected local
headers.

Closes GH-6975.

show more ...

Return bool from imageinterlace()

The function accepts a bool since PHP 8.0, so it should also return
a bool to keep things consistent.

Furthermore a null return from this funct

Return bool from imageinterlace()

The function accepts a bool since PHP 8.0, so it should also return
a bool to keep things consistent.

Furthermore a null return from this functions is not possible.

show more ...

Mark resource-like objects as non-comparable

As these hold on to some internal resource, there can't be two
"equal" objects with different identity. Make sure the lack of
public prop

Mark resource-like objects as non-comparable

As these hold on to some internal resource, there can't be two
"equal" objects with different identity. Make sure the lack of
public properties doesn't result in these being treated as always
equal.

show more ...

Properly check imagegd() signature

Unlike imagegd2(), this function only accepts two parameters,
so we should be checking for that.

Make imagegd $file parameter nullable

It is explicitly documented to be nullable, and this matches other
functions like imagepng. It is also documented to accept a stream,
which it c

Make imagegd $file parameter nullable

It is explicitly documented to be nullable, and this matches other
functions like imagepng. It is also documented to accept a stream,
which it currently does not...

show more ...

Don't throw from imagecreatefromstring() with too short string

If the string is too short, we should treat this the same way as
an unrecognized image type. This function should be usable

Don't throw from imagecreatefromstring() with too short string

If the string is too short, we should treat this the same way as
an unrecognized image type. This function should be usable to
determine whether something is a valid image without doing any
checks beforehand.

show more ...

Don't allow properties on GdImage

Just like all the other former resources... we missed this case.

Fix null foreground in imagewbmp

The variable was not actually passed to zpp...

Update ext/gd parameter names

Closes GH-6308.

Add test instantiating all objects

Intended to find issues in opaque object destructors.

Closes GH-6251.

Consolidate the usage of "either" and "one of" in error messages

Closes GH-6173

Fix UNKNOWN default values in various extensions

Closes GH-6075

Promote warnings to exceptions in ext/gd

Closes GH-6023

Fix the default value handling of imagegif()

Fix UNKNOWN default values in ext/mbstring and ext/gd

Closes GH-5598

Explode _php_image_output_ctx() into multiple functions

Closes GH-5844

Export php_gd_libgdimageptr_from_zval_p()

Some extension may need to retrieve the `gdImagePtr` from an `GdImage`
object; thus, we export the respective function. To not being forced

Export php_gd_libgdimageptr_from_zval_p()

Some extension may need to retrieve the `gdImagePtr` from an `GdImage`
object; thus, we export the respective function. To not being forced
to include gd.h in php_gd.h, we use the opaque `struct gdImageStruct *`
as return type.

We also rename php_gd2.dll to php_gd.dll, since there's not really much
point in giving the DLL a version number, since there is no php_gd.dll
for years (if there ever has been). Renaming, on the other hand,
matches the name on other systems (gd.so), and allows to actually use
`ADD_EXTENSION_DEP()`.

show more ...

Review the usage of apostrophes in error messages

Closes GH-5590

Remove proto comments from C files

Closes GH-5758

Use ZEND_UNREACHABLE() instead of ZEND_ASSERT(0)

Instead of marking unreachable code with `ZEND_ASSERT(0)`, we introduce
`ZEND_UNREACHABLE()`, so that MSVC which does not consider `asser

Use ZEND_UNREACHABLE() instead of ZEND_ASSERT(0)

Instead of marking unreachable code with `ZEND_ASSERT(0)`, we introduce
`ZEND_UNREACHABLE()`, so that MSVC which does not consider `assert(0)`
to mark unreachable code does no longer trigger C4715[1] warnings in
debug builds. This may be useful for other compilers as well.

[1] <https://docs.microsoft.com/de-de/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4715?view=vs-2019>

show more ...

Fix [-Wundef] warning in GD extension