Fixed bug #80719

Fix bug #67369 ArrayObject serializatino drops the iterator class

When ArrayObject is round-tripped through serialize() and unserialize(),
it forgets any iterator class name which was se

Fix bug #67369 ArrayObject serializatino drops the iterator class

When ArrayObject is round-tripped through serialize() and unserialize(),
it forgets any iterator class name which was set using ::setIteratorClass().
Fix that.

show more ...

Fix #69264: __debugInfo() ignored while extending SPL classes

We actually implement `::__debugInfo()` and drop the `get_debug_info()`
handlers of all relevant SPL classes. This is clean

Fix #69264: __debugInfo() ignored while extending SPL classes

We actually implement `::__debugInfo()` and drop the `get_debug_info()`
handlers of all relevant SPL classes. This is cleaner and gives more
flexibility regarding overriding the functionality in descendant
classes.

show more ...

Fixed bug #78409

This removes an incorrect optimization (I think this code used to be
necessary to properly handle references in the Serializable based
implementation, but now this c

Fixed bug #78409

This removes an incorrect optimization (I think this code used to be
necessary to properly handle references in the Serializable based
implementation, but now this code just avoids an array duplication
in a way that is not sound).

show more ...

Replace ZVAL_COPY() and ZVAL_COPY_VALUE() for IS_OBJECT by cheaper macros

Fixed some arg infos to match documentation

Correctly destroy reference in ArrayObject sort

The reference may be captured in an exception backtrace, in which
case the refcount may be more than one.

Fix bug #77866: Port Serializable SPL classes to use __unserialize()

Payloads created using Serializable are still supported.

Fixed bug #77633

Add a new class flag to inherit get_iterator() when implementing
the Iterator/IteratorAggregate interfaces and use it for
ArrayIterator.

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...

Remove yearly range from copyright notice

Implement typed properties

RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwe

Implement typed properties

RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwei9@hotmail.com>
Co-authored-by: Joe Watkins <krakjoe@php.net>
Co-authored-by: Dmitry Stogov <dmitry@zend.com>

show more ...

Fix #77298: segfault occurs when add property to unserialized empty ArrayObject

Use ZEND_THIS macro to hide implementation details in extensions code.

Replace getThis() by EX(This), when additional check is not necessary.

Micro optimizations

Restore array_key_exists() compatibility for ArrayObject

Doing this by special-casing array_key_exists() for ArrayObject.

More straightforward count() on ArrayObject with object

Just writing this out as an explicit loop is both simpler and faster
than going through the entire positioning machinery.

Remove unnecessary get_hash_table return value checks

An ArrayObject always has a valid backing hashtable, this function
can never return NULL.

Don't overload get_properties for ArrayObject

Instead overload get_properties_for for a few specific cases such
as array casts. This resolves the issue where ArrayObject
get_properti

Don't overload get_properties for ArrayObject

Instead overload get_properties_for for a few specific cases such
as array casts. This resolves the issue where ArrayObject
get_properties may violate engine invariants in some cases.

show more ...

Removed useless IS_UNDEF checks

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
use

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.

show more ...

Give a meaningful name

Improved user iterator implementation to reduce zend_class_entry memory consumption and avoid race condition during resolving/caching of user iterator functions of internal classes in ZTS build.

Uze ZVAL_COPY_DEREF() instead of ZVAL_DEREF() and ZVAL_COPY()