#
7f9b534e |
| 26-Mar-2020 |
Lukas Berger |
Add missing 'skip' to bug79332.phpt skip message The skip message must start with the word 'skip', otherwise the test will not be skipped. *Before:* Running selected tests.
Add missing 'skip' to bug79332.phpt skip message The skip message must start with the word 'skip', otherwise the test will not be skipped. *Before:* Running selected tests. TEST 1/1 [ext/com_dotnet/tests/bug79332.phpt] ========DIFF======== 001+ Fatal error: Uncaught Error: Class 'COMPersistHelper' not found in /srv/php/ext/com_dotnet/tests/bug79332.php:2 001- A com_exception has been thrown 002+ Stack trace: 003+ #0 {main} 004+ thrown in /srv/php/ext/com_dotnet/tests/bug79332.php on line 2 ========DONE======== FAIL Bug #79332 (php_istreams are never freed) [ext/com_dotnet/tests/bug79332.phpt] *After:* Running selected tests. SKIP Bug #79332 (php_istreams are never freed) [ext/com_dotnet/tests/bug79332.phpt] reason: com_dotnet extension not available
show more ...
|
#
2adf1c4d |
| 02-Mar-2020 |
Christoph M. Becker |
Fix #79332: php_istreams are never freed Releasing the `com_dotnet_istream_wrapper` in `istream_destructor()` is pointless, since `istream_destructor()` is only called when the resou
Fix #79332: php_istreams are never freed Releasing the `com_dotnet_istream_wrapper` in `istream_destructor()` is pointless, since `istream_destructor()` is only called when the resource is going to be released. This recursion is not a real issue, though, since the resource is never exposed to userland, and has at most refcount 1, so due to well defined unsigned integer underflow, it never is released twice. However, returning early in this case causes a memory leak which needs to be fixed.
show more ...
|