Replace languages.inc globals with I18n\Languages consts (#1121)

The include/languages.inc file was not removed as it's used in other
repositories. It should be removed after migration.

Replace languages.inc globals with I18n\Languages consts (#1121)

The include/languages.inc file was not removed as it's used in other
repositories. It should be removed after migration.

Tests were added to ensure that the global variables and the constants
are in sync with each other.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>

show more ...

Fix: Remove unused functions (#585)

Fix: Remove emacs instruction (#876)

Enhancement: Enable `trailing_comma_in_multiline` fixer (#647)

* Enhancement: Enable and configure trailing_comma_in_multiline fixer

* Fix: Run 'make coding-standards'

Enhancement: Enable `void_return` fixer (#661)

* Enhancement: Enable void_return fixer

* Fix: Run 'make coding-standards'

Simplify links (#580)

Enhancement: Enable `binary_operator_spaces` fixer

Closes GH-667.

Enhancement: Enable `array_syntax` fixer

Co-authored-by: MathiasReker <mathias@reker.dk>

Closes GH-659.

Fix CS violations (case of null, false and true)

Enhancement: Include `*.inc` files (with exceptions)

Closes GH-662.

Micro Optimizations - Round #2

* .gitignore: Remove redundant entry

* Minor optimizations with ternary operators

* Use `const` instead of `define()` where appropriate

Micro Optimizations - Round #2

* .gitignore: Remove redundant entry

* Minor optimizations with ternary operators

* Use `const` instead of `define()` where appropriate

`const` is quite faster because of the compile-time optimizations. Because the replaced statements are not declaring constant conditionally, it's safe to use `const` in all of these places.

Closes GH-608.

show more ...

Multiple micro-optimizations

* Replace `ob_get_contents();ob_clean()` with `ob_get_clean()`

`ob_get_clean()` is equivalent to `ob_get_contents()` followed by `ob_clean()`.

Multiple micro-optimizations

* Replace `ob_get_contents();ob_clean()` with `ob_get_clean()`

`ob_get_clean()` is equivalent to `ob_get_contents()` followed by `ob_clean()`.

* Replace `intval()` calls with `(int)` type cast

This is a micro-optimization because `intval()` is a function call, and the type cast is about 6 times fast.

* Replace `preg_replace` call that could be done with an `rtrim()` call

In `./error.php`, there is a `preg_replace('!/+$!', '', $URI);` call that essentially is equivalent to `rtrim()`, that both calls removing trailing slash characters in `$URI`.
The `rtim()` call is more legible and faster.

* Combine consecutive `str_replace` calls to a single `str_replace` call

* Use short ternary operator where possible

Improves code readability.

* Cascade various `else` statements where possible

Cleans up the code by removing unnecessary `else` blocks and moving the code to the parent context if the previous `if` block exits the function by either terminating the script, or with a `return` statement.

* Combine multiple `isset()` calls to a single `isset()`

`isset()` accepts multiple parameters and returns `true` only if all of the parameters are `isset`. It makes sense to combine multiple individual `isset` calls to a single call for better readability.

* Replace `for` loop with a `foreach` loop

* Remove unnecessary character escapes in regular expressions

Regular expression special characters are context-sensitive. For example, special characters such as `.` are not considered special within square braces (`[]`).
This removes several of such instances that certain characters are escaped, but it is not strictly necessary within the context. This improves the readability of the expression.

See more information at [PHP.Watch: Writing better Regular Expressions in PHP](https://php.watch/articles/php-regex-readability#reduce-escape)

* Remove unnecessary break statement

* Remove unnecessary PHP close tags

* Remove redundant JSON_ERROR_NONE check

Remove unnecessary `json_last_error() == JSON_ERROR_NONE` where the decoded object is inspected already.

Closes GH-603.

show more ...

Remove old countries lists (#569)

Remove fetch_contents and fetch_header (#566)

Remove mirroiring stats (#405)

Mirrors have been retired

Swap uses of _SERVER[DOCUMENT_ROOT] for __DIR__

1/n - Update / and /include/ only.

Remove references, redirects, and selection of mirrors

https://www.php.net is the canonical web site address now

This change is needed so that https://www.php.net/git-php.php does not end up
in a redirect loop.

Sync final and leading newlines

This patch adds some missing newlines, trims some multiple redundant
final newlines into a single one, and trims few redundant leading
newlines.

Sync final and leading newlines

This patch adds some missing newlines, trims some multiple redundant
final newlines into a single one, and trims few redundant leading
newlines.

According to POSIX, a line is a sequence of zero or more non-'<newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2

show more ...

Trim trailing whitespace

This patch cleans all redundant trailing whitespace across the
repository except for the icalendar files.

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
use

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.

show more ...

Fix XSS reported by Francisco Alonso @ Red Hat Product Security

Revert "Attempt to fix the php.net cross-domain issues once and for all."

This reverts commit d89cf4ec47214e5d2494ced23a732a8861695360.

Attempt to fix the php.net cross-domain issues once and for all.

(But this is a terrible hac...)

ONCE AND FOR ALL.

Also remove XHTML from .inc files