Remove magic_quotes filter handling

The magic quotes filter is now disabled.

Finish migration to safe queries

Fix a typo

Migrate more code to safe query abstraction

Getting closer to done...

Move more queries to safe abstraction

Add a Query class to assemble queries by parts, and ?int placeholder
which is needed for LIMIT clauses.

Remove alerts functionality

This was never used, and is in a broken state right now (references
an incorrect database schema).

It seems rather unlikely that this functionality i

Remove alerts functionality

This was never used, and is in a broken state right now (references
an incorrect database schema).

It seems rather unlikely that this functionality is going to be
finished at this point, so instead drop it entirely.

show more ...

Add safe(r) query abstraction

Add db_query_safe that accepts parameters separately. Use it in
some places.

Don't handle full_special_chars default.filter

default.filter on this server is set to magic_quotes, so remove
the handling for the full_special_chars case.

Remove get_magic_quotes_gpc() checks

master.php.net runs PHP 5.4, where magic quotes no longer exist.
Add a sanity check that they're really disable, and drop code
handling them. The

Remove get_magic_quotes_gpc() checks

master.php.net runs PHP 5.4, where magic quotes no longer exist.
Add a sanity check that they're really disable, and drop code
handling them. There was at least one use of escape() that wouldn't
do the right thing if this code was run with magic quotes.

show more ...

A bit of PHP 7.4/8.0 cleanup

Final attempt to fix pagination?

Push temporary hidden debug message to help resolve pagination issue

Notes: fixing pagination requires one more change

Notes: fix pagination

I feel like this empty() check is also incorrect in other places but I
don't know how to reproduce the potential issue so maybe better it's
to not touch it.

Notes: display voting stats on a separate page

Perhaps it's handy for some people but nowadays amount of records it has
to query made the main notes page load a couple of seconds so let'

Notes: display voting stats on a separate page

Perhaps it's handy for some people but nowadays amount of records it has
to query made the main notes page load a couple of seconds so let's live
with having it one click away.

show more ...

Notes: sort out view=notes vs view=notes

It looks like the actual value of view doesn't change anything, only its
presence matters. However, if we are going to ever use that in the
f

Notes: sort out view=notes vs view=notes

It looks like the actual value of view doesn't change anything, only its
presence matters. However, if we are going to ever use that in the
future it's better to have it consistent.

Plus it simply bothered me :)

show more ...

Refactor long array() syntax to short []

Since app is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`.

Allow to search notes within a specfified section

Only show link if user can use it

Paginate note search results instead of showing last 20

Use native search form supported by web-shared

Add heading for current view

I misread the schema. arating is the key here.

Order by 'up' which is the sum of all 1 and -1 votes. The 'rate' feels a bit bogus, so let's skip it when finding good/bad notes

enforce types for numeric vars