Directly check token for rpc.php

Make this code independent of user authentication by checking
for a hardcoded token.

Convert all tabs to spaces

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classe

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classes and additionally provides retrieving of configuration parameters.
Service classes are used everywhere in the app - from accessing database
to uploading files. Configuration parameters include infrastructure
configuration (database credentials...) and application level
configuration (directories locations...).

Container is compatible with the PSR-11 container interface defined
so it is simple to quickly understand its usage. Advanced features
such as autowiring are not included in this phase.

show more ...

Minor cleanup

Refactor bugs_get_bug() to repository

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
s

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
syntax on some places.

show more ...

Add note about rpc.php

Refactor PDO wrapper to not depend on MDB2 anymore

The Bug_PDO is a thin PDO wrapper not dependant on the MDB2 anymore.

The rpc.php page included some old MDB2::errorMessage() usage

Refactor PDO wrapper to not depend on MDB2 anymore

The Bug_PDO is a thin PDO wrapper not dependant on the MDB2 anymore.

The rpc.php page included some old MDB2::errorMessage() usage which is
now refactored differently using only PDO way and current errors
handling.

show more ...

Trim trailing whitespace

Hopefully last round of fixes for missing session_start() calls, also fixes a poor call to redirect() in login.php

Authenticate before each call to the header, this should probably be done in the header function anyway.

Fixes some navigational links only showing on certain pages

- Fixed mail information and bug email change on automatic bug closing

- Fixed mail author in the automatic bug closing

- Fix missing assignment

- Fixed bug #63068 (Auto bug closing via commit messages don't update the bug history)

- Send a mail notification when automatically closing a bug report

- Added option to close bug by using POST param status=Closed

- Added bug access checks

- Added list of security developers
- Changed bugs_authenticate function
new prototype: (&$user, &$pw, &$logged_in, &$user_flags)

$user_flags:
define('BUGS_NORMAL_USER', 1<<

- Added list of security developers
- Changed bugs_authenticate function
new prototype: (&$user, &$pw, &$logged_in, &$user_flags)

$user_flags:
define('BUGS_NORMAL_USER', 1<<0);
define('BUGS_DEV_USER', 1<<1);
define('BUGS_TRUSTED_DEV', 1<<2);
define('BUGS_SECURITY_DEV', 1<<3);

show more ...

ws

- Rename to avoid unnecessary symlink