Convert all tabs to spaces

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classe

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classes and additionally provides retrieving of configuration parameters.
Service classes are used everywhere in the app - from accessing database
to uploading files. Configuration parameters include infrastructure
configuration (database credentials...) and application level
configuration (directories locations...).

Container is compatible with the PSR-11 container interface defined
so it is simple to quickly understand its usage. Advanced features
such as autowiring are not included in this phase.

show more ...

Replace deprecated Text_Diff PEAR package with Horde Text_Diff

This patch replaces obsolete Text_Diff PEAR package with newer and still
maintained Horde Text_Diff version 2.2.0 as sugges

Replace deprecated Text_Diff PEAR package with Horde Text_Diff

This patch replaces obsolete Text_Diff PEAR package with newer and still
maintained Horde Text_Diff version 2.2.0 as suggested in the packages
descriptions.

Since bugs.php.net production is not ready for Composer installations yet,
the Text_Diff package is bundled in the Git repository directly. Its
classes are not compliant with PSR-4 yet so the classmap has been used
until future PSR-4 migration and refactorings.

show more ...

Minor cleanup

Refactor bugs_get_bug() to repository

Refactor get_pseudo_packages() to repository class

Changes:
- get_pseudo_packages() function is moved to its own repository class.
- Database::queryAll() removed since it is not used

Refactor get_pseudo_packages() to repository class

Changes:
- get_pseudo_packages() function is moved to its own repository class.
- Database::queryAll() removed since it is not used and the method
arguments don't match the number of used arguments anymore
- Project types configuration is moved to repository class for now.
- Some unused items removed
- Some template changes and show_project_options() helper function
integrated in the view layer directly since it is used in a simplified
way.

show more ...

Refactor patches uploading

This patch moves patches uploading functionality from the outdated
HTTP_Upload package to a dedicated service class in the app.

Additional changes in

Refactor patches uploading

This patch moves patches uploading functionality from the outdated
HTTP_Upload package to a dedicated service class in the app.

Additional changes in this context:
- Functionality concerning retrieving patches data from database has
been moved to a separate repository classes.
- Some missed bugs fixed when uploading patches and no developer info
were recorded.
- Obsoleting patches functionality is now working again.
- Added a simple unit test.

show more ...

Fix patch display

Hopefully last round of fixes for missing session_start() calls, also fixes a poor call to redirect() in login.php

Authenticate before each call to the header, this should probably be done in the header function anyway.

Fixes some navigational links only showing on certain pages

Remove dependency on PEAR_HTTP

- Missing project type information

- Added missing session_start()

- Added bug access checks

- Added list of security developers
- Changed bugs_authenticate function
new prototype: (&$user, &$pw, &$logged_in, &$user_flags)

$user_flags:
define('BUGS_NORMAL_USER', 1<<

- Added list of security developers
- Changed bugs_authenticate function
new prototype: (&$user, &$pw, &$logged_in, &$user_flags)

$user_flags:
define('BUGS_NORMAL_USER', 1<<0);
define('BUGS_DEV_USER', 1<<1);
define('BUGS_TRUSTED_DEV', 1<<2);
define('BUGS_SECURITY_DEV', 1<<3);

show more ...

- Rename to avoid unnecessary symlink