GH-114: Lock down bug tracker to developers only

All further conversation about bugs is supposed to happen on Github.
We still allow developers to edit the bug tracker, so they can clean

GH-114: Lock down bug tracker to developers only

All further conversation about bugs is supposed to happen on Github.
We still allow developers to edit the bug tracker, so they can clean
up.

We start by disallowing users to add patches.

show more ...

Fix #62088: Missing changelog entry when adding patch

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classe

Add dependency injection container

This patch introduces a dependency injection container for the PHP bug
tracker application. Container deals with the creation of all service
classes and additionally provides retrieving of configuration parameters.
Service classes are used everywhere in the app - from accessing database
to uploading files. Configuration parameters include infrastructure
configuration (database credentials...) and application level
configuration (directories locations...).

Container is compatible with the PSR-11 container interface defined
so it is simple to quickly understand its usage. Advanced features
such as autowiring are not included in this phase.

show more ...

Minor cleanup

Refactor bugs_get_bug() to repository

Refactor patches uploading

This patch moves patches uploading functionality from the outdated
HTTP_Upload package to a dedicated service class in the app.

Additional changes in

Refactor patches uploading

This patch moves patches uploading functionality from the outdated
HTTP_Upload package to a dedicated service class in the app.

Additional changes in this context:
- Functionality concerning retrieving patches data from database has
been moved to a separate repository classes.
- Some missed bugs fixed when uploading patches and no developer info
were recorded.
- Obsoleting patches functionality is now working again.
- Added a simple unit test.

show more ...

Add dual PSR-4 compatible classes autoloader

This patch is a workaround until Composer installation step can be used
in production bugs.php.net. Once Composer can be added to the deploym

Add dual PSR-4 compatible classes autoloader

This patch is a workaround until Composer installation step can be used
in production bugs.php.net. Once Composer can be added to the deployment
step together with rsync this can be simplified and only Composer's
autoload.php will be used.

show more ...

Refactor numerical Captcha package into class

The Text_CAPTCHA_Numeral can be integrated in the project source code
instead of using a separate unmaintained dependency.

This pat

Refactor numerical Captcha package into class

The Text_CAPTCHA_Numeral can be integrated in the project source code
instead of using a separate unmaintained dependency.

This patch also adds a simple unit test.

show more ...

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
s

Refactor long array() syntax to short []

Since site is using PHP 5.4+ already, the longer `array()` syntax can be
refactored to shorter `[]`. Also code is already using short array
syntax on some places.

show more ...

Trim trailing whitespace

Authenticate before each call to the header, this should probably be done in the header function anyway.

Fixes some navigational links only showing on certain pages

Exit script execution directly in redirect()

- The end of an era - switch "Bogus" to "Not a bug" by popular demand
- Switch back to master
- Add site_method to make it easier to install on non-ssl test sites

Name can be passed in $_GET['patchname']

load/link everything from https

- Added list of security developers
- Changed bugs_authenticate function
new prototype: (&$user, &$pw, &$logged_in, &$user_flags)

$user_flags:
define('BUGS_NORMAL_USER', 1<<

- Added list of security developers
- Changed bugs_authenticate function
new prototype: (&$user, &$pw, &$logged_in, &$user_flags)

$user_flags:
define('BUGS_NORMAL_USER', 1<<0);
define('BUGS_DEV_USER', 1<<1);
define('BUGS_TRUSTED_DEV', 1<<2);
define('BUGS_SECURITY_DEV', 1<<3);

show more ...

- Added bugs_has_access() function to simplify the user access check to bug data

- Spam more people about added patches

- Remove unnecessary parameter

- Added function for adding comments

captcha answer can be 0, so changing empty to isset (thanks Yawk)

Disable @php.net emails for those without (and not logged in)

Fixed captcha logic to fail without sessions; logged in users need not apply

- Rename to avoid unnecessary symlink