#
9d47b05f |
| 22-May-2019 |
Peter Kokot |
Convert all tabs to spaces
|
#
5cd2630a |
| 24-Dec-2018 |
Peter Kokot |
Add dependency injection container This patch introduces a dependency injection container for the PHP bug tracker application. Container deals with the creation of all service classe
Add dependency injection container This patch introduces a dependency injection container for the PHP bug tracker application. Container deals with the creation of all service classes and additionally provides retrieving of configuration parameters. Service classes are used everywhere in the app - from accessing database to uploading files. Configuration parameters include infrastructure configuration (database credentials...) and application level configuration (directories locations...). Container is compatible with the PSR-11 container interface defined so it is simple to quickly understand its usage. Advanced features such as autowiring are not included in this phase.
show more ...
|
#
14f8c07a |
| 14-Dec-2018 |
Peter Kokot |
Refactor PDO wrapper Some considerations were raised on the mailing list that this PHP application doesn't need a PDO wrapper at all. Changes: - ::fetchRow() method removed
Refactor PDO wrapper Some considerations were raised on the mailing list that this PHP application doesn't need a PDO wrapper at all. Changes: - ::fetchRow() method removed in favor of the vanilla PDOStatement::fetch() - ::fetchAll() override removed in favor of the vanilla PDOStatement::fetchAll() - ::fetchCol() removed since it is not used and is only a wrapper for the PDOStatement::fetchColumn() - PDO fetch_style synced accross the app. When no fetch style is passed the default PDO::FETCH_ASSOC is used as set when connecting to db. - Remove Database::escape() method The custom ::escape() method is a wrapper around PDO::quote() which additionally trims leading and trailing quotes from the string. All this should ideally be done via prepared statements only, except where we can and need to use PDO::quote() this step can be done on the given string or variable at hand directly. - Remove escapeSQL() function The escapeSQL function is a wrapper around the PDO::quote() and is using $dbh from the global scope which is not testable nor good practice further on. Removed and refactored into only PDO::quote() usages on required places. - Remove ::fetchOne() method The fetchOne() method is a simple wrapper around the PDOStatement::fetch() method with very minor tweaks so the usage can be simplified even more. The PDOStatement::fetch(\PDO::FETCH_NUM)[0] will always return either a result from the database column or when row is empty a null. - Probably this should be refactored to the database tables respected repositories further on. - Remove PDO wrapper The app's current goal is to lean on a vanilla PDO wrapper only. Current set of features also don't require additional functionality and extending PDO to a wrapper or create a database abstraction layer yet.
show more ...
|
#
9b248f9e |
| 10-Dec-2018 |
Peter Kokot |
Refactor get_pseudo_packages() to repository class Changes: - get_pseudo_packages() function is moved to its own repository class. - Database::queryAll() removed since it is not used
Refactor get_pseudo_packages() to repository class Changes: - get_pseudo_packages() function is moved to its own repository class. - Database::queryAll() removed since it is not used and the method arguments don't match the number of used arguments anymore - Project types configuration is moved to repository class for now. - Some unused items removed - Some template changes and show_project_options() helper function integrated in the view layer directly since it is used in a simplified way.
show more ...
|
#
a06f85b0 |
| 24-Oct-2018 |
Peter Kokot |
Refactor long array() syntax to short [] Since site is using PHP 5.4+ already, the longer `array()` syntax can be refactored to shorter `[]`. Also code is already using short array s
Refactor long array() syntax to short [] Since site is using PHP 5.4+ already, the longer `array()` syntax can be refactored to shorter `[]`. Also code is already using short array syntax on some places.
show more ...
|
#
c2a40c6b |
| 22-Oct-2018 |
Peter Kokot |
Replace PEAR MDB2 constants with PDO constants The changed constants are more understandable using PDO constants nor are the dedicated definition needed anymore.
|
#
180dccfe |
| 17-Oct-2018 |
Peter Kokot |
Trim trailing whitespace
|
#
b6f8cdfe |
| 24-Jul-2017 |
Kalle Sommer Nielsen |
PHP6 was a myth
|
#
c3110c33 |
| 27-Jan-2012 |
Rasmus Lerdorf |
- The end of an era - switch "Bogus" to "Not a bug" by popular demand - Switch back to master - Add site_method to make it easier to install on non-ssl test sites
|
#
17cd2501 |
| 12-Oct-2011 |
Felipe Pena |
- Missing project type information
|
#
c27cc8d7 |
| 11-Mar-2010 |
Jani Taskinen |
- Restore the quick and dirty shame list
|