#
9d47b05f |
| 22-May-2019 |
Peter Kokot |
Convert all tabs to spaces
|
#
5cd2630a |
| 24-Dec-2018 |
Peter Kokot |
Add dependency injection container This patch introduces a dependency injection container for the PHP bug tracker application. Container deals with the creation of all service classe
Add dependency injection container This patch introduces a dependency injection container for the PHP bug tracker application. Container deals with the creation of all service classes and additionally provides retrieving of configuration parameters. Service classes are used everywhere in the app - from accessing database to uploading files. Configuration parameters include infrastructure configuration (database credentials...) and application level configuration (directories locations...). Container is compatible with the PSR-11 container interface defined so it is simple to quickly understand its usage. Advanced features such as autowiring are not included in this phase.
show more ...
|
#
ad8bc2d5 |
| 19-Dec-2018 |
Peter Kokot |
Move bugdb queries to repository
|
#
f0388546 |
| 18-Dec-2018 |
Peter Kokot |
Remove unneeded check for database handle presence This check(s) were once used in previous code for local testings.
|
#
a5b6fa07 |
| 16-Dec-2018 |
Peter Kokot |
Refactor get_resolve_reasons() to repository class
|
#
14f8c07a |
| 14-Dec-2018 |
Peter Kokot |
Refactor PDO wrapper Some considerations were raised on the mailing list that this PHP application doesn't need a PDO wrapper at all. Changes: - ::fetchRow() method removed
Refactor PDO wrapper Some considerations were raised on the mailing list that this PHP application doesn't need a PDO wrapper at all. Changes: - ::fetchRow() method removed in favor of the vanilla PDOStatement::fetch() - ::fetchAll() override removed in favor of the vanilla PDOStatement::fetchAll() - ::fetchCol() removed since it is not used and is only a wrapper for the PDOStatement::fetchColumn() - PDO fetch_style synced accross the app. When no fetch style is passed the default PDO::FETCH_ASSOC is used as set when connecting to db. - Remove Database::escape() method The custom ::escape() method is a wrapper around PDO::quote() which additionally trims leading and trailing quotes from the string. All this should ideally be done via prepared statements only, except where we can and need to use PDO::quote() this step can be done on the given string or variable at hand directly. - Remove escapeSQL() function The escapeSQL function is a wrapper around the PDO::quote() and is using $dbh from the global scope which is not testable nor good practice further on. Removed and refactored into only PDO::quote() usages on required places. - Remove ::fetchOne() method The fetchOne() method is a simple wrapper around the PDOStatement::fetch() method with very minor tweaks so the usage can be simplified even more. The PDOStatement::fetch(\PDO::FETCH_NUM)[0] will always return either a result from the database column or when row is empty a null. - Probably this should be refactored to the database tables respected repositories further on. - Remove PDO wrapper The app's current goal is to lean on a vanilla PDO wrapper only. Current set of features also don't require additional functionality and extending PDO to a wrapper or create a database abstraction layer yet.
show more ...
|
#
99094484 |
| 05-Dec-2018 |
Peter Kokot |
Remove PEAR errors usage from no-feedback cron job The error handling has been refactored via 23298a123688443276f60143c1261f85a85873fe.
|
#
a06f85b0 |
| 24-Oct-2018 |
Peter Kokot |
Refactor long array() syntax to short [] Since site is using PHP 5.4+ already, the longer `array()` syntax can be refactored to shorter `[]`. Also code is already using short array s
Refactor long array() syntax to short [] Since site is using PHP 5.4+ already, the longer `array()` syntax can be refactored to shorter `[]`. Also code is already using short array syntax on some places.
show more ...
|
#
21e0f760 |
| 23-Oct-2018 |
Peter Kokot |
Change dirname(__FILE__) to shorter __DIR__
|
#
180dccfe |
| 17-Oct-2018 |
Peter Kokot |
Trim trailing whitespace
|
#
23298a12 |
| 17-Jul-2018 |
Rasmus Lerdorf |
New bugs.php.net code
|
#
9612686e |
| 30-Dec-2014 |
kovacs.ferenc |
make the shebang more portable
|
#
d7011ab6 |
| 18-Feb-2013 |
Ferenc Kovacs |
I've got you! we were overwritting the variable which was used in the while loop already.
|
#
b8a6d478 |
| 18-Feb-2013 |
Ferenc Kovacs |
there are two more bug fields which the mail_bug_updates() function expects/uses
|
#
99803ca6 |
| 17-Feb-2013 |
Ferenc Kovacs |
make the return value of get_package_mail() more consistent. previously the third item of the returned array could contain either the bcc or the params based on one of the input arguments
|
#
5bab3e64 |
| 17-Feb-2013 |
Ferenc Kovacs |
I'm pretty sure that this was just a copy paste mistake
|
#
10ed048f |
| 18-Apr-2010 |
Daniel Egeberg |
Forgot to update some calls to get_package_mail().
|
#
58ee71e2 |
| 09-Mar-2010 |
Jani Taskinen |
- Added function for adding comments
|
Revision tags: BEFORE_NEW_BUG_TRACKER |
|
#
e27f26a0 |
| 03-Mar-2010 |
Jani Taskinen |
- Get rid of hard-coded message here as well
|
#
401bfec3 |
| 03-Mar-2010 |
Jani Taskinen |
- Added missing "no-feedback cron job
|