Use param->len instead of strlen

Use asprintf return value for the size

Use precomputed length for phpdbg_try_file_init()

Fix GH-12962: Double free of init_file in phpdbg_prompt.c

See GH-12962 for analysis.

Closes GH-12963.

Fix GH-12675: MEMORY_LEAK in phpdbg_prompt.c

Have to use file_put_contents() instead of --FILE-- because we have to
actually load it using the exec command, *and* have to make multiple

Fix GH-12675: MEMORY_LEAK in phpdbg_prompt.c

Have to use file_put_contents() instead of --FILE-- because we have to
actually load it using the exec command, *and* have to make multiple
files, and note that we can only load files relative from the current
directory, so we can't rely on files being in the sapi/phpdbg/tests
folder.

Closes GH-12680.

show more ...

Fix GH-12215: Module entry being overwritten causes type errors in ext/dom (PHP 8.4)

When we try to load an extension multiple times, we still overwrite the
type, module number, and hand

Fix GH-12215: Module entry being overwritten causes type errors in ext/dom (PHP 8.4)

When we try to load an extension multiple times, we still overwrite the
type, module number, and handle. If the module number is used to
indicate module boundaries (e.g. in reflection and in dom, see e.g.
dom_objects_set_class_ex), then all sorts of errors can happen.

In the case of ext/dom, OP's error happens because the following
happens:
- The property handler is set up incorrectly in
dom_objects_set_class_ex() because the wrong module number is
specified. The class highest in the hierarchy is DOMNode, so the
property handler is incorrectly set to that of DOMNode instead of
DOMDocument.
- The documentElement property doesn't exist on DOMNode, it only exists
on DOMDocument, so it tries to read using zend_std_read_property().
As there is no user property called documentElement, that read
operation returns an undef value.
However, the type is still checked, resulting in the strange exception.

Solve this by changing the API such that the data is only overwritten if
it's owned data.

Closes GH-12246.

show more ...

More usage of known zend_str instead of C string (#11381)

Zend/zend_extensions: make zend_extension_version_info const (#10592)

A zend_extension_version_info is never written to.

Fix undefined behaviour in phpdbg_load_module_or_extension

If zend_register_module_ex were to return NULL, then module_entry will
be set to NULL, and the if's body will load module_entry

Fix undefined behaviour in phpdbg_load_module_or_extension

If zend_register_module_ex were to return NULL, then module_entry will
be set to NULL, and the if's body will load module_entry->name. Since
module_entry is NULL, loading the name would cause a NULL pointer
dereference. However, since a NULL pointer dereference is undefined
behaviour, the compiler is free to remove the check.
Fix it by using *name instead of module_entry->name.

Closes GH-10157

Signed-off-by: George Peter Banyard <girgias@php.net>

show more ...

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zen

Remove most usages of zend_fcall_info_args()

This reallocates the PHP array when one can just use the named_params fields to pass the positional arguments instead.

Only usage of zend_fcall_info_args(_ex) remains in PDO.

show more ...

Make vm_interrupt and timed_out atomic (#8327)

This is done by adding a new zend_atomic_bool type. The type
definition is only available for compiler alignment and size info; it
shou

Make vm_interrupt and timed_out atomic (#8327)

This is done by adding a new zend_atomic_bool type. The type
definition is only available for compiler alignment and size info; it
should be treated as opaque and only the zend_atomic_bool_* family of
functions should be used.

Note that directly using atomic_bool is complicated. All C++ compilers
stdlibs that I checked typedef atomic_bool to std::atomic<bool>, which
can't be used in an extern "C" section, and there's at least one usage
of this in core, and probably more outside of it.

So, instead use platform specific functions, preferring compiler
intrinsics.

show more ...

Initialise zend_stat_t to fix MSAN build

Support specifying start position in compile_string

Add additional zend_compile_position argument, which can be either
AT_SHEBANG, AT_OPEN_TAG or AFTER_OPEN_TAG. The previous behavior

Support specifying start position in compile_string

Add additional zend_compile_position argument, which can be either
AT_SHEBANG, AT_OPEN_TAG or AFTER_OPEN_TAG. The previous behavior
corresponds to AFTER_OPEN_TAG.

Closes GH-7462.

show more ...

replace phpdbg custom opcode dumper with O+ dump (#7227)

Fixed some spaces used instead of tabs

remove specialized printing from phpdbg (#7156)

Fix #81135 unknown help topic in phpdbg fails assertion

ditch remote

drop phpdbg web helper extension and wait command (#7144)

Mark various functions with void arguments.

This fixes a bunch of [-Wstrict-prototypes] warning,
because in C func() and func(void) have different semantics.

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Change Zend Stream API to use zend_string* instead of char*.

This allows to eliminate re-calculation of string lenght and hash value.
See the detailed list of changes in UPGRADING.INTERN

Change Zend Stream API to use zend_string* instead of char*.

This allows to eliminate re-calculation of string lenght and hash value.
See the detailed list of changes in UPGRADING.INTERNALS.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix potential file collision in dom tests
Fix bug #80757 (Exit code is 0 when could not open file)
Update NEWS

Merge branch 'PHP-7.4' into PHP-8.0

Fix bug #80757 (Exit code is 0 when could not open file)