Autotools: Normalize flags arguments (#15671)

This is a follow up of 7edb9a07d750a92ceea9371588f10ff2f05df40f that
provides passing compilation options to PHP_NEW_EXTENSION,
PHP_ADD_

Autotools: Normalize flags arguments (#15671)

This is a follow up of 7edb9a07d750a92ceea9371588f10ff2f05df40f that
provides passing compilation options to PHP_NEW_EXTENSION,
PHP_ADD_SOURCES, PHP_ADD_SOURCES_X, and PHP_SELECT_SAPI as a
blank-or-newline-separated argument.

show more ...

Autotools: Normalize PHP_ADD_BUILD_DIR 1st argument (#15612)

The m4_normalize(m4_expand([$1])) expands the given argument if it
contains M4 macros, and then trims the items together into

Autotools: Normalize PHP_ADD_BUILD_DIR 1st argument (#15612)

The m4_normalize(m4_expand([$1])) expands the given argument if it
contains M4 macros, and then trims the items together into a space
separated string in an intuitive way.

show more ...

Autotools: Sync CS in fpm SAPI (#15412)

- AS_* macros used
- obsolete backticks replaced with $(...)
- redundant double quotes removed

Autotools: Fix typo in FPM TCP_CONNECTION_INFO check (#15411)

Otherwise, the check even works with such typo, but this fixes the
TCP_CONNECTION_INFO check on macOS machines for FPM.

Autotools: Replace AC_MSG_ERROR with AC_MSG_FAILURE (#15209)

This replaces the AC_MSG_ERROR with AC_MSG_FAILURE, where appropriate.

The AC_MSG_ERROR outputs given message and exits

Autotools: Replace AC_MSG_ERROR with AC_MSG_FAILURE (#15209)

This replaces the AC_MSG_ERROR with AC_MSG_FAILURE, where appropriate.

The AC_MSG_ERROR outputs given message and exits the configure step. The
AC_MSG_FAILURE does the same but also automatically outputs additional
message "See 'config.log' for more details." which might help directing
the user where to look further.

The AC_MSG_ERROR is used for errors where current test step isn't logged
in the config.log and wouldn't make sense, and AC_MSG_FAILURE is mostly
used in cases of library checks, compilation tests, headers checked with
AC_CHECK_HEADER* and similar tests that are also logged in the
config.log.

AC_MSG_ERROR([Sanity check failed.]) output:

```
configure: error: Sanity check failed.
```

AC_MSG_FAILURE([Sanity check failed.]) output:

```
configure: error: in '/path/to/php-src':
configure: error: Sanity check failed.
See 'config.log' for more details
```

show more ...

Replace PHP_OUTPUT with AC_CONFIG_FILES (#15186)

This is a follow-up of GH-15177
(c96f08aa70d75736fe227975804f998c408acaaf)
and GH-15185
(9467ffb43c0eb271f32f6e435799ccc36bc2b52b

Replace PHP_OUTPUT with AC_CONFIG_FILES (#15186)

This is a follow-up of GH-15177
(c96f08aa70d75736fe227975804f998c408acaaf)
and GH-15185
(9467ffb43c0eb271f32f6e435799ccc36bc2b52b)

The PHP_OUTPUT macro was introduced in the very early phase of the build
system due to AC_OUTPUT handling issues in the old Autoconf versions
before the AC_CONFIG_FILES, AC_CONFIG_COMMANDS etc were introduced with
the AC_OUTPUT signature without arguments. The PHP_OUTPUT was also
helping Makefile.in back then being properly generated based on whether
all files were generated or only some (when using the obsolete
CONFIG_FILES=... ./config.status invocation instead of the new
./config.status --file=...). Another issue is that PHP_OUTPUT can't be
used by extensions when using phpize.

This replaces the PHP_OUTPUT invocations with default AC_CONFIG_FILES.

The obsolete "REDO_ALL" feature at the config.status invocation is also
removed with a simpler unconditional generation.

In phar extension the "ext/phar" is replaced with $ext_dir variable to
be able to use phpize.

show more ...

Autotools: Normalize PHP_OUTPUT arguments (#15177)

The m4_normalize([$1]) normalizes items into a single-space-separated
list of files to append them to the global PHP_OUTPUT_FILES varia

Autotools: Normalize PHP_OUTPUT arguments (#15177)

The m4_normalize([$1]) normalizes items into a single-space-separated
list of files to append them to the global PHP_OUTPUT_FILES variable
that is processed by AC_CONFIG_FILES. Redundant newlines are also
removed in the generated configure script.

PHP extensions using phpize can't use this macro so it's safe to change
this.

show more ...

Autotools: Quote and fix PHP_SELECT_SAPI arguments (#15118)

This macro once had also the 5th argument (the build target), which was
removed via 2a6da0f24cbd04361c044c1cdf6b6b30d08a245e.

Autotools: Quote and fix PHP_SELECT_SAPI arguments (#15118)

This macro once had also the 5th argument (the build target), which was
removed via 2a6da0f24cbd04361c044c1cdf6b6b30d08a245e. This quotes all
PHP_SELECT_SAPI arguments and removes the redundant ones. The basic
macro usage help text is moved to the macros section from the obsolete
docs file.

show more ...

Autotools: Quote macro arguments

- PHP_EXPAND_PATH
- PHP_LIBGCC_LIBPATH
- PHP_OUTPUT
- PHP_REMOVE_USR_LIB

Autotools: Append rt library to FPM_EXTRA_LIBS (#15059)

This appends the possible rt library as needed on Solaris <= 10 to
FPM_EXTRA_LIBS instead of the global LIBS variable for all SAPI

Autotools: Append rt library to FPM_EXTRA_LIBS (#15059)

This appends the possible rt library as needed on Solaris <= 10 to
FPM_EXTRA_LIBS instead of the global LIBS variable for all SAPIs to have
cleaner build. The possible required rt library for other SAPIs is also
checked in the configure.ac.

show more ...

[skip ci] Remove GH-14685 artefact

sapi/fpm: retiring solaris /dev/poll support proposal.

Since Solaris 10, the port API is supported, is more modern, less bug
prone and offers, on average, better performances.

C

sapi/fpm: retiring solaris /dev/poll support proposal.

Since Solaris 10, the port API is supported, is more modern, less bug
prone and offers, on average, better performances.

Close GH-14685

show more ...

Autotools: Refactor PHP-FPM /proc/pid filename check (#14949)

- Check wrapped in AC_CACHE_CHECK using php_cv_file_proc_mem variable
- CS synced

Autotools: Quote all PHP_ADD_BUILD_DIR arguments (#14947)

- All arguments quoted for consistency
- m4_normalize used where list of directories becomes a bit simpler to
read and see

Autotools: Quote all PHP_ADD_BUILD_DIR arguments (#14947)

- All arguments quoted for consistency
- m4_normalize used where list of directories becomes a bit simpler to
read and see the diff

show more ...

Autotools: Use FPM_EXTRA_LIBS for SELinux library (#14885)

Instead of appending -lselinux to global LIBS variable, this adds it as
needed only to FPM_EXTRA_LIBS as it was already used in

Autotools: Use FPM_EXTRA_LIBS for SELinux library (#14885)

Instead of appending -lselinux to global LIBS variable, this adds it as
needed only to FPM_EXTRA_LIBS as it was already used in the BUILD_FPM
invocation.

Follow-up of GH-14881

show more ...

Autotools: Use FPM_EXTRA_LIBS for apparmor library (#14884)

Instead of appending -lapparmor to global LIBS variable, this adds it as
needed only to FPM_EXTRA_LIBS as it was already used

Autotools: Use FPM_EXTRA_LIBS for apparmor library (#14884)

Instead of appending -lapparmor to global LIBS variable, this adds it as
needed only to FPM_EXTRA_LIBS as it was already used in the BUILD_FPM
invocation.

Follow-up of GH-14881

show more ...

Autotools: Use FPM_EXTRA_LIBS for systemd library (#14883)

Instead of appending -lsystemd to global LIBS variable, this adds it as
needed only to FPM_EXTRA_LIBS as it was already used in

Autotools: Use FPM_EXTRA_LIBS for systemd library (#14883)

Instead of appending -lsystemd to global LIBS variable, this adds it as
needed only to FPM_EXTRA_LIBS as it was already used in the BUILD_FPM
invocation. Move php_fpm_systemd substitution after its check.

Follow-up of GH-14881

show more ...

Autotools: Refactor ptrace check for PHP-FPM (#14907)

- This syncs CS and wraps ptrace function check in a single
AC_CACHE_CHECK for optional edge case cross-compiling adjustments

Autotools: Refactor ptrace check for PHP-FPM (#14907)

- This syncs CS and wraps ptrace function check in a single
AC_CACHE_CHECK for optional edge case cross-compiling adjustments
- Overquoted arguments are reduced (first the compilation check if
ptrace in proper form is available on the system and then the run
check if ptrace works as expected)
- The cache variable php_cv_have_mach_vm_read is renamed to
php_cv_func_mach_vm_read.

show more ...

Autotools: Use FPM_EXTRA_LIBS for ACL library (#14881)

- ACL user/group check wrapped in AC_CACHE_CHECK
- instead of appending -lacl to global LIBS variable, this adds it as
needed

Autotools: Use FPM_EXTRA_LIBS for ACL library (#14881)

- ACL user/group check wrapped in AC_CACHE_CHECK
- instead of appending -lacl to global LIBS variable, this adds it as
needed only to FPM_EXTRA_LIBS as it was already used in the BUILD_FPM
invocation

show more ...

Autotools: Refactor mach_vm_read check in FPM (#14830)

- Check wrapped in AC_CACHE_CHECK
- Synced CS

Autotools: Refactor PHP_FPM_BUILTIN_ATOMIC (#14825)

- Check wrapped in AC_CACHE_CHECK
- Synced CS
- Since this can be also compiler agnostic check, "gcc" text replaced
with "co

Autotools: Refactor PHP_FPM_BUILTIN_ATOMIC (#14825)

- Check wrapped in AC_CACHE_CHECK
- Synced CS
- Since this can be also compiler agnostic check, "gcc" text replaced
with "compiler"

show more ...

Autotools: Refactor PHP_FPM_LQ checks (#14828)

- CS synced
- checks wrapped in AC_CACHE_CHECH
- HAVE_LQ_SO_LISTENQ defined unconditionally for simplifications

Autotools: Simplify SAPI configure log check messages (#14764)

The PHP_ARG_ENABLE and PHP_ARG_WITH 2nd argument is the check message in
the configure log output.

Autotools: Sync PHP_SUBST in sapi (#14753)

- Arguments quoted
- Redundant comments removed (some basic help info is in the
build/php.m4)
- APXS variable as such isn't used in t

Autotools: Sync PHP_SUBST in sapi (#14753)

- Arguments quoted
- Redundant comments removed (some basic help info is in the
build/php.m4)
- APXS variable as such isn't used in the generated Makefile, the path
to the apxs tool is inserted during the configure step directly

show more ...

Remove unused defined CPP macros in fpm SAPI (#14740)

* Remove unused defined CPP macros in fpm SAPI

- PHP_FPM_SYSTEMD
- PHP_FPM_USER
- PHP_FPM_GROUP

* [skip ci] Up

Remove unused defined CPP macros in fpm SAPI (#14740)

* Remove unused defined CPP macros in fpm SAPI

- PHP_FPM_SYSTEMD
- PHP_FPM_USER
- PHP_FPM_GROUP

* [skip ci] Update UPGRADING.INTERNALS

show more ...