Introduce pseudo-keyword ZEND_FALLTHROUGH

And use it instead of comments

Attempt to fix ext/spl/tests/bug67359.phpt broken by f323baa845b51e00e8116bc55fa40400a0f70e44

clear only neccessary part of spl_filesystem_object

Reduce number of stat() calls

Fix #42357: fputcsv() has an optional parameter for line endings

fputcsv does not terminate lines correctly as per RFC 41801[1]. After adding a new parameter fputcsv may now use a user defin

Fix #42357: fputcsv() has an optional parameter for line endings

fputcsv does not terminate lines correctly as per RFC 41801[1]. After adding a new parameter fputcsv may now use a user defined line ending,. In order to maintain backwards compatibility fputcsv() still terminates lines with "\n" by default.

Also fixes: #46367[2], #62770[3]
Ref: #42357[4]

[1] <https://tools.ietf.org/html/rfc4180>
[2] <https://bugs.php.net/bug.php?id=46367>
[3] <https://bugs.php.net/bug.php?id=62770>
[4] <https://bugs.php.net/bug.php?id=42357>

show more ...

Use spl_filesystem_object.file_name for SPL_FS_DIR as a cache and prevent multiple file name reconstruction.

Switch to new ZPP

Optimize out zend_strpprintf() usage for simple concationaton

Improve SPL directory and stat() cache using zend_srting* instead of char*

Generate ext/spl class entries from stubs

Closes GH-6709

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix leak when breaking out of FilesystemIterator
Fixed bug #80600

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix leak when breaking out of FilesystemIterator

Fix leak when breaking out of FilesystemIterator

We need to always destroy current, not just when iter.data is not
set.

Take this opportunity to clean up the iterator destructor

Fix leak when breaking out of FilesystemIterator

We need to always destroy current, not just when iter.data is not
set.

Take this opportunity to clean up the iterator destructor code a
bit, to remove redundant checks and incorrect comments.

show more ...

Remove useless zend_update_class_constants() calls

Merge branch 'PHP-8.0'

* PHP-8.0:
SplFileObject::fgets() cannot return false

SplFileObject::fgets() cannot return false

spl_filesystem_file_read() is called with silent=0, so it will
throw on failure.

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Fix #62004: SplFileObject: fgets after seek returns wrong line

As it is, `::seek(0)` sets the file pointer to the beginning of the
file, but `::seek($n)` where `$n > 0` sets the file poi

Fix #62004: SplFileObject: fgets after seek returns wrong line

As it is, `::seek(0)` sets the file pointer to the beginning of the
file, but `::seek($n)` where `$n > 0` sets the file pointer to the
beginning of the following line, having line `$n` already read into the
line buffer. This is pretty inconsistent; we fix it by always seeking
to the beginning of the line.

We also add a test case for the duplicate bug #46569.

Closes GH-6434.

show more ...

Add additional initialization checks to SplFileInfo

Consistent error handling for fgetcsv/fputcsv

Normalize the behavior between the file functions and those on
SplFileObject.

Be consistent about throwing regardless of whether th

Consistent error handling for fgetcsv/fputcsv

Normalize the behavior between the file functions and those on
SplFileObject.

Be consistent about throwing regardless of whether the delimiter etc
is empty or has too many characters. I don't think it's worthwhile
to distinguish these cases.

Back when we looked into this originally, there was some hope that
we might want to add support for multiple-character delimiter etc,
but after a cursory look, I really don't think this is going to
happen (for fputcsv maybe, but for fgetcsv this just makes an already
broken function much more complicated.)

Closes GH-6188.

show more ...

Use ValueError instead of exceptions in SPL extension

Use normal error in SPL for uninitialized objects

Use normal error in SPL for 'An iterator cannot be used with foreach by reference'

Fix UNKNOWN default values in various extensions

Closes GH-6075

Extract common flock code

As SPL is currently a copie of the code in file.c

Closes GH-6069