Fix GH-13685: Unexpected null pointer in zend_string.h

Regressed in 6fbf81c.

There is a missing error check on spl_filesystem_file_read_line(), which
means that if the line coul

Fix GH-13685: Unexpected null pointer in zend_string.h

Regressed in 6fbf81c.

There is a missing error check on spl_filesystem_file_read_line(), which
means that if the line could not be read (e.g. because we're at the end
of the file), it will not set intern->u.file.current_line, which will
cause a NULL pointer deref later on.

Fix it by adding a check, and reintroducing the silent flag partially to
be able to throw an exception like it did in the past.

Closes GH-13692.

show more ...

general signatures discrepencies fixes (#13122)

Fix GH-12721: SplFileInfo::getFilename() segfault in combination with GlobIterator and no directory separator

This broke in 7cd8879 and 9bae9ab. NULL is a perfectly valid return
value th

Fix GH-12721: SplFileInfo::getFilename() segfault in combination with GlobIterator and no directory separator

This broke in 7cd8879 and 9bae9ab. NULL is a perfectly valid return
value that should be handled.

Closes GH-12722.

show more ...

Cache d_type in directory entry

Remove unused is_recursive entry

This only takes up space and time.

Fix GH-11338: SplFileInfo empty getBasename with more than one slash

Regressed in 13e4ce386bb7.

Closes GH-11340.

Use new ZSTR_INIT_LITERAL macro (#10879)

chore: standardize the visibility of functions. (#10708)

Co-authored-by: Marcos Marcolin <marcos@ixcsoft.com.br>

Fix GH-8329 Print true/false instead of bool in error and debug messages (#8385)

Revert GH-10220

Cf. <https://github.com/php/php-src/pull/10220#issuecomment-1383739816>.

This reverts commit ecc880f491d66081298a16634629f149459706a9.
This reverts commit 588a07

Revert GH-10220

Cf. <https://github.com/php/php-src/pull/10220#issuecomment-1383739816>.

This reverts commit ecc880f491d66081298a16634629f149459706a9.
This reverts commit 588a07f7371ee2b5fac17de147926780e427fae6.
This reverts commit f377e15751d3aa48b69cd9bcc366ede7803d511f.
This reverts commit b4ba16fe189b109144aff669e11d81365160104b.
This reverts commit 694ec1deea36e366b28b6349a52be49824e1a1a8.
This reverts commit 6b34de8eba9f66882ae16e6073af28783670ac53.
This reverts commit aa1cd02a4367834026ea2205ea13a2f904455aa1.
This reverts commit 308fd311ea6fcf3094b448df7f2b264f08e4fe4f.
This reverts commit 16203b53e1822a37b6ba6f2ab198bb435d05fdad.
This reverts commit 738fb5ca5412f5e833a7fab82b11519e635a3357.
This reverts commit 9fdbefacd3c382d731aa175b7bdc002ec9cb2b30.
This reverts commit cd4a7c1d90562ebb5f89caf94d00d579631b9fbe.
This reverts commit 928685eba2b2f0ded90e7f78fd806ea164002f6e.
This reverts commit 01e5ffc85cd4357fd7b5b7ceefa29f2d10ca26b7.

show more ...

ext/{standard,json,random,...}: add missing includes

Fix GH-9883 SplFileObject::__toString() reads next line

We need to overwrite the __toString magic method for SplFileObject, similarly to how DirectoryIterator overwrites it
Moreover, th

Fix GH-9883 SplFileObject::__toString() reads next line

We need to overwrite the __toString magic method for SplFileObject, similarly to how DirectoryIterator overwrites it
Moreover, the custom cast handler is useless as we define __toString methods, so use the standard one instead.

Closes GH-9912

show more ...

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included i

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included in PHP 8.2 RC1. Given it's a massive ABI break, we decide to postpone the change to PHP 8.3.

show more ...

Port all internally used classes to use default_object_handlers

Signed-off-by: Bob Weinand <bobwei9@hotmail.com>

Declare ext/spl constants in stubs (#9226)

SPL: Use new improved is_line_empty() function instead of the old one (#9217)

Refactor code handling file.current_zval (#8934)

The Zval is always an array

Fix #69181: READ_CSV|DROP_NEW_LINE drops newlines within fields

One may argue that `DROP_NEW_LINE` does not make sense in combination
with `READ_CSV`, but without `DROP_NEW_LINE`, `SKIP_

Fix #69181: READ_CSV|DROP_NEW_LINE drops newlines within fields

One may argue that `DROP_NEW_LINE` does not make sense in combination
with `READ_CSV`, but without `DROP_NEW_LINE`, `SKIP_EMPTY` does not
skip empty lines at all. We could fix that, but do not for BC reasons.
Instead we no longer drop newlines in `spl_filesystem_file_read_ex()`
when reading CSV, but handle that in `spl_filesystem_file_read_csv()`
by treating lines with only (CR)LF as being empty as well.

Closes GH-7618.

show more ...

Make php_fgetcsv() return a HashTale instead of in-out zval param (#8936)

Also refactor what happens on an empty line to return NULL instead of setting the array to [NULL] which makes no des

Make php_fgetcsv() return a HashTale instead of in-out zval param (#8936)

Also refactor what happens on an empty line to return NULL instead of setting the array to [NULL] which makes no design sense at all.
However, as this is the current behaviour create a BC Shim inline function to recreate this weird HashTable in the functions which currently use this API

show more ...

Use true/false and comment when arg correspond to silent arg

Remove silent argument to spl_filesystem_file_read_line_ex()

true was always passed to it

Remove silent argument to spl_filesystem_file_read_line()

true was always passed to it

Merge branch 'PHP-8.1'

* PHP-8.1:
Revert "Fix GH-8563 Different results for seek() on SplFileObject and SplTempFileObject"
Revert "Update FreeBSD CI image."

Merge branch 'PHP-8.0' into PHP-8.1

* PHP-8.0:
Revert "Fix GH-8563 Different results for seek() on SplFileObject and SplTempFileObject"

Revert "Fix GH-8563 Different results for seek() on SplFileObject and SplTempFileObject"

Although the fix is partially correct it also breaks long standing behaviour which has been produced

Revert "Fix GH-8563 Different results for seek() on SplFileObject and SplTempFileObject"

Although the fix is partially correct it also breaks long standing behaviour which has been produced since PHP 5.3.

This reverts commit 6f87a5c6338d0d64d18e3a44b65c19acc9c529e8.

show more ...