No need for the double name pointer

Use xmlStrEqual() instead of !xmlStrCmp()

This actually shows the intent clearer, and also from the docs of
xmlStrEqual:
"Should be a bit more readable and faster than xmlStrcmp()".

Remove double class entry variable

Remove dead code from sxe_get_element_by_name()

retnode will never be set to anything other than NULL, because the
branch is always taken if the names match.

Implement iteration cache, item cache and length cache for node list iteration (#11330)

* Implement iteration cache, item cache and length cache for node list iteration

The current

Implement iteration cache, item cache and length cache for node list iteration (#11330)

* Implement iteration cache, item cache and length cache for node list iteration

The current implementation follows the spec requirement that the list
must be "live". This means that changes in the document must be
reflected in the existing node lists without requiring the user to
refetch the node list.
The consequence is that getting any item, or the length of the list,
always starts searching from the root element of the node list. This
results in O(n) time to get any item or the length. If there's a for
loop over the node list, this means the iterations will take O(n²) time
in total. This causes real-world performance issues with potential for
downtime (see GH-11308 and its references for details).

We fix this by introducing a caching strategy. We cache the last
iterated object in the iterator, the last requested item in the node
list, and the last length computation. To invalidate the cache, we
simply count the number of modifications made to the containing
document. If the modification number does not match what the number was
during caching, we know the document has been modified and the cache is
invalid. If this ever overflows, we saturate the modification number and
don't do any caching anymore. Note that we don't check for overflow on
64-bit systems because it would take hundreds of years to overflow.

Fixes GH-11308.

show more ...

Fix GH-8329 Print true/false instead of bool in error and debug messages (#8385)

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included i

Revert "Port all internally used classes to use default_object_handlers"

This reverts commit 94ee4f9834743ca74f6c9653863273277ce6c61a.

The commit was a bit too late to be included in PHP 8.2 RC1. Given it's a massive ABI break, we decide to postpone the change to PHP 8.3.

show more ...

Port all internally used classes to use default_object_handlers

Signed-off-by: Bob Weinand <bobwei9@hotmail.com>

Convert return type of various object handlers from int to zend_result (#8755)

Merge branch 'PHP-8.0'

* PHP-8.0:
NEWS
Fix bug #81325 Segfault in zif_simplexml_import_dom

Fix bug #81325 Segfault in zif_simplexml_import_dom

Add RETURN/RETVAL_COPY_DEREF() macros

These were missing from the set...

I think quite a few of these usages don't actually need the DEREF,
but I've just kept things as is for n

Add RETURN/RETVAL_COPY_DEREF() macros

These were missing from the set...

I think quite a few of these usages don't actually need the DEREF,
but I've just kept things as is for now.

show more ...

Not serializable flag permeation

Fixed some spaces used instead of tabs

Remove SimpleXMLElement dtor_obj handler

I don't see any reason why this cleanup needs to happen inside
dtor_obj.

If there is a reason, it's lacking in test coverage...

Declare tentative return types for ext/simplexml

Closes GH-7003

Drop SXE_METHOD() macro

Don't break my grep.

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Sorry, this solution seems to have BC breaks, will need to look
for better one.

This reverts commit 9

Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"

Sorry, this solution seems to have BC breaks, will need to look
for better one.

This reverts commit 9f7e8b777cb3e8aac53e677f3152af18413ab672.

show more ...

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement