Fix argument type of simplexml_import_dom (#13170)

It needs to be "object".
This is because first- and third-party extension can register custom
node types using `php_libxml_register

Fix argument type of simplexml_import_dom (#13170)

It needs to be "object".
This is because first- and third-party extension can register custom
node types using `php_libxml_register_export`. So we don't know upfront
what types can be expected.

This also changes the error to a TypeError everywhere.

show more ...

general signatures discrepencies fixes (#13122)

Fix GH-12929: SimpleXMLElement with stream_wrapper_register can segfault

Move SimpleXML invalidation code after node checks

This is safe, i.e. the tree hasn't been modified yet, bec

Fix GH-12929: SimpleXMLElement with stream_wrapper_register can segfault

Move SimpleXML invalidation code after node checks

This is safe, i.e. the tree hasn't been modified yet, because either we
didn't call a libxml modification function yet, or xmlNewChild is called
with a NULL pointer, which makes it bail out and return NULL.

Closes GH-12947.

show more ...

Fix getting the address of an uninitialized property of a SimpleXMLElement resulting in a crash

Closes GH-12945.

Apply SimpleXML iterator fixes only on master

Many methods in SimpleXML reset the iterator when called. This has the
consequence that mixing these operations with loops can cause infinit

Apply SimpleXML iterator fixes only on master

Many methods in SimpleXML reset the iterator when called. This has the
consequence that mixing these operations with loops can cause infinite
loops, or the loss of iteration data.
Some people may however rely on the resetting behaviour. To prevent
unintended breaks in stable branches, let's only apply the fix to master.

This reverts GH-12193, GH-12229, GG-12247 for stable branches while
keeping them on master, adding a note in UPGRADING as well.

show more ...

Fix GH-12167 and GH-12169: Unable to get comment or processing instruction contents in SimpleXML

Closes GH-12289.

Fix bug #55098: SimpleXML iteration produces infinite loop

Closes GH-12247.

Fix GH-12208: SimpleXML infinite loop when a cast is used inside a foreach

Closes GH-12229.

Simplify php_sxe_count_elements_helper() by using non-destructive iterator reset

Use php_sxe_reset_iterator_no_clear_iter_data() to avoid having to store and restore iterator data

This makes the code less error-prone, and also makes it simpler.

Remove unnecessary _IS_BOOL case (#12230)

This can never be executed because booleans are handled in a special
case at the top of sxe_object_cast_ex().

Fix GH-12223: Entity reference produces infinite loop in var_dump/print_r

Closes GH-12223.

Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach

This happens because getName() resets the iterator to the start because
it overwrites the iterator data.

Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach

This happens because getName() resets the iterator to the start because
it overwrites the iterator data.
We add a version of get_first_node that does not overwrite the iterator
data.

Closes GH-12193.

show more ...

Simplify node check in simplexml

Fix GH-12170: Can't use xpath with comments in SimpleXML

Closes GH-12177.

Small optimization in php_sxe_get_first_node() by avoiding unwrapping iterator data (#12194)

Fix #52751: XPath processing-instruction() function is not supported.

Closes GH-12165.

Remove useless SKIP_TEXT() invokes (#12164)

In the places I removed them, they were useless because there is already
a type check for a single node type, so I found it confusing having t

Remove useless SKIP_TEXT() invokes (#12164)

In the places I removed them, they were useless because there is already
a type check for a single node type, so I found it confusing having them
there.

show more ...

Preallocate result array size in simplexml xpath

This is the simplexml version of 4dea42a.

Remove obsolete libxml2 code

LIBXML2_NEW_BUFFER is always defined since libxml2 2.9.0.
That's the minimum version PHP requires, so it will always be defined.

Revert "Call cast_object handler from get_properties_for"

This reverts commit 4182813ebffe0570e3741debd7da543df3517d0d.

Sanitize libxml2 globals before parsing

Fixes GHSA-3qrf-m4j2-pcrr.

To parse a document with libxml2, you first need to create a parsing context.
The parsing context contains par

Sanitize libxml2 globals before parsing

Fixes GHSA-3qrf-m4j2-pcrr.

To parse a document with libxml2, you first need to create a parsing context.
The parsing context contains parsing options (e.g. XML_NOENT to substitute
entities) that the application (in this case PHP) can set.
Unfortunately, libxml2 also supports providing default set options.
For example, if you call xmlSubstituteEntitiesDefault(1) then the XML_NOENT
option will be added to the parsing options every time you create a parsing
context **even if the application never requested XML_NOENT**.

Third party extensions can override these globals, in particular the
substitute entity global. This causes entity substitution to be
unexpectedly active.

Fix it by setting the parsing options to a sane known value.
For API calls that depend on global state we introduce
PHP_LIBXML_SANITIZE_GLOBALS() and PHP_LIBXML_RESTORE_GLOBALS().
For other APIs that work directly with a context we introduce
php_libxml_sanitize_parse_ctxt_options().

show more ...

Call cast_object handler from get_properties_for

Fixes GH-11547
Closes GH-11583

[skip ci] Fixed comment for SimpleXml function getName (#11537)

Co-authored-by: David Huang <david.huang@check24.de>

More usage of known zend_str instead of C string (#11381)