History log of /php-src/ext/shmop/tests/gh14537.phpt (Results 1 – 2 of 2)
Revision Date Author Comments
# 0695b977 22-Sep-2024 Christoph M. Becker

Make ext/shmop/tests/gh14537.phpt more resilient (GH-15985)

The actual problem is our `shmget()` implementation which does not care
to set `errno` appropriately; that should be fixed, al

Make ext/shmop/tests/gh14537.phpt more resilient (GH-15985)

The actual problem is our `shmget()` implementation which does not care
to set `errno` appropriately; that should be fixed, although mapping
the error conditions to those specified by POSIX might be hard.

For now, we only make the test case more resilient by ignoring the
exact error; "No error" doesn't make sense anyway.

show more ...


# 39a32665 28-Jun-2024 Niels Dossche <7771979+nielsdos@users.noreply.github.com>

Fix GH-14537: shmop Windows 11 crashes the process

The error handling code isn't entirely right in two places.
One of the code blocks is dead because of an always-false condition, and

Fix GH-14537: shmop Windows 11 crashes the process

The error handling code isn't entirely right in two places.
One of the code blocks is dead because of an always-false condition, and
another code block is missing the assignment of a NULL pointer.

Getting the exact same behaviour is not entirely possible because you
can't extend the size of a shared memory region after it was made with
the Windows APIs we use, unless we destroy the region and recreate it,
but that has other consequences.
However, it certainly shouldn't crash.

Closes GH-14707.

show more ...