ext/phar: Refactor phar_call_openssl_signverify()

ext/phar: Remove phar_resolve_alias() (#15860)

As this is unused and a SourceGraph search returns 0 result

ext/phar: Reorganise some headers

ext/phar: Use more specialized types instead of int

ext/phar: Move some header functions into util.c

They were only used there, therefore mark them static

Use "must not" instead of "cannot" wording

ext/phar: Use standard C types

Remove unused fields from phar_entry_data() (#14144)

These fields are only ever written to, but never read.

Fix potential NULL pointer dereference before calling EVP_SignInit

Closes GH-13870.

Add missing check on EVP_VerifyUpdate() in phar util

Closes GH-11640.

Minor conditions simplify (#10397)

ext/phar: Fix recently introduced potential NULL dereferencement segfaults (#11065)

ext/phar: Prevent unnecessary known string length computation

Closes GH-11033

Convert char* + size_t parameters to zend_string* in phar_find_in_include_path()

Cleanup pubkey checks in ext/phar (#11009)

These checks are always true because we bail out early if pubkey is
NULL or empty.
But by having these checks, it makes the code more confu

Cleanup pubkey checks in ext/phar (#11009)

These checks are always true because we bail out early if pubkey is
NULL or empty.
But by having these checks, it makes the code more confusing because it
implies pubkey can be false, while it can in fact not.

show more ...

Add missing error checks on EVP_MD_CTX_create() and EVP_VerifyInit()

The first one returns NULL on error, and the second one returns 0 on
error. These weren't checked.

Closes GH

Add missing error checks on EVP_MD_CTX_create() and EVP_VerifyInit()

The first one returns NULL on error, and the second one returns 0 on
error. These weren't checked.

Closes GH-10762.

show more ...

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[

Use more compact representation for packed arrays.

- for packed arrays we store just an array of zvals without keys.
- the elements of packed array are accessible throuf as ht->arPacked[i]
instead of ht->arData[i]
- in addition to general ZEND_HASH_FOREACH_* macros, we introduced similar
familied for packed (ZEND_HASH_PACKED_FORECH_*) and real hashes
(ZEND_HASH_MAP_FOREACH_*)
- introduced an additional family of macros to access elements of array
(packed or real hashes) ZEND_ARRAY_ELEMET_SIZE, ZEND_ARRAY_ELEMET_EX,
ZEND_ARRAY_ELEMET, ZEND_ARRAY_NEXT_ELEMENT, ZEND_ARRAY_PREV_ELEMENT
- zend_hash_minmax() prototype was changed to compare only values

Because of smaller data set, this patch may show performance improvement
on some apps and benchmarks that use packed arrays. (~1% on PHP-Parser)

TODO:
- sapi/phpdbg needs special support for packed arrays (WATCH_ON_BUCKET).
- zend_hash_sort_ex() may require converting packed arrays to hash.

show more ...

implement openssl_256 and openssl_512 for phar singatures

switch phar to use sha256 signature by default

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Introduce pseudo-keyword ZEND_FALLTHROUGH

And use it instead of comments

Change Zend Stream API to use zend_string* instead of char*.

This allows to eliminate re-calculation of string lenght and hash value.
See the detailed list of changes in UPGRADING.INTERN

Change Zend Stream API to use zend_string* instead of char*.

This allows to eliminate re-calculation of string lenght and hash value.
See the detailed list of changes in UPGRADING.INTERNALS.

show more ...

Fix ASAN warning (Zend/zend_string.h:165:2: runtime error: null pointer passed as argument 2 of memcpy(), which is declared to never be null)

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fix #77322: PharData::addEmptyDir('/') Possible integer overflow

Fix #77322: PharData::addEmptyDir('/') Possible integer overflow

`phar_path_check()` already strips a leading slash, so we must not
attempt to strip the trailing slash from an now empty

Fix #77322: PharData::addEmptyDir('/') Possible integer overflow

`phar_path_check()` already strips a leading slash, so we must not
attempt to strip the trailing slash from an now empty directory name.

Closes GH-6508.

show more ...