Fix GH-13998: Manage refcount of agg_context->val correctly (#14004)

When step_callback fails, agg_context->val is passed dtor, but agg_context->val
is also used in final_callback regard

Fix GH-13998: Manage refcount of agg_context->val correctly (#14004)

When step_callback fails, agg_context->val is passed dtor, but agg_context->val
is also used in final_callback regardless of the success/failure of step_callback,
so should not call dtor.

closes #14004
fixes #13998

show more ...

Fix GH-13984: Buffer size is now checked before memcmp (#13991)

Fixed an issue where a buffer overflow occurred when a string shorter than
`:memory:` was passed as the db name of pdo_sql

Fix GH-13984: Buffer size is now checked before memcmp (#13991)

Fixed an issue where a buffer overflow occurred when a string shorter than
`:memory:` was passed as the db name of pdo_sqlite.

fixed #13984
closes #13991

show more ...

Implement PDO driver-specific subclasses

RFC: https://wiki.php.net/rfc/pdo_driver_specific_subclasses
Closes GH-12804

Co-Authored-By: Danack <Danack@basereality.com>

ext/pdo_sqlite: simplifying sqlite3_exec usage. (#10910)

pdo_sqlite_error copy the error message via the php's allocator,
while the one from sqlite3_exec is unused.

Improve fix for bug #81740

Fix #81740: PDO::quote() may return unquoted string

`sqlite3_snprintf()` expects its first parameter to be `int`; we need
to avoid overflow.

Merge branch 'PHP-8.1'

* PHP-8.1:
Fix GH-9032: SQLite3 authorizer crashes on NULL values

Merge branch 'PHP-8.0' into PHP-8.1

* PHP-8.0:
Fix GH-9032: SQLite3 authorizer crashes on NULL values

Fix GH-9032: SQLite3 authorizer crashes on NULL values

The arguments 3 to 6 of the authorizer callback may be `NULL`[1], and
we have to properly deal with that. Instead of causing a seg

Fix GH-9032: SQLite3 authorizer crashes on NULL values

The arguments 3 to 6 of the authorizer callback may be `NULL`[1], and
we have to properly deal with that. Instead of causing a segfault, we
deny authorization, which is still better than a crash, and apparently,
we cannot do better anyway.

[1] <https://www.sqlite.org/c3ref/set_authorizer.html>

Closes GH-9040.

show more ...

Drop support for SQLITE_COPY in authorizer callback

According to the sources, `SQLITE_COPY` is unused as of SQLite
3.6.10[1] (at least), so there is no need to support it any longer; we

Drop support for SQLITE_COPY in authorizer callback

According to the sources, `SQLITE_COPY` is unused as of SQLite
3.6.10[1] (at least), so there is no need to support it any longer; we
require at least SQLite 3.7.7 at minimum.

[1] <https://github.com/sqlite/sqlite/blob/version-3.6.10/src/sqlite.h.in#L2411>

Closes GH-9041.

show more ...

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Add functions to convert i64/u64 to string

PDO implement half of this, but this functionality is generally
useful. Provide these as zend_u64_to_str and zend_i64_to_str to
complement

Add functions to convert i64/u64 to string

PDO implement half of this, but this functionality is generally
useful. Provide these as zend_u64_to_str and zend_i64_to_str to
complement zend_long_to_str.

show more ...

Use standard PDO way for fetching integer attribute values

Allow specifying sqlite3 DSN (file:/) in PDO SQLite

Closes GH-6610.

Refactor PDO's last inserted ID handler to use and return zend_string

Closes GH-6617

Refactor PDO doer handler to use zend_string

Make convert_to_*_ex simple aliases of convert_to_*

Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
sin

Make convert_to_*_ex simple aliases of convert_to_*

Historically, the _ex variants separated the zval first, if a
conversion was necessary. This distinction no longer makes sense
since PHP 7.

The only difference that was still left is that _ex checked whether
the type is the same first, but the usage of these macros did not
actually distinguish on whether such an inlined check is valuable
or not in a given context.

Also drop the unused convert_to_explicit_type macros.

show more ...

Refactor PDO's quoter handler to return a zend_string

Closes GH-6547

Voidify PDO's fetch_error handler

Boolify PDO's preparer handler

Voidify PDO's closer handler

Boolify PDO's quoter handler

Boolify PDO's set_attribute driver function

Boolify PDO's transaction handlers

This includes begin(), commit(), rollBack(), and inTransaction()

PDO: Store/pass query_string as zend_string

Rather than storing char* + size_t, use a zend_string*. Also
avoid various copies of the query string.